From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A15342DC798 for ; Wed, 27 May 2026 14:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779891367; cv=none; b=AYhRl8QZ2CKvxsm5EqQhYZOFCgrLMzFEyxgez+BJE+sfTP8pUS5aNrPEXiwL7LqCywxTfM5AEUWataWqZwYHAVPU/ZzqqyyKHgyVJv1UaCHtYbC+RurzDg54lcMkcPb3cnqq0tVT5BwcURN5O5sLSV5NCFElpgFs0Q0N4boz81Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779891367; c=relaxed/simple; bh=rwIJZwdE0h/vGwpewVyInBfM50pssfa9h16XffX+lY0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type:Content-Disposition; b=Lyb2wQZIX6h/mHTcNi7Au6CCLQSOpiOTmPVxWO/XSxIswvxN7tx+aSw7oNl6fjjJUjXMdonRB15u3AztZQho8lTMYFBEuMxCplz/xAWLVmYYRfk0jtUQjuCGTax4iZ4XFZcNK1M4/L+hKInKWIGMzuVlEjwQjTiI/5EzsflcXcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ln1fQQSF; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ln1fQQSF" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b941cd869cso76369155ad.1 for ; Wed, 27 May 2026 07:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779891366; x=1780496166; darn=vger.kernel.org; h=content-transfer-encoding:content-disposition:mime-version :mail-followup-to:references:in-reply-to:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GzVcryfU9QxZddocswZazrJnx5GUut5UQLQcVR/qt2o=; b=ln1fQQSFl0ff4QyEjpwc2jwX4jb5xohSdkYyhO7cskouo+sV6UtJ4uNasSNa+o9Uvi 7/nGDdns10Pr00EBix2uEQMzAaGrickjx/OAiIgSIoQdaarZ1DvBBqihQcx0YSCR1SIa tXDwQFxsq6Gz/jWOluXHX+QRkpJz74rJP90S5AAPx0pGHb8LcRdGkDP3xoazP/YXmdGE +af1f4gGpfJEjLW9bmjG/+7MdQd+bHzhr2F5awNFQEML4IC3VuxqSIOUAqCjTbuwZIll XIPiW1n7SkUpLb84DHoSR6V9PiZ4u3/9PNvFGDnuiPaQZIkictcCqhRaip0zwLCifiIF fAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779891366; x=1780496166; h=content-transfer-encoding:content-disposition:mime-version :mail-followup-to:references:in-reply-to:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GzVcryfU9QxZddocswZazrJnx5GUut5UQLQcVR/qt2o=; b=QwjF9wLxIakBJP9zB9JH7jJg1JRfsHODVeurMaynlrLik3qXFXBTvJ3AAbQAfJ+gMM +NnUYl4u1ZgzfNU08VIVaIFYIHyu8u80xO7EuvsTqhthpwm7kIyShPfqb+UesoRBLkxm +BBDbaByQ8pYqhrOLGqAU6TzV1tm4wzuUOe4vjmugniYYvKYEAF90MC4yFxmvGeMtel1 Obvm3QLY2fXMdg1Y5wTYoSzsWsnpmHZbUDcEO/3+oblaLJs4gSICGtOYjQ9QFE0fS7K+ r0hIMVFFhhF9njiWBBc+Z71R9B9BguTvfxe34DG70xs8V/qxUMNfoibCRHfiQpMgYAKf DTCw== X-Forwarded-Encrypted: i=1; AFNElJ/0yoi+Oh6a6xIJZFrwxkQdwPn8EA0SmRtTvt+lDVBY+WKazCQTawZ4E4bul0FbrmFtA31gx866JAGQEG8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx19tHNlc0VGA49zZCCoUSgZRpUeQTYR1mCciGBvlfwjzItgivy 7HGIfvNyLb/YvUPi6xpNH03TBABOe9Unsx+690WpV/cXa/YQUmpasR/Z X-Gm-Gg: Acq92OGs7ZIjn5jhUkizX9hXAHMzpxUjKG4n7a3zeNm+rGcIAS9b6FLXiXvDJaZjI0p X+xA1gg1GtpIdxkBbdw3vEjZ1fHzI2BLOLuwchl2v//NmZPF7Su5Q0U7zGLoGIDKDv8xt1uai2M +M/cdy56uPV3mCr6XFW0Oyuz4UxhFHrsp469NnwplaOmenMGykEXMpD/IKfPSBPAz1tLhpPZNF+ S2qs2j0RABURDc7TNU0JDNXrTQt46vRqmU92f44eYy3vhZCqzAD2M4WtvJ7NSGw0xt35Jdu9pP5 PhHCSnBxP7g1R1kj5xtF4maedwKSGE492zhPPi4aDI4znkHGi4LGFyn5GhYNloDfYMv8hpfEP8c UFAvFWvww3snlAM3xmJ+joVagAsYaex94iJH2iAOPTx5d4CvMol+yb/mgENbEy7T3TDHhqXDJd3 VXvP9h5L159+6Wq6Ru8UcbCGFg1U9wwshnRJDoPgGKLf2EU4U= X-Received: by 2002:a17:902:d4d1:b0:2bd:a5f:1d04 with SMTP id d9443c01a7336-2beb05bf787mr246093385ad.9.1779891365968; Wed, 27 May 2026 07:16:05 -0700 (PDT) Received: from localhost.localdomain ([116.80.91.208]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58b3085sm154156885ad.53.2026.05.27.07.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 07:16:05 -0700 (PDT) From: Cunlong Li To: Sergey Senozhatsky Cc: Minchan Kim , Jens Axboe , Andrew Morton , Christoph Hellwig , linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/2] zram: fix UAF in zram_bvec_write_partial() and drop dead bio plumbing Date: Wed, 27 May 2026 22:15:59 +0800 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: <20260527-zram-v2-0-2fb84b054b5c@gmail.com> Mail-Followup-To: Cunlong Li , Sergey Senozhatsky , Minchan Kim , Jens Axboe , Andrew Morton , Christoph Hellwig , linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, May 27, 2026 at 04:21:53PM +0900, Sergey Senozhatsky wrote: > On (26/05/27 12:49), Cunlong Li wrote: > > Patch 1 fixes a use-after-free in zram_bvec_write_partial() that > > happens on PAGE_SIZE > 4K configurations when a partial write hits a > > ZRAM_WB slot. > > > > Patch 2 is a follow-up cleanup that drops the now-unused bio parameter > > from zram_bvec_write_partial() and zram_bvec_write(), no functional > > change. > > Did you test it? Compile-tested only so far; I haven't had a chance to run a PAGE_SIZE > 4K reproducer yet. Thanks for the review. > > Looks reasonable (unless I'm missing something): > Reviewed-by: Sergey Senozhatsky