From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF323890F8 for ; Wed, 27 May 2026 19:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779910501; cv=none; b=h6MCWr5ceI3yK0KwZCmT5OM4eZY0P1u4X9ZhWXiWF8+t/wto2ln26Q1bcRoR8oztceHhSqGsHQ8Uj4XFaOwZCcaJxiB4po6m7j24/Yq9Ys85Dfdx5j8O552XhZnPW/vSJ7Fr5jmEyrU7tWjtWU/JF8WPuGdNrvPrIz+n3AedCQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779910501; c=relaxed/simple; bh=gNtu3I8dan5PtJoijFcBOSVKlBDemQlQMVY7dWwaBXU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rTc0KOr3/fILREU9ps6uWAWc429aKuy7Qddkyw3cClIqP3BJ0TkkSATOCPn8SRQsoY9MTuU5TJVWrTTSJOkmww03C3DKSW/P1H1pa5AJckK4jh4sWhUR6Rcv0ytUz1r/2rbsdCv8gshKBCcH81CeFMVk3WGIJc0zSHgG/WVLrHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sJa0tRAT; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sJa0tRAT" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2f0ad52830cso15395139eec.1 for ; Wed, 27 May 2026 12:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779910486; x=1780515286; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JTNqcC36SPBRRdFnrJ/yAEkzgUWymNhZiWM/17f+GfM=; b=sJa0tRAToHWmztCbhBLAZtOZPSAPZDxvFd7cXV5tYfWVx1gPxMimGz6hgvxjY9AYv/ j0wkYVubL1rnelar+UvbNtkKuBRs461rg8YyMBzAKbkzb8OH3AhcU89QPa9NuzRI1Mau K2LYiMi8WpR1YYWG8AbxOEGbihX2MqrO0jzsDXvPGyQKBNzBgQO6m2nPySAcX8srnZNX SchObzcDz9MgU08n7WPU7Ga+bgNaHDu0JNiE+lqjqX1pzqV6diVcvXxDATy7SNac1wNy NF3Nq0yUlDTDgYCxgWXE9d7JzscSyS+7GaNaKI8q4ILUBtfWBVR6On3kyh/WIIYFCLcN fZJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779910486; x=1780515286; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTNqcC36SPBRRdFnrJ/yAEkzgUWymNhZiWM/17f+GfM=; b=ChPJIcCVBnkGMqTloSQtrpnH/wLgjid2N/VT1ynGy4d6Hi5kh+HzhCpKaE1asTWcyG pIhHCeI7w78Kdwzg3wULEGzeRPaDu/0sY+hrsSBq4v/pj/Lz/pVysugm7OAq7r+FzF0g eVwlNrLdAIrjRsOisxoSYScYP/7kygws9BQ7LhUqumIqRwjZ/fjc2wIFo9FJLtoXwr6h CMyAO+anQJTZt3Wuvgci9u3hr7Ur3qkGsCave3hab5PvZjucepMOtGxoEZQjAm1msmvo hAqeK5+igUqlOKlSIxh5Yub2vjRXM/KuxwJCi/roAcEoybiqZePWbLtpUBUcWprBAwAr +3Mw== X-Forwarded-Encrypted: i=1; AFNElJ+5SoPHXGJR5oLaDmZT8zZqrZh40IqHrBb3aoX/162Xf0au9BvE0eLZ/EOtZmtbPCgNCfboWwy8jDOPQNs=@vger.kernel.org X-Gm-Message-State: AOJu0YzkHN0GRWd79oJLAyhZY06hkymUs8UYzQMH2CryHCRvIVrwFWQT IY4OCBGb7Wqx7NqrY5XhTZNf7qUjBCDAemiWJukpbrLsL1ObMRlDRIZR X-Gm-Gg: Acq92OGiY+n8JYUb61/0/1XEjZDNUlVj89qPoMgVp3zjFc5/uK5feu63Ml1TdIFLDzL MXgKFn2uOwZz9SEkKqwr4CgAJfqZdqZUqpS4FsitTM/5CI634L3cdF6viSeVKBW6Vo9XClsTfrm 54WIzO24SRwk6+dYn4/lBglrgNekxWMjMWh/mvHOgQ/xt5o1KTWw2UB/ROm6cAztIDttt8i/YxI y9/vgZg7NSOsht6Mlj0vhBBt2MCt7XKAVWCDY2v9Dp95PSXnb4qPG1tWsRXjaSqHyc/6Y+2VbPa dvxIqSI/HIm+QH6sZ8jfzC1uHWX1l5UQST/EvBylQfx4K9yNcFXX6RtwQMFPX6GTnxxpM+is53X 7ZlsEySbWfeqUNyJsFE49pYtChiHYF4gogTys4z+KTjYm8OX42nFQUG+o+8c27nxpCknQbVEyoj hf/QoEI6ZcvGWUuH30XAbbaKA6yGHAH4tZUVwNPNzSBLbRAWBkf6o5pL7YZNReaeBRYVWhzuC1o wE= X-Received: by 2002:a05:7300:ef89:b0:2ed:23cd:babf with SMTP id 5a478bee46e88-304490906d0mr10929946eec.12.1779910485730; Wed, 27 May 2026 12:34:45 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:ca8d:7a6a:7fd3:5948]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304524610f7sm13502866eec.29.2026.05.27.12.34.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 12:34:44 -0700 (PDT) Date: Wed, 27 May 2026 12:34:42 -0700 From: Dmitry Torokhov To: Myeonghun Pak Cc: Ping Cheng , Jason Gerecke , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ijae Kim Subject: Re: [PATCH] HID: wacom: stop hardware after post-start probe failures Message-ID: References: <20260524175552.1973-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260524175552.1973-1-mhun512@gmail.com> Hi Myeonghun, On Mon, May 25, 2026 at 02:53:33AM +0900, Myeonghun Pak wrote: > wacom_parse_and_register() starts HID hardware before registering inputs > and initializing pad LEDs/remotes. Those later steps can fail, but their > error paths currently release Wacom resources without stopping the HID > hardware. > > Route post-hid_hw_start() failures through hid_hw_stop() before > releasing driver resources. > > This issue was identified during our ongoing static-analysis research while > reviewing kernel code. > > Fixes: c1d6708bf0d3 ("HID: wacom: Do not register input devices until after hid_hw_start") > Cc: stable@vger.kernel.org > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Signed-off-by: Myeonghun Pak > --- > drivers/hid/wacom_sys.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c > index 0d1c6d90fe..c824d9c224 100644 > --- a/drivers/hid/wacom_sys.c > +++ b/drivers/hid/wacom_sys.c > @@ -2456,16 +2456,16 @@ static int wacom_parse_and_register(struct wacom *wacom, bool wireless) > > error = wacom_register_inputs(wacom); > if (error) > - goto fail; > + goto fail_hw_stop; > > if (wacom->wacom_wac.features.device_type & WACOM_DEVICETYPE_PAD) { > error = wacom_initialize_leds(wacom); > if (error) > - goto fail; > + goto fail_hw_stop; > > error = wacom_initialize_remotes(wacom); > if (error) > - goto fail; > + goto fail_hw_stop; > } > > if (!wireless) { > @@ -2496,6 +2496,7 @@ static int wacom_parse_and_register(struct wacom *wacom, bool wireless) > return 0; > > fail_quirks: > +fail_hw_stop: > hid_hw_stop(hdev); > fail: > wacom_release_resources(wacom); I'd get rid of 'fail_quirks' and use 'fail_hw_stop' everywhere, otherwise: Reviewed-by: Dmitry Torokhov Thanks. -- Dmitry