From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09353F410F for ; Thu, 28 May 2026 13:26:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779974796; cv=none; b=Jm0MGGIBfL8a66pZSc8taG2NDE1wHa3CU/ffwnjFJLrkNJEpTtAutLeVMGcQwLVxKyQJIZevIazrpINGC5ne53S3anHixrbrjGYATjAZraM8ur2IYeco/7bikrZJKuGHuiuTtJTpLuHelc6LhHowHy1lcNheiBDSoDUqiBfC6KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779974796; c=relaxed/simple; bh=03lGqlF+0BEi21i0yMRj08s+nfpxN0o2kGLw0gW00Qg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eXyzBAIedJCuGFAaM7b49LNlVIgzk1vncmE1mlK7A1NiRw2266zgnodjE1Wr26cO4wcJm1NsXXeTi2iuktuIcOPZcgYLvQThfeYNf4go1voaBPGxgh2ZYRHtesYiExF9I7+b/dglKDVjM8LVtbsKgZeyEGeY5iHfbzh95UDq5Nc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=cF/gRSvW; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="cF/gRSvW" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49050ff7cbdso52768935e9.2 for ; Thu, 28 May 2026 06:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779974790; x=1780579590; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=03lGqlF+0BEi21i0yMRj08s+nfpxN0o2kGLw0gW00Qg=; b=cF/gRSvWYOcnUuySM6zK2mqeZnGtBhlzDFBp0mZ6yw6xRWo33OtS38fGI9xHngN+e0 jdgKmjdeSe2c/rzjIEGggAw03TCaLAiVD9jBqVbRSLB5HEeRheF/VqaHi2vEgZVHZDE3 ydLyQ0du3WrMe+ePTSPXHRUr/zMIwyBz56mJDJ7t7mOW2UQ908qIfwninBo+NZ5aHFwT 6471RsMQc4uVxXA6Iw9x01aPUMTTxS4p7jYK7VUF2/ysdP1t+VgaFarCPlH2tR0vGZJ3 HPkJVs1zXv6fMK/AAEDM8++uTFwCajH1CpsEp3tM16hMhCYN8ipBwA3Tuq2nceB2NSH6 1yFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779974790; x=1780579590; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=03lGqlF+0BEi21i0yMRj08s+nfpxN0o2kGLw0gW00Qg=; b=PERMTzt26pnS67an4Ff3ZKXh16G/wRI/jEzTXx57gpOxGfcJMBYQb25duSuIdeoar1 dapZ92wWoJmtDBhXKc339qNpiOuB4xst+xoNHy61DuL3h+lIQE5LfriFRPXHUpMb/U+t kJBb1Fsq0q4Ql0TggiO/r1780TKD8BkkADTuqgMjVLX3CGfJ/ZbPNovTjMRXAEvUppuQ A28wCdlu/x+O03gaLFd6QydbPJDBZyhQBxvxC1VmjHZl1XlC+7kjoaeTDucCX6Q7bKCy NtyvaGuZo+kp/OsVpKQ/S4vra56lLPsEqAehRkDo+rT0/t8lL0bwj5dWBKpFhBbh3vv/ vz7g== X-Forwarded-Encrypted: i=1; AFNElJ84VWJg7sAfUgxRsImngC9kW0C37yPrTMfjNrn7NjWxIztQLRAHpoxYP1bKxQaoc0nM8hAhbCAtQjRoyyI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9nT2sLHdDAAKZ6jNg0OwHoGUwVfi3J7/DGxDJ1j2I+JJ1T65y XQDTXz2rsrLK0nILyok4rvbmzHV3KNBvEHV5dEh0jFhgbbif5vtJa+6WqP+cpctZINI= X-Gm-Gg: Acq92OHfF6ItsJGtXkg5XoEWOTjGklJuXsnykFW+KssLRDXrdQHwVYjNYPoK59QzcPC aKKiwkC6VVFJYZkHrdTxcno94s/4MlY7fZwW34mktB6NInP5rChUFFfd7t35jRzDf+PIDCBrqrT G3xgflmZH/1tv/hu3Vi0CIuyu1Omp0DFPDgD9liRAQHbS3369pqy0xy3u5vqiEpdyFUIBaqFIfs dgc1y3wPFbcHKmO4ci0BYOqll3YanJ55jwRNHpOysvVBCpDbtQF3opmwghonf6Q8drjHwlEPB9E 7XoSQLMBreKXM4xxMrqAzbFiadDBNmKoQj2U4GGgUQNHQEyOgUw53Csg4ebt/TMYw0+zrjH4x5s uTRH6pVqdJKMrlqgB8SUtVWjKMzDMLrq1mmKIorVxO+LKUlVdCYyMVxZyJ6FF2rfmKfOhU/RckC TqmhYKZEpz7OGPDz90iI5uCoGK5bMnR8INi/dof+UdhPCrMkDAUzqZH2lyliFHlgyy7OCQ3fblp 3WlNSu9unsVnW6zTgwTCqtfWw== X-Received: by 2002:a05:600c:8210:b0:490:4663:691b with SMTP id 5b1f17b1804b1-490466369f4mr444171865e9.7.1779974789615; Thu, 28 May 2026 06:26:29 -0700 (PDT) Received: from localhost (p200300f65f47db04e567da92d09b3dda.dip0.t-ipconnect.de. [2003:f6:5f47:db04:e567:da92:d09b:3dda]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49092a82ea2sm71703465e9.9.2026.05.28.06.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 06:26:28 -0700 (PDT) Date: Thu, 28 May 2026 15:26:27 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Marc Kleine-Budde Cc: Vincent Mailhol , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org Subject: Re: [PATCH v1] can: flexcan: Drop unused platform driver data Message-ID: References: <20260528094540.1867783-2-u.kleine-koenig@baylibre.com> <20260528-fluorescent-sage-ladybug-43261b-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jr5ezym2bbxklprz" Content-Disposition: inline In-Reply-To: <20260528-fluorescent-sage-ladybug-43261b-mkl@pengutronix.de> --jr5ezym2bbxklprz Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1] can: flexcan: Drop unused platform driver data MIME-Version: 1.0 Hello Marc, On Thu, May 28, 2026 at 01:00:15PM +0200, Marc Kleine-Budde wrote: > On 28.05.2026 11:45:39, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > No function in the flexcan driver ever accesses the .driver_data member > > of its .id_table array as device_get_match_data() returns NULL for > > non-of platform devices. So drop that unused assignment. > > > > While touching that array, drop the trailing comma after the terminator > > entry. >=20 > Does this mean that commit 5e6c3454b405 ("net: can: Use > device_get_match_data()") introduced a regression? Yes, I'd claim that this commit introduces a null pointer exception when mcf_flexcan0 (defined in arch/m68k/coldfire/device.c) probes. Best regards Uwe --jr5ezym2bbxklprz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoYQm0ACgkQj4D7WH0S /k6P5Af/RigOk1qBi0phQGZoqolZBtvjNCOPhXdtTXZsPHFrRSQHlnNNrCwumgF4 gXsU30alRevFmOywvJQjR20jiQdfyqOz/Lh4rLmTP3/I7kfhEHsQHe35v2Rartas 20cbq4rj8aeF1jFaHth7acd0i0vpLMDS228PzL2qlnNTam51AZWKBqj6GoOzGsmt 00cRVpIB3ZYd8S5sI5g1go5xSeDGFaUgtPMYzzZoBrhzAsqYb+ypG/qSNLvDgn5l 6D4LUQLaDD+Ds6gwzkFPPXfAEmxMQwnT07u6+PQCfPbuGmSNye7H4KEFgdStSD95 6tdn5MsdA99T+oswj7W1DmgD27Gbwg== =UgOY -----END PGP SIGNATURE----- --jr5ezym2bbxklprz--