From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D25403E9C for ; Thu, 28 May 2026 15:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779983945; cv=none; b=TiuJxQp55ODWOv6EqK0vMA4z14tw2j04o2jlrJ9JkbJUCsuH5R4X///HmDtWf5HOKKkdkrL7D/E5QGVNmESTocvEy1dB0zbBCltGhvVB0KSUp4c3aBHyeo3Zp0JMpRLyZKnRc8O4bIASjFYLR9dRLNbL0XtGf2Y7trttOPG5+0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779983945; c=relaxed/simple; bh=fWoBkr8lj+32RFfWU/KwpSka/T7BZwq910LOXLhAWVo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UCL9/ddJgLt2RvOFnBZ+mBbrnUIU7v6Flfbj8m1UuahzWHDLXWd7SZpJtu5RdJaKjsbeuiKmGGtA4aMe3a1T32L5iVqVWQc7KsGRLAfWr07378x6Qn8vSZvXhRC0M5b2Y5bpy61G65qex07viiYmXA0X21D6kaF389wa1MOHkmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=SHYIVqlr; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="SHYIVqlr" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64SBHRD53784371; Thu, 28 May 2026 15:58:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:reply-to:subject:to; s=pp1; bh=a4k+gKCjBXbCOO8QKaKb1 xNtzykww9Oe6hiHbJSCBMw=; b=SHYIVqlr/TzhBdv2x+mTE+BW79/iMhMTBJ828 9oQgrGZjY7SzApmQBkkfaaeuPryHWeMhNqe9nGistVB0Bvp+p6gnOwTizvCeKv4W ArSVqtaKORNnVosMT/QebHXyKL3rQOUDRqzl9z4yDssV0dMfHlWPB2gXqpwBbSgT A4gMqmiloj5FGU3o7NBCrikX267+wHaNC30PlV+Zr/xZ9Zfw38YIGpdBpOu4DoKV N2qMOfLvmm+3mXY2FlZmtZBjVhsFRXoWweKAsSY9N21kv3FwwY3ZPXd+S6QqXdFy Dds46yuY6+zISTv6Nry3SjscImQLkdwB7pgrUu4r0jPiO7Qbg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ee889bqat-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 May 2026 15:58:46 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64SFs7kd024905; Thu, 28 May 2026 15:58:45 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4edjrb8ugb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 May 2026 15:58:45 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64SFwgAu15597852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 May 2026 15:58:42 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 095B820043; Thu, 28 May 2026 15:58:42 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 83B5E20040; Thu, 28 May 2026 15:58:39 +0000 (GMT) Received: from linux.ibm.com (unknown [9.126.150.29]) by smtpav01.fra02v.mail.ibm.com (Postfix) with SMTP; Thu, 28 May 2026 15:58:39 +0000 (GMT) Date: Thu, 28 May 2026 21:28:38 +0530 From: Srikar Dronamraju To: Shrikanth Hegde Cc: "Chen, Yu C" , kprateek.nayak@amd.com, venkat88@linux.ibm.com, maddy@linux.ibm.com, riteshh@linux.ibm.com, chleroy@kernel.org, tim.c.chen@linux.intel.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sched@vger.kernel.org Subject: Re: [BUG] sched/cache: "Make LLC id continuous" causes NULL cpumask Message-ID: Reply-To: Srikar Dronamraju References: <51154de7-3700-4cb4-82f2-1b3a8fa427f7@linux.ibm.com> <058664ab-0982-4c13-9d4b-caa2f7616b0f@amd.com> <20260526140856.139657-1-yu.c.chen@intel.com> <912676bc-230e-410f-a5fe-153b0f304aee@intel.com> <42a19577-fe56-44b4-b0ed-37cde6d03ff5@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <42a19577-fe56-44b4-b0ed-37cde6d03ff5@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: nHgcM0YvoVWmIxEQ4qBm28JwHOkXuMh_ X-Proofpoint-GUID: nHgcM0YvoVWmIxEQ4qBm28JwHOkXuMh_ X-Authority-Analysis: v=2.4 cv=XqfK/1F9 c=1 sm=1 tr=0 ts=6a186636 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=8nJEP1OIZ-IA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=6UUPjkb784EC9J_kirwA:9 a=wPNLvfGTeEIA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDE1OCBTYWx0ZWRfX5e+bFHofKDaS 0Zaj0b4AU91Ayk3Z2RPS1UU/t9ZDdWMcqyoXQs0DDUdnvwTnYAxhy8O0VLW+cJU+KpoM+W5osel eDIyNI6a0qj2zx9CP71qFOQghmwd+vZrtg4qDi9brv6iR37koPNqOIOVfJBFP5NnSzuiPl7xPUt XF7K+aRcTZbcQrzFwq8CayXGdZG4jcJnFzuZs8H3uPGdfp3n9Q1MPBfuMK3i7+Z/1FTEv8T/SSr +GTmytGlgiP4clWt7OhLdvdvGyYMTgBWu7EtRvi1KD5oMoX3M7BkCaTRHshG6JVM2XJ92WFaYBL iI7BbsXQ9J+58lmCg8eyQ+KA2fRe8SHphuWGHbqoXFe2AtrdhWLFpl0l/C/Ws1+sYJjP19z0L+I otu66Q39sdMYK9WXPhXSYB7sKxYoV9CYunp7vkdA9imQ/hVd8yFfk7lHWx0N+Mo/9du02p4Nl63 830TRgN4PV02VWtsOWg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280158 * Shrikanth Hegde [2026-05-27 23:37:30]: > Hi Chen, Prateek. > > EXPORT_SYMBOL_GPL(cpu_die_mask); > > +const struct cpumask *arch_llc_mask(int cpu) > +{ > + if (has_coregroup_support()) > + return cpu_coregroup_mask(cpu); > + return cpu_smallcore_mask(cpu); > +} > + This is not correct. why should we again send coregroup for llc. > int cpu_die_id(int cpu) > { > if (has_coregroup_support()) > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index df2ceb54c970..3b5155121276 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -2063,7 +2063,11 @@ const struct cpumask *tl_mc_mask(struct > sched_domain_topology_level *tl, int cpu > return cpu_coregroup_mask(cpu); > } > -- Thanks and Regards Srikar Dronamraju