From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 141C7202C46 for ; Thu, 28 May 2026 16:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779984488; cv=none; b=uK2Dwceil78bo+MaHsnZzq2g8RJZYDqCxbIV/Ub3o05q/J5TNykN7JtabQaD5AIYQk3ybvR5ZZZO89o6qEM7nCGewRFOveiWrlTQcHvbpzpJrT+yIBSOgafLpFnBTeL6N4og1CbK6D+JXaXGZfWGovgDEc1JBftMR7Ze5C6mSo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779984488; c=relaxed/simple; bh=BQEMwhyrh8A5haXsBbov37wycYsrn1vSMAyk8OB4dPY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=d4lJfMuyBNs/lf3rCZ/8+8ncJoR92LI7AzxY/qCapP5hweq3skySsa/+r2N3KN1S4S/5TE6KydL3O4k1p9NT2TXhx9FQYJv2Oslaq/ookHdNPfHwoo3a3ul8gCIn6ldOprgYiUC8s1+w8OZnzD/w+QnpQAEIwKc16hgpRFjdmFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jSup77r1; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jSup77r1" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-837cc5bc6deso8708425b3a.3 for ; Thu, 28 May 2026 09:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779984485; x=1780589285; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=ek22Fd3FycfLolcYwfif8xkvFpAFlov1T6Xslq0mpiw=; b=jSup77r13GYL5o+H/Z5T7BAOwQZT7t9eOkTo+JNfKA062PI0/D+Jdb7hWhi+Ehspqc LcV/Njs16iOMLPTZIPIKHfpjvDMzntY6NnNHC7PM1dmGc0bIzwZbyvs1vl9tyPxc+hnS rKJ1bHvhzRLDEBpW9FPHylTHLqV5yNokGigyJSVl2SrU3WOaUN4ejfBvbxmI46QSkA8J 5fdfzt9+0lU11XQuQ4LyAAkWnlcj3s6+xalMsze2v1HGA8OwNAw72DYnvDZk2BWhZMm9 oVBNVr0ieBrBj0oNkmL+ML6YgBKMGErIVMP26IPxfbMLsPIPHULopbxQOf/IYV+VPPq9 m2Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779984485; x=1780589285; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ek22Fd3FycfLolcYwfif8xkvFpAFlov1T6Xslq0mpiw=; b=DG+l37ryVzq0W97NZX9p8mIsdnPKsZpbB6lHg/VT4/Ts1WYLmpzQ1N4rIyJxbPVeQZ aa6aM7B+ouZbnjwetYFAMwfTySB2wcAeYtEQzG3HFbwG+2ymUjtEetz4iSIDFJGTmvGK Nq8j6K5kZYvk4irP7Vfm9dfHnS+bjjBQZ5IiE7Dj/soj9t1PGjADZokH+C9yBk8xKWA2 jmF8STRYuTZVeGMYNbxUeziRULVHVr2MxOg+bt2fHCKkqq7qVtHxYby7Tsa8JKf0O9Dn cZwNCEbI4PLeZwL7dUAPYlhd/OhqQCFy09vrxgjG5ul2vpx9Nl7WiDI6KGF9eDWHSMDE 9Mvg== X-Forwarded-Encrypted: i=1; AFNElJ9K6SgOaF2am42xnro57LLNppcxS2WDapw66s9PYETr3RIdyK5jQ46OZeiHfVhbz5kcLp7e5Bi4gzevACA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4HDUpi7pWhLK1vpmmB44p1r+44/OegNAYQ1g0tA9mQ8Udlda2 Kb+JrVONxnueetPN1pTnVVQOQYyT1AVJ8+wPCncGKs6Dv3bGXLgYVWvEdC5/vMdPNYfcaT6Amtb rDGPiRQ== X-Received: from pfnp18.prod.google.com ([2002:aa7:8612:0:b0:835:4c30:5576]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:bd8c:b0:82f:b0:28f0 with SMTP id d2e1a72fcca58-8415f544527mr27982787b3a.34.1779984485130; Thu, 28 May 2026 09:08:05 -0700 (PDT) Date: Thu, 28 May 2026 09:08:02 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260527174347.2356165-1-jmattson@google.com> <20260527174347.2356165-2-jmattson@google.com> <20260528091357.GB343181@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH v4 1/5] KVM: x86: Consolidate CPUID fault handling for emulator and interception logic From: Sean Christopherson To: Jim Mattson Cc: Peter Zijlstra , pbonzini@redhat.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, shuah@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, ctpence@google.com, David.Kaplan@amd.com, binbin.wu@linux.intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2026, Jim Mattson wrote: > On Thu, May 28, 2026 at 2:14=E2=80=AFAM Peter Zijlstra wrote: > > > > On Wed, May 27, 2026 at 10:43:43AM -0700, Jim Mattson wrote: > > > > > [jim: Add EXPORT_STATIC_CALL_GPL(kvm_x86_get_cpl) so that KVM vendor > > > modules can call kvm_is_cpuid_allowed(). Fix typo in commit message.] > > > > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > > index 1578c0ecbbd1..72bd3cddb026 100644 > > > --- a/arch/x86/kvm/x86.c > > > +++ b/arch/x86/kvm/x86.c > > > @@ -151,6 +151,7 @@ struct kvm_x86_ops kvm_x86_ops __read_mostly; > > > #include > > > EXPORT_STATIC_CALL_GPL(kvm_x86_get_cs_db_l_bits); > > > EXPORT_STATIC_CALL_GPL(kvm_x86_cache_reg); > > > +EXPORT_STATIC_CALL_GPL(kvm_x86_get_cpl); > > > > Are you aware of the distinction between EXPORT_STATIC_CALL_GPL() and > > EXPORT_STATIC_CALL_TRAMP_GPL() ? >=20 > I am now. :) >=20 > > Specifically, the former allows modules to do static_call_update(), > > while the latter does not. Whenever possible use the TRAMP thing, this > > allows modules to *call* the static_call, but not to redirect it. >=20 > Sean - Can you fix this up when you apply it, or do you want a v5? Neither, as detailed in my other response, using EXPORT_STATIC_CALL_TRAMP_G= PL() requires switching kvm_x86_call() to static_call_mod(). We can do that, bu= t I want to do it separately.