From: Raag Jadav <raag.jadav@intel.com>
To: 占wei <zhanwei919@gmail.com>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Guenter Roeck" <linux@roeck-us.net>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] drm/xe/hwmon: report a single fan for DG2 instead of two
Date: Thu, 28 May 2026 18:49:36 +0200 [thread overview]
Message-ID: <ahhyIMa3Btj7oZv6@black.igk.intel.com> (raw)
In-Reply-To: <CA+qUFcnP-XEPHJD-+djRydD92-bAz5bxxVaRHGJ3nrpwtq4m7w@mail.gmail.com>
On Wed, May 27, 2026 at 11:18:52PM +0800, 占wei wrote:
> Thanks for the detailed explanation -- that make sense
>
> I can think of two paths forward:
>
> 1) Have fan_input_read() return -ENODATA if one channel has started
> reporting pulses but another remains silent for, say, 30 seconds.
> This way the phantom entry still appears in sysfs but userspace
> tools like `sensors` can handle the "no data" case gracefully
> instead of showing a misleading 0 RPM.
Sounds a bit over engineered solution with its own caveats because
a) We assume that both channels are monitored simultaneously and first
channel actually reports non-zero value for 30 seconds (or whatever
trivial value we device) continuously, which is not guaranteed.
b) This means the output of one channel depends on another and I'm
doubtful if maintainers would be okay with such hacks.
> 2) Drop the code change entirely and instead add a short note in
> Documentation/gpu/xe/xe_hwmon.rst explaining that on DG2 boards
> where the OEM routes multiple physical fans through a shared tach
> line, fan{2,3}_input may read 0, so future contributors don't end
> up re-attempting the same v1 patch I just sent.
This one makes more sense to me though.
Raag
next prev parent reply other threads:[~2026-05-28 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 11:53 [RFC PATCH] drm/xe/hwmon: report a single fan for DG2 instead of two Zhan Wei
2026-05-27 13:53 ` Raag Jadav
2026-05-27 15:18 ` 占wei
2026-05-28 16:49 ` Raag Jadav [this message]
2026-05-29 13:50 ` [PATCH v2] drm/xe/hwmon: document DG2 fan speed reporting quirk Zhan Wei
2026-05-29 14:05 ` 占wei
2026-05-29 16:12 ` Raag Jadav
2026-05-29 17:24 ` [PATCH v3] " Zhan Wei
2026-05-30 7:12 ` Raag Jadav
2026-06-02 16:17 ` [PATCH v4] " Zhan Wei
2026-06-17 10:54 ` Raag Jadav
2026-06-17 11:02 ` Vivi, Rodrigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahhyIMa3Btj7oZv6@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=zhanwei919@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox