From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4E11340286 for ; Thu, 28 May 2026 23:08:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780009685; cv=none; b=gmbgDbnwJr/5bLa4X7oYkfQTNT5G3hDpg4mJcczzTQOd4N5Rby2hihU/LVqxHAKcj0vWYp7m2Jo1TIw4qLkxFc92gRF16ZTSTzjyBGqzF+Lvy4ozhn+1uuVAf0/lBbQH7q0o4DiEScSwQ4f2PrFjSRHWGODEHRNdcR/nA8bsXNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780009685; c=relaxed/simple; bh=dk5J752CrboY0cT9L9q/A31Kn6PJ9TtEDu1SsAd9iqM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=d6fWjrCqcylv5CDQ8r9RtM+EUefgWcaDBO7xLNLT931fOiu6MOpjT4Za8UsdgnDaIRDIFjthWiPXN0uanV2LXXtxiZeLRNdEgdglyb/XFrA9vx28XhG3tJOBhBdCYFUAtyPRALwwDuIWn3OIVGyy5UKWk25rW+p6RiLoTj76Cc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Yg+O2jO6; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Yg+O2jO6" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2befe912949so17103485ad.3 for ; Thu, 28 May 2026 16:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780009682; x=1780614482; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=mKnLxmBLes80fBb6aidC9rNT/r9MEqoEBbXJR1P8ohc=; b=Yg+O2jO6R5B8J5tSGem1dGPb+qAxZq/PPOtRHZpGuHEsWEBEzlw98TnrcHaz+AQwof JHDQwLUXGFxLGBSnyNXtoKiDREqqu5PaTMaX46aaeJjJZhz5Sh+j+3SfKpQ4k+hwMMK3 bxJzJGeoasD3lroobqdqlygBppQQz2aGklEXGgyM0JDU1GuJvv/l9adDrx6c0A/+mWKz 73VoxltnpTPsjydzNp09U3cuDipoVFeGCf5PivX6lIdoVWdlFwozPhPcz/yg4dWBYdVc lL30uBvEqgrlpyFna0q5RkTJdm6aTEu6I2ya4jb22bmGHJy2YtQz9YJFgBChu78cJkBv AKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780009682; x=1780614482; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mKnLxmBLes80fBb6aidC9rNT/r9MEqoEBbXJR1P8ohc=; b=Yd+mdoETULMo1LZdkZIwQ+9ZY3gUHas/IXIqPBu9Xh3WadY5JP0QSQiQ/DU7RzrBYR nFWZltmW5o1qZbjJU8ImPdmnEirc0bUcHVVKzxa5zwiXB0mdnyyyZPmNon3cs2Bq4Q2u FqhgFH5PxrfLBUHf+OMsdnR4yd66UXUljGwPbVhC0R1dhxenE4Lqxg6oKzCql6K+BW5k TiSriAEiF+71wkwmAA+lNV2INyq96k6/3m4wMbLEqeM69vtZIMfsWUrUdiGIfvJ7FNa4 7XSl5P3PDeglTt5VMlK8VVIZWavePLLPCw9ag0qjcbpE6Qgr1TdeodxN//HArAw2KSej ZpSg== X-Forwarded-Encrypted: i=1; AFNElJ+tqOELfqkLckX8yo+xTl5eoCTIFRv2gqu3xrjQSCqarAOqQ1HqUBsXPSrChB9Br8xYKpAhxYiSyGFmD2g=@vger.kernel.org X-Gm-Message-State: AOJu0YxUsbOSe4oH5ER/xYXi62xhhSqhwdjmLjaKtleMdULlFhv1whOL sINq9jpS/xIA8xViOcdthqYYFRhf0+fazZJxejZLm1murP/+ctyaZaU+q2Z0Ju7v9qzf4xD87S4 fyRpeBg== X-Received: from pgum16.prod.google.com ([2002:a65:6a10:0:b0:c82:7761:9936]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:19d0:b0:2ba:7610:3f21 with SMTP id d9443c01a7336-2bf20533576mr4731225ad.5.1780009681978; Thu, 28 May 2026 16:08:01 -0700 (PDT) Date: Thu, 28 May 2026 16:08:01 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260421231557.1254270-1-jrhilke@google.com> <20260421231557.1254270-4-jrhilke@google.com> Message-ID: Subject: Re: [PATCH v3 03/16] KVM: selftests: Add guest read/write macros From: Sean Christopherson To: Josh Hilke Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, David Matlack , Alex Williamson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2026, Josh Hilke wrote: > On Tue, May 26, 2026 at 6:52=E2=80=AFPM Sean Christopherson wrote: > > > > On Tue, Apr 21, 2026, Josh Hilke wrote: > > > diff --git a/tools/testing/selftests/kvm/steal_time.c b/tools/testing= /selftests/kvm/steal_time.c > > > index 7be8adfe5dd3..23380de79817 100644 > > > --- a/tools/testing/selftests/kvm/steal_time.c > > > +++ b/tools/testing/selftests/kvm/steal_time.c > > > @@ -72,8 +72,7 @@ static void steal_time_init(struct kvm_vcpu *vcpu, = uint32_t i) > > > int ret; > > > > > > /* ST_GPA_BASE is identity mapped */ > > > - st_gva[i] =3D (void *)(ST_GPA_BASE + i * STEAL_TIME_SIZE); > > > - sync_global_to_guest(vcpu->vm, st_gva[i]); > > > + WRITE_AND_SYNC_TO_GUEST(vcpu->vm, st_gva[i], (void *)(ST_GPA_BA= SE + i * STEAL_TIME_SIZE)); > > > > Please wrap these. 80 chars is a soft limit (and so is 100 chars), but= the purpose > > of the rules *and* their exceptions is to make the code easier to read.= This is > > hard to parse, because there's so much going on in one line, whereas I = find this > > easier to tease apart: > > > > WRITE_AND_SYNC_TO_GUEST(vcpu->vm, st_gva[i], > > (void *)(ST_GPA_BASE + i * STEAL_TIME_S= IZE)); > > > > > > > > ret =3D _vcpu_set_msr(vcpu, MSR_KVM_STEAL_TIME, > > > (ulong)st_gva[i] | KVM_STEAL_RESERVED_MASK)= ; >=20 > Will do. FYI, upstream expectations are that review feedback will be addressed unles= s there is additional discussion that suggests otherwise. I.e. there's no need to = acknowledge everything. For me at least, ack responses do more harm than good because = they're pure noise 99.99999% of the time.