From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0224E340406 for ; Fri, 29 May 2026 07:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780040708; cv=none; b=CFEYYk3fFyQLEgYHsMK4HFqoJE3rDsu7s77d9LzCVtFED8bZ4ky01titkWKhS6xMv+p29rWfUggW3pf+ianHOohIckxHPQDESTJV3rUZH1ftX7vL/mMkZD+jQo7O8U4GmDR+bXiN1+u+Mq5nutb9cEI7sM834GHsIs+cvQ0RsZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780040708; c=relaxed/simple; bh=fFVco98qC1luivT5Vpu84rAh1or13Sl7L/M19Jcb2qc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tSPCw3htqY0qNrv5YjcRT6RLYIwgrZOiEZihrBtngwxoq4H3ee+vwz/0W6TaSLQ6RF+7ew7iNS4zhytnAkFDJl5vPwhkaWQRM3gcu5NZQGbPX0FHZ9zrwA/NQbnOqtCh/udbxZ+YtwE4hBo7vTVWTL4p4eed5eIvptNoCRQIgHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KWpD4aVl; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KWpD4aVl" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48d146705b4so143828355e9.3 for ; Fri, 29 May 2026 00:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780040703; x=1780645503; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vc+BiBXqNApFYq3fT6m0KjMLEQEnAecWg6fvOnqt1MY=; b=KWpD4aVlp+hI04FxfjPapF+KEl5axceh+C0I+aFKnFvl7yQqtKIrg49s1ltSPatntQ KTiuM5Ujo9eikGp/ZB0IyNktooAhHqE0KzTq/ZQG92FCscw8XsRlEjkXlkVGQflLeAKi 4Rq+SmIiFW1TqjHNsyjGX+JqSRB/r0L+pNa1T/sbkmJXXvnhxmx0M+LzyRokk+IPk6zc jbS9/N1PIjHC2hqRvCqjbUpVAikjd9x8JCqOSWaK6wK3NQ1+bR77kt/wAU2670/jaPKJ 4Yd1UBb/hwIrxmFoU141/AJw64K2soDRl+Xyo72Y2SvoWrp38uirzzjaC9zmXEEl8Jbw G45w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780040703; x=1780645503; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vc+BiBXqNApFYq3fT6m0KjMLEQEnAecWg6fvOnqt1MY=; b=Mo2AaHKLbk9Mmn8q16SyB170N7/teqcwtjLnxkJ8KN2VNQNaaiIdAHIRydvXYx9ufl jGKhXlFOPe5cflkqsg4uDYneb+ToSkcRRXr/LmgT8pqEFXy3BsCfLq7m3Sq6WqVcl5aX G5QcEwOiSyHRASTIemiuVsITAatG7EPwqnJS2KV083WLkshYQAriYMCliDC+0XztKh7H RpJAMLm4MKnn9bPepoAuFVVrGG60YB/y99/AcrQGQ8Vt3oD+coBHRMlneaUtJUTxfD3L F2G5R0QKIFtFdqaLwvDUscM9stuw9koox13XbuaTBiMoGPwXVHDID5tLIOnaTQqfeObo OszA== X-Forwarded-Encrypted: i=1; AFNElJ9FbOXMMx1fbmMhrg/JYLXGCNV07u8lsBPkdKoTGY558Ce3gYfa6kvlkFLA9CQ7mGk8lUGEz7QqU0PimWA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9+Muu9VggeLXSnHDYvK7IJn4NfIx2fWQkKWO1BN/aklriST8j ew97g68W3tjbu3bQ0M5/rlzjumBlaIxzv47QW5rEQJR7bJOhnXotTbOA X-Gm-Gg: Acq92OEaKhn1f4t+gUeSQRUdM1pHOza0fQ/3FHjqk3Vp++0LKtOiUMWHUNWEUzNGjsj IZ0qnamYPIIc7vTw9+KWxkJJvhtHJU5XQXIw8FkamuUvQGeA82N5IPm2gmagUzzPQ4Lb9xXTI7Q /EY3uSFNBRqB/nqYrAOixPkTf5JDoD2+9Ms8WPnx6vl9SxUFIKYaJN/w2WHAbhrW02NMHBgcIgO FhkdIqMnWIXtr5eBWTS8dN3vzdmArB6kxmukbFQ4Dfue8LTz7aHfSfQg9iWIMhluJ3oqpukmPur U8R8cg6qXiTIdfwOpmPkwL+S/Maul3CHTC8c9kYmU7nmR3aMVY/VILOZXKnmHHU0sxRUNqhnvpA 9uSgdYflGu4Y14MKwdtNIkSfSydepk4P3t68tY3Trd1RxAtSPK71JvDBgkjBernHKgZVjvVo8R7 1tLDr2hFkRHoBqu5DOr5IqnMlu0LIA4et6Eg== X-Received: by 2002:a05:600c:5288:b0:490:3890:605b with SMTP id 5b1f17b1804b1-4909d376fe3mr24438075e9.31.1780040702882; Fri, 29 May 2026 00:45:02 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d6975e2sm32452585e9.6.2026.05.29.00.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 00:45:02 -0700 (PDT) Date: Fri, 29 May 2026 10:44:59 +0300 From: Dan Carpenter To: Vitaliy Slivinskiy Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: clean up coding style in sdio_intf.c Message-ID: References: <20260528184415.63810-1-phant0m.mail2023@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260528184415.63810-1-phant0m.mail2023@gmail.com> On Thu, May 28, 2026 at 09:44:15PM +0300, Vitaliy Slivinskiy wrote: > Fix checkpatch.pl warnings: remove unnecessary braces for single statement blocks, fix spacing around conditional operators, and remove multiple blank lines. > Work against the staging-next tree. Split this up into multiple patches. Run your patch through checkpatch. > Signed-off-by: Vitaliy Slivinskiy > --- > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index d0feb28b7..17829b982 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -19,7 +19,7 @@ static const struct sdio_device_id sdio_ids[] = { > { SDIO_DEVICE(0x024c, 0x0626), }, > { SDIO_DEVICE(0x024c, 0x0627), }, > { SDIO_DEVICE(0x024c, 0xb723), }, > - { /* end: all zeroes */ }, > + { /* end: all zeroes */ }, This should just be: { } No comment because it's obvious. No comma on the end because nothing can be added after a sentinal. > }; > MODULE_DEVICE_TABLE(sdio, sdio_ids); regards, dan carpenter