From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC39936E48D for ; Fri, 29 May 2026 17:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780074070; cv=none; b=pw4ECh7lUaYRGgik5ogQwgDde7N4Y0tvpuSvHEYjE7DwGEu2PC2Pi5vKq9f8Ub6o/0Y68v/sy0VDPK3CDq+cj/C7Ca1H+PU7rZRahI4Za1hi40NrHcOkPC3hoKu6/HbZfRFkcNKdoEWEvooNXVmZqPUb0gpVipD6YKncypmULxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780074070; c=relaxed/simple; bh=P367Ii/qeQDHdhauhuZH7bZAH6//m8IhHlhI30hwpDk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d2zRNLNiiyGv1gxbocg88SDmDEvHq18+ue4BTl30+S3yRR8IPcaF/Hxt+lKR5jy8Hbaih/Fr5/b3mpqsM9gHnEu20OJMX5L0h4XClfG0V2E9N8TwL1/rIBenUpg1lRP0CJbsOMdKc91Ww3kllrJSLlXaDlTC/Oa3XkG1WFPpZnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=KJDE3Oow; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="KJDE3Oow" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7dd73b7c757so6592038a34.0 for ; Fri, 29 May 2026 10:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1780074067; x=1780678867; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=gbpxmbYT7Ke6jfRem13FLNzIhR0XDA5ecbYjVCBoFgQ=; b=KJDE3Oows6510LyqKgFbm8cR5XRwNMozVOcZ2X8ojQxR92stNryGg6LwehfZ/nJ6p1 u92pFjeYYLOxPSDmLntiJ8TBUhxgd9cHHeI8Y3355mlll6hADDIKt6Oh/Hk4dODRBBRJ gd/k1J6rynUhLp2v1mL0/YkWVx3qiCWZji/RDr7+kxgnNiQMA+N7mx5At5bZdPRfosaB lqL7RBkoVlwPPj2ZVZMKQMVbUFM4nHifCrIlPxnbCZkK9jFQW88nRTR471ig49AmwzPu BfUY8EUNFhhPB3pVguErzK2AU5KsuzACy9ZdNkF21u5w/9HCbwTlFqRkNiQs6JI12lXT /2Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780074067; x=1780678867; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gbpxmbYT7Ke6jfRem13FLNzIhR0XDA5ecbYjVCBoFgQ=; b=Eav/AvNqHmePGRgTpTnChD4+ClS/jqD2u0RtI70yvZr7xKvI/S3prEWDfbvIPgibK/ eZVwI7VKBgos316TzWgnaQlPLEYgccIl/MPaJt7n+GcDe3wUQexmw+NHe42hQmroPf58 Eh6mlJV7DxKnSIbUN223pT39t78KKJkNq8L+xV+A4wKabY36JF+hQ6enf1vuPeqFNuQ6 kNLOpprGnElProZ+uVqdnWTy1ZpZDFiFQKG0AsZ8BqLKDnensRFOm2FrUq8bI8W+fyll M9KN31TUbPLa8JjAVzZq/mXoa+d7GMBzTnDS5MneBV4TwoTIcgZdOfcZpsIy7LaPnU3P WBRQ== X-Forwarded-Encrypted: i=1; AFNElJ+urZ0jaQB/vHhzztfkhwwdgv5vOFsHKziG9GqYnxSFh2FGhoat2KgN4+nwL9NAe3BSO6NnnJ1HFZYZrEE=@vger.kernel.org X-Gm-Message-State: AOJu0YxFFb5qawyziI9JylZd2nbM7+Iz0LmfAy2FsLGVdz7bPSvv4sbT /9VimsBiyKadXGNUEqeAER5lfRd0OLDtLSyeETTqip9Y+VWFnvUk3u+fH2pgRgVpN8M= X-Gm-Gg: Acq92OFQtpoklxGusf4SewdcQiraRXIws7JxIToz/ct+CjhT9BZ92GmsPgLv9QFJoSr yYQqDYaxAFJQNt9J31iX5IOTc6kmRB4YP1BFosHCukZUtXRPtPIQSVQtiL5pw39B+HQ5BX85kUn kIVGdsNFeb83EuGlW+Os10Y4OOLGy5SP+RFi5deU+dBv+6XG0MYyxwHkGDT7gsdHWbsDFAbuC7h wKQklGbxRZgjSDBnwmIuSwBJSX3V1WircmpM6fVsJnWuoZ+NhHCLDV3UV81xUpUAl3VZDVpRsKx Edzjd8whETN4+KUypYDG0gHOTebeXDQ4jfHCFVzdkikm1ud2RUaPOaUxqQkHNIuLMfEYf3YODUw ia5zFFGPMYX12egzUz7nz6FcbDNHKl+7deuNjyEJfyR+gOj+UsE/nzuMsJLqiQzgQVKg5zSzSSY FSp4idMdsPxQnKSOBMZ/kReIND4fxrdmVjr1pzWN8GyHWDU0T5Tj8H8p47aazCtuko7tu4Uqmm9 RiC4usQHaMmCblVVBePx0VeAw== X-Received: by 2002:a05:6830:698e:b0:7dc:dd58:50c7 with SMTP id 46e09a7af769-7e6a1de8f9bmr444711a34.18.1780074067255; Fri, 29 May 2026 10:01:07 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:4686:1f25:6e63:122c]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e695d8d92bsm1797687a34.25.2026.05.29.10.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 10:01:06 -0700 (PDT) Date: Fri, 29 May 2026 12:01:03 -0500 From: Corey Minyard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data Message-ID: Reply-To: corey@minyard.net References: <5966a65daf432613a58af373af79c9c4421b3985.1780052427.git.u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5966a65daf432613a58af373af79c9c4421b3985.1780052427.git.u.kleine-koenig@baylibre.com> On Fri, May 29, 2026 at 01:03:39PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > The driver explicitly set the .driver_data member of struct > platform_device_id to zero without relying on that value. Drop this > unused assignments. > > While touching this array use a named initializer for assigning .name. Sure, this is fine, it's in my next tree. -corey > > Signed-off-by: Uwe Kleine-König (The Capable Hub) > --- > Hello, > > this patch is a preparation for changing struct platform_device_id > see e.g. > https://lore.kernel.org/all/cover.1779878004.git.u.kleine-koenig@baylibre.com/ > for the details about the quest. > > Best regards > Uwe > > drivers/char/ipmi/ipmi_ssif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index add043b812ea..07f1d2327bb7 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -2127,7 +2127,7 @@ static void ssif_platform_remove(struct platform_device *dev) > } > > static const struct platform_device_id ssif_plat_ids[] = { > - { "dmi-ipmi-ssif", 0 }, > + { .name = "dmi-ipmi-ssif" }, > { } > }; > MODULE_DEVICE_TABLE(platform, ssif_plat_ids); > > base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad > -- > 2.47.3 >