From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA2FF263C8F for ; Sun, 31 May 2026 04:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780201534; cv=none; b=UWaK9fskM6VP9H7xTsWtVyN3+YmB+7KJeKs1EP3Cbr1EZ5widBB67QJf63CR2x00ThgBKKaP96Cuotm1oy9OgdbIM6e7Pz3x/MdzkVtLzmsOva4iDiLaeN4gwf339cqmwbjFcmt0UdbLidvScrPM9RTyn78uOywFjlzahM8gaJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780201534; c=relaxed/simple; bh=FQrHc7/WACHtQhLJsx/v+kkrVB2a5rej4lOPYVo0LnI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PpZaW/di2Hpl7MLe1U7Egl9z630ipyLZkPwUbZnL8mhTicq+z+vMxoXmG+HIYey7UlXcxoYKsWyHSJ0VfBNo7lyGhTuThUR0AMopbZ6fl3xCIA0BYpuOslBwM8Na81NQc32PqPc3q21XElzUqjZNEVD6R4qlTkVZ4bVpGDtFVMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AgpkVZmG; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AgpkVZmG" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-306f36df4feso159023eec.0 for ; Sat, 30 May 2026 21:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780201533; x=1780806333; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mfXUlA4q1Rnkp6HcFZLfh12tpxz5WVB+RVOLL/F8nHA=; b=AgpkVZmG0pIHq6rR4hylRzv9wSql0c7w2XUcI7uIqPs7db9pPVq4LOCgpwjBsoQN6F occa+sUecVpfiNMSeFKGnpW07r91i42D61PQB7XPw59jblwydRd7sVoAVmT2YF2Lvrel Y9X5frVnxipWK6ryV21iAuS033WnCFk2Mw10nYXARUi1vAzz3wjOKFFl1v3WDjwq3tac O6Zbpg0erAP3K4AokMq6EaA8uBaA3VsLVUSkgVA9qtgWsQXywCD6N5q1sgSQKoNwdgoT ktd1P3LNfKC1cP4Oi5KF03fJjEyQ7Ld5qMERCvb8DgtiCJA31xuJtV0CDC4dNkrXjBPX pJkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780201533; x=1780806333; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mfXUlA4q1Rnkp6HcFZLfh12tpxz5WVB+RVOLL/F8nHA=; b=rDQH6xfCz42/LTSmGvD9z/JB+4gDiKBzdfYc+tYzVXzsNESoV7Y7J7H0Z85NCb4cFW yPMSjCb/SxAGmlIoriTioN/BJT3lkRs1l8cv+VfsZ+zERFz9voicHy17+s03aSkXsYi3 Rfr1avG3UKCYvbzaBrH5ll6Y9rYYKuQI8dkYhDLP3iBQ9FtOpFZCPJ2asVtm1RKF4JI7 ZsWtDtOtWk6OUvQIESFijXo6qLuLl4hP/yi7OUaxXz/FPxZ2s82LLdiIf1NJQdJaPy8p Gxjdste3CLPrYn8Vf6I7gDfT4gG/XUJtCyTKb1q0zp8b0Ywem3Qio+7fUCFmGRQKoYqT 2YHA== X-Forwarded-Encrypted: i=1; AFNElJ90LcV8qNidUXSfrHVGp/8y0rLnR535CUjoeJ58XkJ97OiPei70zfLQAwp+vRz4L3Q7l7bNQQiaDKEwi/k=@vger.kernel.org X-Gm-Message-State: AOJu0YyuAii/Vm1KfSLolbWy+CMc1hO4CaYWmGDpongEAk6uDrksaZJ9 vGhW6fQ0e/YxKNxojEL/9kN3pbBuvC8GgnHPOm8Rudl1MCkB0nvPksI8 X-Gm-Gg: Acq92OF1FohKQC0Df7+NUjStxpowUKbTHkA18maVMUfDDiuI4G9jNjtzkGjHsNHw5DZ kHrULfgcOyx+mU8TRaYlOC3o5kD40lO3aWf0TDoyBhd5pQQXXGREWQBUPPN013f+baXgy3SuXQf qy+6ec9AJWkTNsZYlnw2UrncrPEm/cVTxeV9NbPoaUMOslLS5VHzsKMd0ORPS/GXnH3INeiy6/H wDo8dvO7P5otv6kdf743VVcPIGFyv5/GofKa4ssmNusT8+TCcgfDqHavGnorvzGqGsKxfmgx9Om qCXdnXxd+ipmN3LNxK3esfkFuMXJl+OORKh+1D0vQg/+RA4MJK7BJFJ5fpu5rAQdNfJAJoRtj7j hL48nOYW/Rc5/LduMT6TpQlYCmd0XRSzOmEfUqtkGjc/NfPJLDJODhkOrSplZGPc+Tz1mI2tKnW c7hFaj4/+ZdBubDKHN+Ya/8sz5Wat62tMTbv6rF5lEP38bm6VPxUINAJczUx3oI6Csmyuu0BE0b g== X-Received: by 2002:a05:7300:6da2:b0:302:b44b:b64a with SMTP id 5a478bee46e88-304fb1a66fcmr2160397eec.1.1780201532584; Sat, 30 May 2026 21:25:32 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:aa7b:13a9:ea74:503]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304ed5b8fbbsm5483650eec.26.2026.05.30.21.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 21:25:31 -0700 (PDT) Date: Sat, 30 May 2026 21:25:28 -0700 From: Dmitry Torokhov To: Jinmo Yang Cc: Ping Cheng , Jason Gerecke , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] HID: wacom: use GFP_ATOMIC in wacom_wac_queue_flush() Message-ID: References: <20260530155930.128183-1-jinmo44.yang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260530155930.128183-1-jinmo44.yang@gmail.com> Hi Jinmo, On Sun, May 31, 2026 at 12:59:30AM +0900, Jinmo Yang wrote: > wacom_wac_queue_flush() is called via the .raw_event callback > (wacom_raw_event → wacom_wac_pen_serial_enforce → wacom_wac_queue_flush). > For USB HID devices, this callback is invoked from hid_irq_in(), which > is a URB completion handler running in atomic context. Using GFP_KERNEL > in this path can sleep, leading to a "scheduling while atomic" bug. > > Use GFP_ATOMIC instead. The existing code already handles allocation > failure by skipping the fifo entry and continuing. > > Suggested-by: Dmitry Torokhov If you want to give credit this should be "Reported-by: Sashiko-bot <...>". > Fixes: 5e013ad20689 ("HID: wacom: Remove static WACOM_PKGLEN_MAX limit") > Cc: stable@vger.kernel.org > Signed-off-by: Jinmo Yang > --- > drivers/hid/wacom_sys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c > index a32320b35..2e237bdd2 100644 > --- a/drivers/hid/wacom_sys.c > +++ b/drivers/hid/wacom_sys.c > @@ -74,7 +74,7 @@ static void wacom_wac_queue_flush(struct hid_device *hdev, > unsigned int count; > int err; > > - buf = kzalloc(size, GFP_KERNEL); > + buf = kzalloc(size, GFP_ATOMIC); > if (!buf) { > kfifo_skip(fifo); > continue; Reviewed-by: Dmitry Torokhov As a followup please consider changing 'buf' management to use cleanup facilities: u8 *buf __free(kfree) = kzalloc(size, GFP_ATOMIC); if (!buf) { kfifo_skiip(fifo); continue; } ... Thanks. -- Dmitry