From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 671B284039 for ; Sun, 31 May 2026 17:03:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780247030; cv=none; b=SWuOTk3mkSzRjMV1zzpcrcg3dOy1W9ujPoaWajlxwS1CfRR58YRTBP01LxJFxCcMgaO+U+ckfvEmzz8gKBaPPIrAggcFgmkuE/XXjlme5BBeawnVz92i5zlS3cmfWZshy8aDgFiui8G82EUMmXcpUB1mkgeCQ2UnuXScen6Y45o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780247030; c=relaxed/simple; bh=06YIPsvFCLfL0tR9DEMfp2l1wCcz5yUfmx7RaifG4Tw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bmO6bX643skYAuMtv9Coy8Yfv3YKU1RuzUKRr7ggzd/Yyo2dyljgG/wsZVBTkhzjOiwqRX14bGdYHFKV3Fy//IXLsXF6YY1ROQBEue2heQTAD1xV6PdjbyPvMyCyKilBabUBFqIcuGAldz8lseTX+0K7FrG69PJPLwKFcau5qt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CgTCxMcz; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CgTCxMcz" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2bf22c18ad3so45ad.0 for ; Sun, 31 May 2026 10:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780247028; x=1780851828; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ybo4RkpcoWejnDM44U+Cay0s876q1Wdz5Zz0sx9dqJA=; b=CgTCxMczThEa+K7s/ZFiWxhGi+NY6mNVwNka1VE7OE+Z7aWPkFIpr6UxxqqZXDc/V5 ipxdzEWMKNB6dAcDu7YG3WxHHTXpZWXI0CjXDkVWRWyTmLu8s9K8PIjBCn3EzQ14zhE5 YZSOSLJEvSt71VQEYHtLIoEDaVz/QkmbvZGhjnvc46sccvWaAEgi+SWD52tUBLE9zjn0 iTibry8bG6Ubc4nyU4u3MtSB2Gwf9U9s6KOOpekGz3lic7PWNzfquzHpiF/U7OYTWr7Y hVkS3MDw96pudwUJaJ+HH+gyWZnsOriLUKmse6q28NeDdmhyf8j1tIVWGaj4RYV8eO/b Ae0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780247028; x=1780851828; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ybo4RkpcoWejnDM44U+Cay0s876q1Wdz5Zz0sx9dqJA=; b=gUeDQ97a2Wl1mP9RTBvhmEkB/lkzki5qjJ4+kqMJV3PIUr3WRTDElkIP82C5XQpLb4 ZD145nOJDwfCKuYaosViPACo6W5mJ9o3B1QV546ii5FoOV0goY/iC9qIB3aa3+1QBBV4 k5LcFBUHnhq/e57nYPp+6ibTPWRBWT5MQRu+uWIrVwaGtE/AQ7diQnABjwBa34P06y2e TzGL8V7wvb2JP6GKR2G1/byhEwnp/8tX2BuHhEZzlKngtC5mR47DYx7zWUX+KUE4dwlb ampTK8n5hb+EHT9k3bmg/AQmGxZaTh8JmnMnQnV+ZzIyMV9Xxks0ghPFJmcbFUBvwVqr hWoQ== X-Forwarded-Encrypted: i=1; AFNElJ+nqDHgxxJcncy065MogD4PdVsr2yh8wkSFZSeokSaryvW5Nzk1f4lkNqX31s2uBpHgrmhCOrfxhkmfGHI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1kUMU181ekeOhHjFlixHl8HVj/PuFiNK8U9WiepKgdAX1qExl lQfwXHYFvNG61yuhN3NF6Ljo9+MomJFK583N7XTX69w8KkmolrCXAhhNfCB0zHBVQQ== X-Gm-Gg: Acq92OG5GUL+raCSOzC3kNnJKx5ECSYItjtaT4ZdfXb0xVmNBQZEfq4pQMh8A75OC6c OofBZAGxs0JmW+m8MdGUlFA789Ag+SH+e2rupyZwL1m2FcfsJkMt1OnYaUGjiKaKPaknRjXWnca 7QtvfJrOEZ1cnIHs/fmnDNX4eYnTGcR84xeq6dvw0PUc0cr7O4fAKpnpc697gy/p3l4w0qlwCfb Uf8D8Mym/zTVQDPpuuxErpv0Aroqe/HF5t1BSAbE4EikPa8eX/qRtFSqt9IzTCDLcxGZKwVpHtk suPuABG4jsZFsy1ahhXIL6g2l0kCoHXraZ+JIkqem8wAvtqKlyCj9tF6ShlKQMeM3+2b25pxF4J qUMu83gHmS2/aKA65kCWnRa5PpdlAY3+m00Vv3vs4xQQY5tLF0tIlemVruXPz0JaJAL2yn7yeB1 mkMWZ3PrJYFKpU+YIDUdkMmiExiqQ64ZFCjhK+4rqRhLCTSwIL/GSVH0j/tKCJTL9j3XeQicM= X-Received: by 2002:a17:902:e5cd:b0:2bd:7e8e:ad56 with SMTP id d9443c01a7336-2bf97500a66mr4156065ad.6.1780247027806; Sun, 31 May 2026 10:03:47 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23b018b6sm82818655ad.43.2026.05.31.10.03.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 10:03:47 -0700 (PDT) Date: Sun, 31 May 2026 17:03:40 +0000 From: Pranjal Shrivastava To: Baolu Lu Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, David Woodhouse , Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Samiullah Khawaja , sashiko-bot@kernel.org Subject: Re: [PATCH 2/2] iommu/vt-d: Fix Use-After-Free in probe error path Message-ID: References: <20260529113410.491538-1-praan@google.com> <20260529113410.491538-3-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, May 30, 2026 at 09:33:12PM +0800, Baolu Lu wrote: > On 5/29/2026 7:34 PM, Pranjal Shrivastava wrote: > > When intel_iommu_probe_device() fails after the info structure has > > been linked to the device via dev_iommu_priv_set(), the error path > > calls kfree(info) but does not clear the pointer in the device > > structure. > > > > This results in a Use-After-Free regression if the pointer is accessed > > by a subsequent IOMMU core call or a re-probe. > > > > Fix this by ensuring dev_iommu_priv_set(dev, NULL) is called before > > freeing the info structure in the error path. > > > > Fixes: 89436f4f5412 ("iommu/vt-d: Fix WARN_ON in iommu probe path") > > Fixes: eda1a94caf6b ("iommu: Mark dev_iommu_priv_set() with a lockdep") Ack. Sending a v2 with this. Thanks, Praan