From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF52D3AC0F5 for ; Wed, 3 Jun 2026 14:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497988; cv=none; b=fNW4oTY8WH3VUwDos2agphSEFiecqRv5vJ9jnjZiQBkrQFJonsN4oZPkqQe7RbjSL+6XnlYPSk8lwfQTyUpcUc4Fbl/0He9+5XCwFizhkfjiiqxwx5c/ApG/2hiFWrLR8OvMO3rLAhzsrd30hgDfYYwQhLPcwohI/LXhVzsnnvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497988; c=relaxed/simple; bh=tGBk5L1oFJO/P+xtNYGuto+/t9YS1RPiu3G+FYN7QOw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yyt3mJH/WrFy7rHuwXDHqbf1HcldqurgUcERVIOKngYVfkKcEBMRu2XAt0Au8Kll2c/P79mYhxeFATtBz0dYSAu64dEMvwZFp+a1QjMDyy3t1kxPY9hELNHvDK2cJYayLZfzPq0OFpZmY90QPsA0uQfhG2B8SRLnBEdD029FAlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SoWtrtJV; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SoWtrtJV" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2bf2d865383so74835ad.1 for ; Wed, 03 Jun 2026 07:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780497987; x=1781102787; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NqOHLB4Z8uMw84hLhaHogABPafTAVpzk9ZFgr9w7mCY=; b=SoWtrtJVqrXsTT+Cess/JBvK4M6QDeXs3UAodrfgBVWhYUHRp/0gR6QPJTIFS6wBfP 8Uaykh5/SmBpTNzNrIHWzrzMazkMoilYuWE2UXLqvmUUCb2+izBrUu654U530AFNYjQq Sbzf+7L/4fHR2aD5Gg18WMuQZGIR2OIbnnoA9nrqdOkjcy9k0Dn9kZlYzURJChUthsDu b67C1stUrFARIcrp081Lzn/bTbwZLyoJiDwnPlG7QFqEMCzTqDDWR2mLpbLDVvOUowk5 0aYkRqCyx73xwJNvWrXw9RPuAVsy4U5xfmRoTktgX18AxXrYBKyJxjuh48hYMnq19MpS nP1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780497987; x=1781102787; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NqOHLB4Z8uMw84hLhaHogABPafTAVpzk9ZFgr9w7mCY=; b=DBPkrQAFsN9+mb9PHPVQnQ5qXcohfSck9EdCpJRGlP4AwZBrjSzggFP3dfS8ir/iRh O7u+Lak6FKfBSczKOCulP1sa4YtLPBquIWn3ZkBYulp3H21qfZG1lC+DXh0gp0x9CAh7 Unl6QzlPKt05hG/43k0AP8gBVGCvxP/gEcaALYX9dtL6QnhP/y6YDHp3t//h6TIoe9Ls wyggb3R4WkX02LyxjntGbWUvicYvoEIUbQN+aE/yIQrx4U8IIiIhSFVeQumLNpeYXKDg pcmQ7/GqzbPYJ5LDopM7htVs5Ppa0uVaXY8xEy5bgcvoJKe9cjGVoC04ORX+x+XNopRi du7w== X-Forwarded-Encrypted: i=1; AFNElJ+mxBZo+WH9Yf9EHaoLGIARtP9fUetz3KmPyB0eLsbgEwnj0iq8xfMfSrZaVZZxUh9p+nd6e5o5Yr6DAC0=@vger.kernel.org X-Gm-Message-State: AOJu0YwmJDg286ASJcY2Y3d5Wnt+fYaejjapdJVfuwq+hSMwEIwCyJ/E xClByFDQQqUzedoq+BTWlsp5AN+cTj1Iv5YQad7QEyqiw1/qbZ3/7UO66NUes5Ar/A== X-Gm-Gg: Acq92OEJ2rNI0gHyHP/CTTbg4O47tUhgkNQsaOqua5GgVO0dHmH5YLp5SVH05slLRXQ 64uKcH2G1nFMIH5wViud4mI2qDkf9DurIXg2wSTmTa+efHAEL2p0c4GBOjw0CJzaCwVro5/1ErK Adu3HOBOzR/nw8RRxC5KxRsQisLCYJIWZYzfd0BZI79MFZZPCqi4LJZo6m4WY6g9l1DfWHQACCm zCDx0sL/SFM/lUx/ktWizNLMQOtnCbgv1obmp28aBb4P5TbIPRaRNo3Ulxjm1HFaWt4CH+b4tDO ZMVFs0cDIx41VJgW/1SnYXAfsLMyJu1zwIzqBUB32zZrAP6iKEJ77uJQBEXrVOXkgZ4ZapMfdBX 1LkwlS8+9fqcH40MY4jUfj8nhhwQlmsGUIIVa6NWs+IEc+4DADT62/M+fmNYpT7jFjKeGRJRr/V tcVuapwgIxOWPucwC8U9OI2blYYvhCSKBChRtPKg7g08E637AXsoCrqFIe515mPMQ6qo4OKyA= X-Received: by 2002:a17:902:c408:b0:2c1:5756:1230 with SMTP id d9443c01a7336-2c16bf60842mr2091185ad.0.1780497986471; Wed, 03 Jun 2026 07:46:26 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282880050sm3185925b3a.29.2026.06.03.07.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:46:25 -0700 (PDT) Date: Wed, 3 Jun 2026 14:46:20 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, joro@8bytes.org, baolu.lu@linux.intel.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 7/7] iommufd/selftest: Cover invalid read counts on vEVENTQ FD Message-ID: References: <7bcd153d306f2cf04c094c728c0ebe146855072a.1780343944.git.nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bcd153d306f2cf04c094c728c0ebe146855072a.1780343944.git.nicolinc@nvidia.com> On Mon, Jun 01, 2026 at 01:42:38PM -0700, Nicolin Chen wrote: > The vEVENTQ file descriptor must reject reads whose buffer cannot hold > even one event record. Add selftest coverage that exercises both the > empty-queue path (the upfront size check) and the non-empty path (the > in-loop check that fires only after an event is fetched). > > For iommufd_veventq_fops_read(): > - count == 0 and count < sizeof(header) on an empty vEVENTQ both > return -EINVAL. > - count == 0 and count == sizeof(header) on a non-empty vEVENTQ > (event has trailing payload) both return -EINVAL. > > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Nicolin Chen Reviewed-by: Pranjal Shrivastava Thanks, Praan