From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B853AA4FA for ; Wed, 3 Jun 2026 14:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495734; cv=none; b=hx+PkdmLegk7af24f70KWALo/0cgiGiAn075Ngjj9QflCWzW0pHKomIwSzE4eTfrcUYrWqTxZP4oMctV4phxzakpASUFV3YAZQgRy3jeYzQV55lIdDqAilYBPSneokyLQ3Am5ror9TeLE785WOM1mUh2N4xCnXKQsqw/tv87ENY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495734; c=relaxed/simple; bh=mpS386OIWn/1uIQD+RKTH9RuXoPv4nzB312kCyDGUao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eB/wMtsIvDmHYfhsDnGJgKCN5JKR4g2RQgeXr3hPnDvE9kxpUAkH8XMshZbtuJayPBvKKREvG5uVQZykNKMH/k/hCddiqureUxr1Rrb81GCsHb73RU+gFiTHSYEnZTqrBg10na3kKJlUpyPEkj/o5thq39c7wOjtsz+ifqdPJms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hVWVUH/R; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hVWVUH/R" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-51765531803so486931cf.0 for ; Wed, 03 Jun 2026 07:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780495732; x=1781100532; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vrZsZos3Mt/QxzkZ4e65PaNc9Xnu5WiDW2BXX/YqZXg=; b=hVWVUH/RKllFZFJmITfTRctd0FViCC4PACSb2i3UxM8zgIW76CsBS6NtmHGRJtVx+Z g4taImmuboCCmayGibcptpeslhVfCpDlnrY008XBHrXotAE4PvbGFc2hKvWQV9a1OvwQ gf6i/GIZ0D6DKDQcHgd4Qj+Jc7NPqU+ZTKPTr2O6puuCgobSmasJuEuU2XIANwkRNAAm jOiLs9pkzvACD+/F7auxiR3wzu/fKktH+S/mmzEAqofWIhfHGbj+VAGWl41lzB9QUam7 7A9o1evkaiYC/XtRGJH15j/NMw9SiWc935iQkF4VJ/f/7qczKjEQMwjVJrFmycoAMpFZ YYOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780495732; x=1781100532; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vrZsZos3Mt/QxzkZ4e65PaNc9Xnu5WiDW2BXX/YqZXg=; b=kNkawaAImowpTAg2+QMWArMuuaIIJIxfyN3kIYX7FGyvrlsfI9hM9+qn2aR4jKw9jH Roe4vMVHcT+ohgul92Oj5jT7C4KiqdqCJWqzTx6hR91hPOvlRHRZGzuIs8Q6eoc8Jaue hDw/wK4sVoOQKhbvSyFTXbuhwsPW1it43W3MruQovSxm4D1qi5OPhq7oTUQkUiBoFb3i hvMHPQqQVXnvZxistjnrOCNxMuo+XfUTNtiyuTkoYvK4qGs4cBm551RTuEGXHu5kYwtp tLIdZCvwA+Bzw6Sji0awyGO87GF/w1XJSmC+OOM4FUY7dHFAL9nFAUXZ1GQV8dvmljbe I1aQ== X-Forwarded-Encrypted: i=1; AFNElJ+pLXKpglZal3xY/oLH9A51WELyqgYKpqvE6lfoEH+fBhecnCfok2rx+0Hx8+nhwFFbvSXGDplU1CzYHBI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4T7TR3JxLjytnvBD+otKWPGgiaLOWvDSLvW4RG2poFzydZ/wU URp/NWXeXko45CU8jgSOwUltS4xRi3k5R6QTVTSnLC6OVDRflBKpbgOOxOFpoULPEA== X-Gm-Gg: Acq92OFv9SNFEH8rEtczaif21CcuFUauSP5gorbZx/AcazikRkQk/tax+XMFxPO1EZh Sy/2zjZ3aaqbOgLvQnKrgQzrKbza3NNWWNCSv7xRF3kVJlJInMxiIzjTXnna9Z9tMArHaKBtRqD vXHxeYa7zyDERHY9SQRkhuv/D6KSDsA8kjiCW4jmYkneeJqoy01b653NWFLs2NooEOkoXatq0g8 KFlsPdgH8BqENN9jmt1FCTwsmXqk5btXYMf8OYkTp4Zffb0eFSbs27KUPB4DwVq6MfLI4S5jpTj NAunIzyD1vD6jDcjW38SxpSP29IfJZ8e5h3WEDRIijfN1fH/VV789n1TXjqRKef518zOAgD0jdv d69tM8MYRa7NjpxOo3kQ/bTYN7H9SlhbvNhtlztI6tpeHjAHDOg2QLTaaiZGhWNAD865uRta43B Ie/MvoGIq2EIEgZ7P5MaswJGwC7i4QsPox0P26MXiiCHsRV6SAjTchspiTO6peVYl0+aQVjot7v aM5PnQskw== X-Received: by 2002:ac8:67ce:0:b0:510:f9b:fb5f with SMTP id d75a77b69052e-5177bad00a6mr6870781cf.16.1780495731395; Wed, 03 Jun 2026 07:08:51 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775c08234sm24412491cf.6.2026.06.03.07.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:08:50 -0700 (PDT) Date: Wed, 3 Jun 2026 14:08:44 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, joro@8bytes.org, baolu.lu@linux.intel.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 2/7] iommufd: Reject invalid read count in iommufd_veventq_fops_read() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 01, 2026 at 01:42:33PM -0700, Nicolin Chen wrote: > The read count must be large enough to hold a vEVENT header. For a normal > vEVENT, it must also hold the trailing data following the header. > > iommufd_veventq_fops_read() does not validate the count, but returns 0 as > if the read had succeeded while leaving the pending event in the queue. > > Return -EINVAL in both undersize cases. > > Fixes: e36ba5ab808e ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC") > Cc: stable@vger.kernel.org > Signed-off-by: Nicolin Chen Reviewed-by: Pranjal Shrivastava Thanks, Praan