From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D3243A9DA4 for ; Wed, 3 Jun 2026 14:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495895; cv=none; b=XZZ3c+qtkCm5kCs+rpQAsjFVOlqpQMSHQICiNT9XD5Xz4phUNyCvZY+e27Z2bH4nxdibpCOn07mA/cQZqrWB0V1SCyc3YxS6ofI74YisYV6MkmGP2h3b0+v/PyDZaY+FDV8SPIc45cTIj77yMI17LmXmDErXU7zJZ1FhtRrtTVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495895; c=relaxed/simple; bh=b/SIUriVsuGQ8+K9ks4Bx6z61f4Zp4N9nO9DkwNZvL8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bKRoXPphyN4r58R9SOAEMaoftZdxgk/4mWPKrn/e2E8fTwA3vaGEmKLDyVBmI34BIPAuKCaZK+tvPEcS9FLx4prG4jM2Kpi13dsrhvo9DZh8MEFyhbfWmeLn0zRxAxyQ0qVGz7G7Mow7Rw5E4TrbODpUATD8lZWp5jYUgDi4ut8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=Jj/gXNQz; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="Jj/gXNQz" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-915906a4becso71566585a.2 for ; Wed, 03 Jun 2026 07:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1780495893; x=1781100693; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3JBFLHHchSf6Ugt56GZlS5cZe18tTPuP1JId2xHEinc=; b=Jj/gXNQz9PzMyt/Qlt6Q2M3R245DJFs2mznVy5gaKaJpgI6Fzs3uffqHQTVciPDiON c+gXtmpnbP//2nGpOWRG1DMuK+KCG+q3QbHfdMsZZXdMbqT6KDziuumMr9bKwVcQLtYj nY5fZbjcBpBy4vQmg7riJpMdsd849LjZkUG+7LSsHGj50odIXBLfu3ZC2RQRsjK8NC21 BtVbmz/mfj5A9eQvlDuUmtmfAuejT773Z40C6Sxy8s9e+jVFgBdYMiciPrJ0BWapP8c2 1+n6edbMVArRWJMh1g1hFb824kkVkjvXDQfVU2j5TAucSqkOiDOgCkcYYZoSShEFAA9B OYoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780495893; x=1781100693; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3JBFLHHchSf6Ugt56GZlS5cZe18tTPuP1JId2xHEinc=; b=BC/EEMjrOKp2MEVL6SU9V9WCyJ75+N4RJCG/xE+LEjoRC7A8ToFTxmMX5P1+a/Y5/V wN02HFozpsOThRLgc0VvZJZD5Wz9WEIH6CMAas09Ld3xPjwvlNe1Gx5Ox4QtUrXc2Q/N FuTME2AqxZcd0NaxuAOifU1rTrDyL5zO9hGj8X56YSHi8Dmoic9zK/6N07GKJK9FOE6I STykN/l7q9/m44LHWMk54DrjJdoZ+lKECF8jr6pefAU6ESL0wTdyjxHj71/ulwqG+71I ColY/R6a/nCZvecr97m8DVhrsmd2aiI5tNq6gEbby/cnnA+U++zccAq0lNDTwmgA+5gj Vk/Q== X-Forwarded-Encrypted: i=1; AFNElJ8Tvh/31G4sh7BmTjh3UOVd3eXegtSfFa3gWje4thWoBLOdYK/ed+huPvJbKpS+WnsHikUt7gqca3Mfh6U=@vger.kernel.org X-Gm-Message-State: AOJu0YzSUE3zokE2b2blCZ5pSZtLjeS77hvh4WFpNrO32VEenMQxODW9 KJK7wSXIcHa2lWqUO9jSUnlHrIWWMGkFJu9HOgl5hBA8WSpFpHa4Bf6TRqCElw5V1s0= X-Gm-Gg: Acq92OEk80159i1DyKG5E80SvkRN+cA38zigH3jhVZiAbRyMsWOETCYoJs9PENZCufi bjG8W9g6iRK8cStAExwYtV5lKaF7gyHgYMDyVWLW+gxNWWZg1AugLSh91DfKm++H3DYnxA9RIFp 4UEH7C+ZgJU3jASUj6kH6MfhHzOui3AuCl8RYfqN7auESNVzkuI9lNt7DOhhA2X9dO5dYBCG8/p x0bpda3CcJUOggDe2v5sMlAr3D/wOuxXSTkgLeQ5SOg38f51sKGYwWljK6k9XO0HF/AYtVXgywx S67gU7eDkgDUeYf5poFwAhn1BF0SvqvpCUPKFyv98j7Q/YHRF2leRDAERskGZbzWzLm0/v22dCn fDOOPt/48Kb7sVIfZtncKvk9v6Sos3Xjlw2COMQpfCeX7qtpNBlrOe6sVx3hSMHcutJuAqRkUfe H+JlSVgYwdmEuHZ+JGj9s0dWrpYq/GLXSFQAcQtIZtNyX8I28VYJKOF80aZ2kR6w== X-Received: by 2002:a05:620a:4613:b0:915:4ca3:61bd with SMTP id af79cd13be357-9158a83f992mr602997485a.59.1780495893289; Wed, 03 Jun 2026 07:11:33 -0700 (PDT) Received: from plex ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a402ff9sm248774285a.45.2026.06.03.07.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:11:32 -0700 (PDT) Date: Wed, 3 Jun 2026 14:11:31 +0000 From: Pasha Tatashin To: Mike Rapoport Cc: Pasha Tatashin , linux-kselftest@vger.kernel.org, shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, dmatlack@google.com, kexec@lists.infradead.org, pratyush@kernel.org, skhawaja@google.com, graf@amazon.com Subject: Re: [PATCH v6 07/13] kho: add support for linked-block serialization Message-ID: References: <20260603032905.344462-1-pasha.tatashin@soleen.com> <20260603032905.344462-8-pasha.tatashin@soleen.com> <178046937151.468621.13398573538792303093.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 06-03 16:59, Mike Rapoport wrote: > On Wed, Jun 03, 2026 at 12:05:04PM +0000, Pasha Tatashin wrote: > > On 06-03 09:49, Mike Rapoport wrote: > > > On Wed, 03 Jun 2026 03:28:58 +0000, Pasha Tatashin wrote: > > > > diff --git a/include/linux/kho/abi/block.h b/include/linux/kho/abi/block.h > > > > new file mode 100644 > > > > index 000000000000..8641c20b379b > > > > --- /dev/null > > > > +++ b/include/linux/kho/abi/block.h > > > > @@ -0,0 +1,56 @@ > > > > [ ... skip 25 lines ... ] > > > > +#define _LINUX_KHO_ABI_BLOCK_H > > > > + > > > > +#include > > > > +#include > > > > + > > > > +#define KHO_BLOCK_ABI_COMPATIBLE "kho-block-v1" > > > > > > It's never used by block set and after looking at the following patches I > > > found that it's appended to LUO compatible string. > > > > > > While this works for LUO, I think it should be kho_block_set_restore() > > > responsibility to verify the compatibility. > > > > It should work for any component that relies on kho_block. My proposal > > is to use this method for other common KHO data structures (e.g., kho > > vmalloc, kho radix, future kho xarray). There is no need for them to > > carry the compatibility string in their metadata, as whoever uses them > > will include their compatibility string. > > So if, say, memfd_luo uses kho vmalloc, xarray and blocks it'll have five > compatibility strings glued together? That is correct, but it will be in only one place: the header of the client's KHO subtree. Since it is dynamically sized and 8-byte aligned, it should be safe to include in any struct. Pasha > > > For now, reviewers will have to make sure that if the ABI header content > > is changed, the compatibility string is updated. > > -- > Sincerely yours, > Mike.