From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43054386428 for ; Wed, 3 Jun 2026 14:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780496001; cv=none; b=W+qs8S2Xz6RXA9aodu0M3JsLHgtaRZAF2070EO/n5sZkXRq9XOITGQsILIcvGl8uVkcvweadDY8Y3JOmpsg+IRQf9t33KtFFiCgiL8eyxZYmaAPk5q1/l9V3P0+9cK/1n6toN/PxfROZheebWqfzy0H5vlsNKfG0eJDKwQFNrYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780496001; c=relaxed/simple; bh=CRJtyzPVwZ27iPdMdn+YffG3q+hwHsP+3emZ2ABQJ2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qCRDrLa/UHhjeTLbY5Z9ibpbhqHd7EgMrnqZiFaGe/4iOtvI1t8sRYu6E/tnGDPQRWuZNPtiLArtAXrhebHOGshGbyXDEncyHAJ1zucwNldKjjNiC0Pxs3NddhP7OqglQebgWMFII4SPebr3iBYhDM3X8LoyAO/ol6gSoQBOeEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=s9UBvQuY; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="s9UBvQuY" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bf22c18ad3so94655ad.0 for ; Wed, 03 Jun 2026 07:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780495999; x=1781100799; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gl2/sR4bOkCw/IHgANyX/OAo2qKH6Z+1HugGtGKRHMc=; b=s9UBvQuYGBcu/GYN6flzhLuPFQT/RZGWPbpxYIRaRgR7PXXN62nXrYbZlUNzDTJ1xD 0zQyf9gIsJBVL9wADHy+4U1dM2UOrg1vO1AjaNVE4EfGGHET2RoUGuonR93NsAJtLSOq FHwQzxOBYZ1QDIOK9drOC42CFKaek50TLMTHOzCoY2Ztb9SxcXMmABCK/Yalgi5RkYib GlOKncRbrMWwbqxjckanjfjjm3fpt4tOa3ltYyTNnl8r1fc+i5BgCENQPgPfFs/q2bag Hakv2fxui4EyDq4cIxIsT7vuk7AcTGCARTlwY22GHRZnTufBYGzKyZiWPkoX+Jy5afbM 3vUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780495999; x=1781100799; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gl2/sR4bOkCw/IHgANyX/OAo2qKH6Z+1HugGtGKRHMc=; b=TrnUVsRZqWK2RKwuZ2UUtFdr/nXFEN8yoDNJvv1hJxc5qs5JvvCrDXWy/zoulgk9VG uxIr320QepQqHJOhoYsI6xewMXJQA/VUTXOgLfTzLzH40E5zyUyMqQcvajPZ9uRtUUsD 913lTYOOvusGxOTK556MIRGu3ORv4fcPYHwOseiPYMym8odm0SJFpxrTvqR+Wl1Fourj Ciqn2q6lbnLkXRQyX86WJ0dTq+rTmT6LiEWnHZNIlV+OjKF1Wa9SQQBQMY1PR42X7ql0 cq3HOYM/VNbIoVVgUe6KARxcAHpdhFD653fOTloejW5pShgkcO5coqiHvwP9dBWUtwz8 vAZQ== X-Forwarded-Encrypted: i=1; AFNElJ9tvC31bOlWr4rx0Pi3Rr8OvyJt89Bk3TDRMHHLEaO9A9GGPGaPR9Tbq1ku238vutowBCxS2lbYllcW1qs=@vger.kernel.org X-Gm-Message-State: AOJu0YwXOwYYqflskD6i5ETpktKVG9Bj6cNOndt2miWJEWiEs2QkA2vH caiFU38o/s+4S7Y6x/a0+pjX+sF/jmUehi/3lOgJ5BTce4scBSlTAU0EgaoewTdjuA== X-Gm-Gg: Acq92OHEkLA5Uv++KA7m6xhe9/LGemfmzpnViWYiLddBtFPFYqBWiIdckyoB4iOU8YV AhjLSKrMZTRsXifaalOjs9+uBP7rBpwo92o41o2P8uRWTDHu29DYAC0VqNCw8dO6/ltHQVDmWya xBLTaTGJlWpT1uyIiBXGfn7j5QvqcuzX71Uc9WtsHh+fh13Rsak7amY5ENTlw2v+S775MBe0cy6 3M8W+L8QAvf6CKQbqBQZv9nHX5Rib9tYS6uN6E9zERl/DdcfBQ1VOZ6g+SL7PVaIG+5mN3Beo8L UaWFCedCl2GJ6+5Jdg5bXYbPytzBKXgvQmXr15Akwj6pq+Q19vbvmhHgAtQL1wKiOCXqMu5IfcH Ip7KDnCwhZ7UnR5ppMw7HpnasjgSVQBJozzA3h83I3If/cnYb0K9jCaxTSb4xMV8r4vi+VzJkV/ f2cuXFfORZuivc+uckTvZc5/XdWBBbV8tGfJZVOZ7xDnrKDCpSB16VcDbPbQE0geRd7T9ZIHSVU Sqg93E8jw== X-Received: by 2002:a17:902:ecc3:b0:2c0:c14c:bf37 with SMTP id d9443c01a7336-2c16c13a022mr1861355ad.16.1780495998924; Wed, 03 Jun 2026 07:13:18 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828d6bc5sm3061356b3a.43.2026.06.03.07.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:13:18 -0700 (PDT) Date: Wed, 3 Jun 2026 14:13:13 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, joro@8bytes.org, baolu.lu@linux.intel.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 3/7] iommufd: Propagate allocation failure in iommufd_veventq_deliver_fetch() Message-ID: References: <25d29feac909e36f78c145fa99ef2d4cb7a415da.1780343944.git.nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25d29feac909e36f78c145fa99ef2d4cb7a415da.1780343944.git.nicolinc@nvidia.com> On Mon, Jun 01, 2026 at 01:42:34PM -0700, Nicolin Chen wrote: > When the kzalloc_obj() fails in iommufd_veventq_deliver_fetch(), it returns > NULL, falsely advertising to userspace that the queue is empty. > > Propagate the -ENOMEM properly to the caller. > > Fixes: e36ba5ab808e ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC") > Cc: stable@vger.kernel.org > Signed-off-by: Nicolin Chen Reviewed-by: Pranjal Shrivastava Thanks, Praan