From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2B1F481248 for ; Wed, 3 Jun 2026 14:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495280; cv=none; b=gU17P/+35x9Iu+JPwvXMCamq9Zg7f5sSfcQbmAR1WON8+QV9d6LEeAhU5ysuOn+heTXWCp671qTjFXLBb6wEDuXIlb7FSOuzwESmq+qKOGe1IPot7b5UjzImqp2vq18V/MSSSFJU/EfR1GGOJc35j1TUga4Hl2sRIoJdA4/4bDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495280; c=relaxed/simple; bh=0SPmCaZS/EgZ0V0kI9JhDAG319HQSuZSW2ZRzTouxwI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HW/wYVX0r8U/4lbpQ4ZdLX7xzh8NYVFWv+/u5f6t3KcgwOLR8DNDQJb509hwhZenKFhmwCRj+EYQ8I+YytkO8QYGI4ixU6hJuEM0wenVq01tDcFN8h/TxZs+ts7xY6fbY7nX8iIVK7tO/QLC6wOtBLT5L0bwOI1ZwDHuc1ARjLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GBLJB/7X; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GBLJB/7X" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2bf2d865383so69285ad.1 for ; Wed, 03 Jun 2026 07:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780495272; x=1781100072; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aIQgZlVSwyLoihF2al8NLtNtB2ubHrdRhrWZHSeU/cs=; b=GBLJB/7XlwR9BLIHsivcKyZMlhJdsPXmBSfcjQdeDlm4LlJ8sHr+kE7JpSn+IKGJdd x6fJzD/MKgBn5RRVOXONhhE3rBewiDLbsxAZbgjaVb7qg6CSfFeaTeqgPnV9TzMo5+sH SEQTH9vVShDGmDgNZa7hc7j4C+ZH8678Nkcxs38VR+i0ULpHY3lGW23cm7WgCEaBcE8y sNg+b/xaygbPmKsNFqVlk9e9VkZMXUNskWUajObyafVo6qHEl+Aw/NxbJjN54HSS4cA6 YgPaUCfzM3+5AH+TCF2bcqsXfsx4iEIROAxvb0sjggmKNNvGQTiYQlhAzKvXybI6iktm ta7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780495272; x=1781100072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aIQgZlVSwyLoihF2al8NLtNtB2ubHrdRhrWZHSeU/cs=; b=gdHPYfsj53UX+eb1fZ8xpUP6BC/sY5XzzK0hH84vvlVILlplBqSNk9TQOQDx9+0mkA mDAPJ4J0obaadLjEC5kIhUCaNO/c22sk0venDmQO3CrQ+BWUbas3HJ95fX3w6WE69aD5 scyGzuHtBdVsRRsyQQLazZIdGXscs8Zk1ZHhN09+JmSVZ7MbMfIB6hkvTxP6xGtyhI70 yCSmPDdtUkK5s/Z1REvU9cxypPqcAeOCMnP4swojQUVQXcdBlKHKTqJooO9NFH0Z5znY zeCsyvggbnGNxa07oyk28nb6lR7SG5ghMP7L1j50TyOLfig+mnTiT3Im4wq9rwq8SluJ RbiQ== X-Forwarded-Encrypted: i=1; AFNElJ8d0sthqh6xa3sCLm5gdpm/ERMsG1O9mnT/wT1KAe3d2vFUDbH2+s1c8aHrrlbUstds4Iyrw5vWJs2R/vo=@vger.kernel.org X-Gm-Message-State: AOJu0YzVYQNCotytcVj7Id5XIl9isLQtAoC4UHiokTiDe5btz91P9Jy+ T4m0STw3j/kQDX981cDshGegmMrsPfMhM2tbdJBTd+iGI/LgLrad2gW5BxYIO0Oycg== X-Gm-Gg: Acq92OG9s2UJWFtMu60+aAAwLPKteF2wuxw5cQNu5IcxyTlJ2IdDipPeo4fcfosCu8s Vz8HLofAhX5pbyGeSrjocz9I/zP2mbKxsBtEOxx6dwfZ8d0wNC0kEPEegeJGUyqDgrKcQ9LWMLf 49+vXAneDV04dB1+jVz65CbzVV+moVk2FOey860Y1brtxsYhpe5HjdujjViy2Zu4R/mgolw02Uk Lw3ng0l0Rk2jMczPUBUz2HOZ8PNZLQbNsPxMtox5yVAHY9FQnbp1NLQXs/ZMtnXYAfyJdgED79V IYwlGiJJWEPqkVkaLOklBGVq1pooM7APaJGYXfa+7eZT+sLkfob4YsXSbLNWPq8HNWbhs8i+fV2 UzXKPSJN/C+DcjkJqw4JNwC+6ENjyVzglr+m3hb4hJKXl/5PGN/pedIU2bPuKbA5PxvNkl9UzM0 mJ1H8Pf8rXtoHXiET0EzqKUip23xY54FFWO7ZnKrTyPPYFPX6ZntuNwF9VQn3nFushru+JtLTDx /M0/GxeQg== X-Received: by 2002:a17:902:ea03:b0:2b7:b03d:9dce with SMTP id d9443c01a7336-2c16c13fc72mr1885615ad.18.1780495271752; Wed, 03 Jun 2026 07:01:11 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36dd9877d85sm6188825a91.14.2026.06.03.07.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:01:10 -0700 (PDT) Date: Wed, 3 Jun 2026 14:01:04 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, joro@8bytes.org, baolu.lu@linux.intel.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/7] iommufd: Rewind header length in done if iommufd_veventq_fops_read() fails Message-ID: References: <78f8caeb6a5d667a26b870e3068cec47dd4b5be1.1780343944.git.nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78f8caeb6a5d667a26b870e3068cec47dd4b5be1.1780343944.git.nicolinc@nvidia.com> On Mon, Jun 01, 2026 at 01:42:32PM -0700, Nicolin Chen wrote: > When the first event copy fails, rc = -EFAULT will not be reported as done > is set to the length of the copied header. > > Rewind it to report rc correctly. > > Fixes: e36ba5ab808e ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC") > Cc: stable@vger.kernel.org > Signed-off-by: Nicolin Chen > --- > drivers/iommu/iommufd/eventq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/iommufd/eventq.c b/drivers/iommu/iommufd/eventq.c > index 1f1e415285b1a..896f45be0d2ee 100644 > --- a/drivers/iommu/iommufd/eventq.c > +++ b/drivers/iommu/iommufd/eventq.c > @@ -336,6 +336,7 @@ static ssize_t iommufd_veventq_fops_read(struct file *filep, char __user *buf, > if (cur->data_len && > copy_to_user(buf + done, cur->event_data, cur->data_len)) { > iommufd_veventq_deliver_restore(veventq, cur); > + done -= sizeof(*hdr); > rc = -EFAULT; > break; > } Reviewed-by: Pranjal Shrivastava Thanks, Praan