From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62FFC383C7B for ; Wed, 3 Jun 2026 14:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498560; cv=none; b=ErKnrfF7aLXhGPZoal4nELdG/eiX3KqoLd+1RglQXvVfkMOewm0YnIi+d2mr6gB8KsceChNSP/aKpFhGhb1Gb2SIfLvn2olqsLDdPk2zVb6+SnFvrXp1nonJ9oNgRMWo9on/A5VdIp2ut8866b2asClbSMJSRBOeKCVg30WQ/Zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498560; c=relaxed/simple; bh=ltM7pnum/igCM5uUZt64GOi7slHu/TZArC1BZKPoiLc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FQMVouVl7d152uJldhHxu9Bxj/hew2eUw4Rjz4y8YCjgj2Xm8IHpKvs1M9TyFrRIGTjPOmODqq5DL5DPsJ7FhiIGI7YoJeDwEk6gueli689Muc1SLwoDJa41dPQMTYsJUUgGTldwMQBAgzspSwzJxbgNQQP4YioxZ/hOJcz5LOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=FdAkUI95; arc=none smtp.client-ip=209.85.217.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="FdAkUI95" Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-6efdb6755f0so382595137.2 for ; Wed, 03 Jun 2026 07:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1780498557; x=1781103357; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tHFJL4Vv9YiBmui2bXAlE3Jf5dI3wvXhQmEI6tHCSqU=; b=FdAkUI95DhhH7vBg+7hAnFK59oMoY7ru62U6nlTahspdxgzrOG61TXdYKhn/XfbX0F vvDJFOyCODn5AhArOl+/2BmyoDjuDwCgo3oh27Tlgi0CmeqG0VL0kzJGvtfEbEpjdzJL xcNqCd3jIOBxVeyaCqqgEkLGc76Q34c8jJm+5zOXVfiLEmGFoxyuHMDNsh1L1zlk83pL IkmB7HPUyZPWz6X8uB8PM0YCRtXjLxWa3/EWAOQcsjhvCaO6LPfzXLPXBnLWy3EELoAl 7LxiAS9AY5oXc/JPyOuKtB0wKShATbmVS9+5v5uLhRWnf01mDx2uaXUaMHbq1LQt/QtV XAnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780498557; x=1781103357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tHFJL4Vv9YiBmui2bXAlE3Jf5dI3wvXhQmEI6tHCSqU=; b=llEvamcd2Igg7mtrZdd9PFLfh3bWyosoXwAIP0ujGnoH34HlwjbbJ+qmkAovJ13sfT XL+Vpy4IjBHJ8ronEAiIVA6RcYedDcUtGTEvrqZhqqG4IyHPFQtl+GGgQEXhjYocs5wp a2t8rxWotb8SlFf7ujmdHt5/2u0xKqL1VzIylmCuX2nVUJ4gK6/baGIA4XMjXGfYFzQB 3WhY+MRixTZUWZpvtEG/udnlWUFsoRPTv7oSK5eyHGFgBmKglgqV3tAo+Rk4ZiheBY9U K8EoXd4hmnYYBeANA3tWqvJ0cHSA3oNsBtJb4go1vZa0u9FHWcJP2655/6DSk8c8Gu9s RuDA== X-Forwarded-Encrypted: i=1; AFNElJ+jgEuRW3uJfjugYAzMAczcDPFjGUQSTMP4Q8xZDkD+u8bw+SaTxckxwi86jE3s5+o5AnlyjM54QZtjrss=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+swUexzLabmT080ftXMvGRLzkt/7VZQ6/xydCl4TCHiViC9VA ZS0FhqyKAG0WLXoY00tzzLpXfFsPM9Al489ICAeVvf+uc6F37oHqidVx1wyh6XHH508= X-Gm-Gg: Acq92OEsotHksEJsxalFDzcFnmnQFIIbheU09owpynrHGLD+YZxML9b7FmB9MhP5Bgx tHiKa5W7LGHQnsJGrqfeALysNN7L28DF209PJL/edL0r+x/2Q0piFYau/noJ1hDdx2pCC0kMNUS 1PtinZwiJaOdI2buBsuZmHUGBC1YmQ9hUOlVyaiZEf4STlMHJsOqofs+c+RFPghPCDMwSkrWdGe 4wgfnI0u0IbRabr5/9eYYuwrWmzqMrbwFRvErJZRQT6qVsnD2HuFsYD8ZsWJrJWuL8mKbaHvkEL JVnMrrQbycKU1HDpWd6Xlb946nxBeJDV9dJ8ryyWw3UWgQerJ++eBWUNxNUplUMDWhrehKdFNIE wwUVoBmEcCapFJLFLRRMAX72V5SOd9mhrfNdJbNtHj4j2L7L7y4Zx8g3MWOtM269E4pQsIcXBtY md6kPF+BYNLa75aR2XuGrUpV27u0SFTG6l X-Received: by 2002:a05:6102:c06:b0:650:967f:fb32 with SMTP id ada2fe7eead31-6ec2978d496mr2278212137.3.1780498557198; Wed, 03 Jun 2026 07:55:57 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cecd06b231sm22007136d6.33.2026.06.03.07.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:55:56 -0700 (PDT) Date: Wed, 3 Jun 2026 10:55:55 -0400 From: Johannes Weiner To: Jianyue Wu Cc: Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Qi Zheng , Shakeel Butt , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Jonathan Corbet , Shuah Khan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v4 1/3] mm/swap: colocate page-cluster sysctl with swap readahead Message-ID: References: <20260603-ch-swap-series-plus-folio-lru-cleanup-v4-0-ce0219e100d9@gmail.com> <20260603-ch-swap-series-plus-folio-lru-cleanup-v4-1-ce0219e100d9@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603-ch-swap-series-plus-folio-lru-cleanup-v4-1-ce0219e100d9@gmail.com> On Wed, Jun 03, 2026 at 09:05:32PM +0800, Jianyue Wu wrote: > page_cluster and the vm.page-cluster sysctl are only used by swap-in > readahead in swap_state.c. Move them out of swap.c together with > swap_readahead_setup(), and make page_cluster static to that file. > > Rename swap_setup() while moving it as well. The helper is internal to > MM and now only sets up swap readahead defaults and its sysctl hook, so > the more specific name matches its reduced scope. > > swap_setup() previously lived in mm/swap.c, which is built > unconditionally, so the vm.page-cluster sysctl was registered also on > CONFIG_SWAP=n kernels. swap_readahead_setup() is now a no-op stub when > CONFIG_SWAP is disabled, so vm.page-cluster is no longer registered > there. The knob only tunes swap-in readahead and had no effect without > swap. > > Suggested-by: Baoquan He > Suggested-by: Barry Song > Signed-off-by: Jianyue Wu Suggested-by: Johannes Weiner Acked-by: Johannes Weiner