From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 024A4384CFA for ; Wed, 3 Jun 2026 15:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498981; cv=none; b=SJXINseI5mlqbpK0yzO3cl1xuF1BO833V2jL8AvtAIPnO/MCWlquhXvl7yhelD18Ddlc0nNiXm9gmrFePsUnJ1CetKff+Rudwme+nFHjUFqlR938rx8rh30KgXiH+PJ2WC6l9UolRHdai8OhZKk+3IsNxzO2VfgmT0OuumpkZU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498981; c=relaxed/simple; bh=XG+CvLIBHBJhO7NLv8sm32bs+Jpub6gDJ/+wcdkBYn0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iJvTFIpzsyU0WeYP4UmKBLUsDHc0ulglOaMwKUDaFbFAihDcVU3kSfnj34SA/xPRUCmfHQIJ6OvzIWJhMa7vqBiJ91PsuSDBXN3F9v9rDycsuB74UxjqlB5UW+taFIgY34mGo/A628WyB1FTjKke+FEMNErIlZp0pS+qVcD0YFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=iy1YU3tE; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="iy1YU3tE" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-915906a4becso78795785a.2 for ; Wed, 03 Jun 2026 08:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1780498978; x=1781103778; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5bxxSivwwydDh0iCuOp81j5cRKW09cu5s4VCNvENaBQ=; b=iy1YU3tEkpNfB7cuGH4bAjayy1a8+h7GiBHvI9f+so6lhoTb+tX5uubNMetPGSMW7x Vsfkcx1Z3866GsxklyM+vabHVhRXkQJslAsOFa44xFC6mn7Cwda1cq1eiLrOEO8qBkCO i7fv0udQjaYl3Ns2uywTnXgJHb4F4Lx5nOpRjGFB+YG+XXzmvq6ZJFCA4QlQ2xILpznJ P7kVca2K7TI2TqHg8V1jO5UDZvEk1Buu4HMqflivqBDXJtlALdHFFYTEYoqFa81Md2ug 53AyRnYT+JiOD44g5om/jwzJ1UYw/P2w542o3JD9qGqZH55uzF4104jJOzm89UvJwXgA vCjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780498978; x=1781103778; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5bxxSivwwydDh0iCuOp81j5cRKW09cu5s4VCNvENaBQ=; b=ljomWp7M86viURAS9STDq4WdPlEmdPzBNrSqX8oWp693O7mhADBk7sFhVztVILiO5X RD7uBIxLet0LO+1HbmzKCOhKIAUMeozBnSP2uqz7dYa7Zlr/BS7I4FnTUuW7paOEc2C1 O5zxWPOejgrE+rvuVD1c0bZRDSKKHBShB2RsEg8b64Vpr1yOz1ydts8y/ehDjtFq4PuD jFGqHgtnWx1UzOUhoCZWFoxv2SAV4tmDj/qafAB8BBqRZ32qTwhyMwnoSHo+OJy2CVzm TQmhwcm7hsxLXS5+UWTkhj3FTOCERmYVm/4EuAT/DNsDDn5rCSMVxKy6SGjJ+iDWdLeK vnUw== X-Forwarded-Encrypted: i=1; AFNElJ/Q9mFZzUttHXYqPfcrB4PsPHKW4pqd6plD0CoSr506D67EprfUOTz8CE5MZFx5Owd/EUEUkoEjVd34Tqo=@vger.kernel.org X-Gm-Message-State: AOJu0YwSae0M1YKc/g9obsO5IsD1DlFsJ6LfA7JvOfcIFYpjM4DhvgjA r7IgcMfxETTbAMqZDjbgpCvRkKfZ/wtWvDz+0FkUi7swGDc3bKEutd9H4V0OFF4TdYI= X-Gm-Gg: Acq92OHMnFQY10SVTLKxxmlz0l8Jxfore/XlArRUnoV8N7tf3vgRqcU/Hv3HC1dgxNH bxyga6MR1ef0Wobvnr6/Z5vqSuk29ohFJhDyRljtB+0GV27LGpUyKCQOepHHnxuEk4cyJEgN3P5 G4jnqXoE79+dOJPpccxwtm5S8HutblEjdlTsNVYYCwokSo38WbTqcY5q/MhM53J6+L7TZH3usEH dRqyL6rmZJ2VAW+dzTBizmkRJd8YgCF+cRjm6vTMXh0mmRDMuJWdve742Z914m461DUO07/GuJb 4mpMXoi92zMDh2+b2brSoO/MW05a5tf9VcTmE/i67r+HV49qypQrcjEdyk6f6RafLyEkbgf7pIT 69JmEKYDL5RAqsT04S3FVq/yyYZVSX/a6dQzHpIV71tZxXLPqulMFK6BUWypZfL9lL840oEeLtK cJed1vQ1vtXqmJjQUMJu/guG+9YqkeT9Dw X-Received: by 2002:a05:620a:7081:b0:914:7b4f:cf5b with SMTP id af79cd13be357-9158a6a84bdmr640924285a.16.1780498977286; Wed, 03 Jun 2026 08:02:57 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a21d2c1sm280915485a.11.2026.06.03.08.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 08:02:56 -0700 (PDT) Date: Wed, 3 Jun 2026 11:02:55 -0400 From: Johannes Weiner To: Usama Arif Cc: Andrew Morton , jannh@google.com, liam@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org, pfalcato@suse.de, vbabka@kernel.org, chrisl@kernel.org, kasong@tencent.com, baoquan.he@linux.dev, youngjun.park@lge.com, riel@surriel.com, shakeel.butt@linux.dev, kas@kernel.org, kernel-team@meta.com Subject: Re: [PATCH] mm/mincore: handle non-swap entries before !CONFIG_SWAP guard Message-ID: References: <20260602172247.279421-1-usama.arif@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260602172247.279421-1-usama.arif@linux.dev> On Tue, Jun 02, 2026 at 10:22:47AM -0700, Usama Arif wrote: > mincore_swap() also fields migration/hwpoison entries (and shmem > swapin-error entries), which can exist on !CONFIG_SWAP builds when > CONFIG_MIGRATION or CONFIG_MEMORY_FAILURE is enabled. The > !IS_ENABLED(CONFIG_SWAP) guard ran before the non-swap-entry early > return, so mincore_pte_range() can spuriously WARN and report these > pages nonresident on !CONFIG_SWAP kernels. > > Move the guard below the non-swap-entry check so only true swap > entries trip the WARN, and migration/hwpoison entries take the > existing "uptodate / non-shmem" path. > > Fixes: 1f2052755c15 ("mm/mincore: use a helper for checking the swap cache") > Signed-off-by: Usama Arif Acked-by: Johannes Weiner