From: Ingo Molnar <mingo@kernel.org>
To: Maciej Wieczor-Retman <m.wieczorretman@pm.me>
Cc: mingo@redhat.com, dave.hansen@linux.intel.com, bp@alien8.de,
hpa@zytor.com, darwi@linutronix.de, tglx@kernel.org,
sohil.mehta@intel.com, andrew.cooper3@citrix.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
john.ogness@linutronix.de, ludloff@gmail.com,
maciej.wieczor-retman@intel.com, x86-cpuid@lists.linux.dev
Subject: Re: [PATCH v2 2/2] x86/cpuid: Update bitfields to x86-cpuid-db v3.1
Date: Thu, 4 Jun 2026 09:41:24 +0200 [thread overview]
Message-ID: <aiEsJPkuEaRPcwdN@gmail.com> (raw)
In-Reply-To: <9653d8690ec7093c8190b12d1fa8c689c4da50fe.1780506200.git.m.wieczorretman@pm.me>
* Maciej Wieczor-Retman <m.wieczorretman@pm.me> wrote:
> From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>
> Update leaf_types.h to version 3.1, as generated by x86-cpuid-db.
>
> Summary of the v3.1 changes:
>
> * Fix a few typos that were found during the kernel CPUID data model
> review. Also include fixes found using an LLM agent review.
>
> * Rename thrd_director_nclasses to hw_feedback_nclasses as it's the
> name used in Intel SDM.
The following detail from the first submission got lost:
> @@ -246,7 +246,7 @@ struct leaf_0x6_0 {
> - thrd_director_nclasses : 8, // Number of classes, Intel thread director
> + hw_feedback_nclasses : 8, // Number of Intel Thread Director classes
>
> Note, for CPUID(0x6) thrd_director_nclasses, it was written this way
> because the project does not support bitfields names with more letters.
What does this mean exactly, is there a string length limit on the
field name in 'struct leaf_0x6_0'? What is the limit?
Thanks,
Ingo
next prev parent reply other threads:[~2026-06-04 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 17:10 [PATCH v2 0/2] x86/cpuid: kcpuid: v3.1 x86-cpuid-db update with fixes Maciej Wieczor-Retman
2026-06-03 17:10 ` [PATCH v2 1/2] tools/x86/kcpuid: Update bitfields to x86-cpuid-db v3.1 Maciej Wieczor-Retman
2026-06-03 17:10 ` [PATCH v2 2/2] x86/cpuid: " Maciej Wieczor-Retman
2026-06-04 7:41 ` Ingo Molnar [this message]
2026-06-08 6:34 ` Ahmed S. Darwish
2026-06-08 9:22 ` Maciej Wieczor-Retman
2026-06-08 9:55 ` Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiEsJPkuEaRPcwdN@gmail.com \
--to=mingo@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ludloff@gmail.com \
--cc=m.wieczorretman@pm.me \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=x86-cpuid@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox