From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AAED1F1534 for ; Thu, 4 Jun 2026 14:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583667; cv=none; b=hSaJtC90HkoiyiZ77/dK6YkucabFAX4x0R9OExpPoNXyXT2oeyLg6/EvXBgiW62C1kAk7i7QdFCGE7Gyq0PstbTp1BK6E6HnAH6krBF76qE9j5EZ9UhcB9p+9JirPihrE5ny9pJOjxHCm15wH1OW/GdfNAhk4vJ77SfaSoC22Xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583667; c=relaxed/simple; bh=6jsWZCOnsYZ3y5j/SQTMH4+CqTOv5WaAhGSttD+Y6JQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J/rIV48UxdImskUgZbKQYTpxK/1B43vDn6kNGt6GrWixIVbL93WOLDXLImvNo21AAOt3yuSs6VQAO0rBhajn8wQOMFDokArYSOkMKl+Pp8lf8eIw4vftx5qvYFBS5fotm+FXaj3bXZAjUDfogV3CuuZYWC6u3uy6BweO8kQkt34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AXLeewM5; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AXLeewM5" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490acbb0f89so5415235e9.0 for ; Thu, 04 Jun 2026 07:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780583665; x=1781188465; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1PM8lbSBCSgKEK4loSfWef1l1aeyW9df7wbWffr6AZM=; b=AXLeewM5u13asz8g0nQkJ/Kk6823CpiFo8pE01cCJFFkcBpkSEJFD+zoFHduScNn69 TMntjkKjUBqgOAj3X9ho1LGcS+KQyW0Xwr6jylUTFXj+ctET+2NeauTbdxWTOVN6dJve vmgv1WwXDnHCXSR5BMAMkjeNJt/9gge+LSIsJ7C/13ZkNP7EMQ0xcTnsDvkzP0wEp+1Y W6Uxj6fFuTBLGqehOsUusWUD6cdH51MHiGh+1NbTaAgjpi3iGGVRFw96Jj05b90DpDBD hqrVZ798WZNAoxyWJERcnn3zWU8MqS4bXTa7MAO43mfm6fTGuM1Q/C7F9wJFTg7blUIm Nxfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780583665; x=1781188465; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1PM8lbSBCSgKEK4loSfWef1l1aeyW9df7wbWffr6AZM=; b=YmJjLDnb8YmeF+aIAVncs2zOVxCuZZtu8Hpb1G4sJbEF8s2/hRZ86eBjFQNf5U2Rvs MjrOLF9p+SYKTHDsyDd8/2MJiz1+hUvXX61heYwORTRyHNKg/7qVJvgI/t8/gHQYY5HC 82kEIwjWZEdrQW0shnENaKcGAS3EvJl1RrRUjrlaIfG7awNCqaSIklg9wXT4mqyRQIsK KJuAF+t+YUy9cs7ARHBq1+DcDnUbjzsNlpxFy5xr1uVziYrEwA86n1xHGg+AuhD47OHV Kppph1j6YAnQ0nCN9yEC9KuwTQxqh5EOnqu2F3BbK0fXVALMvY+1kYNiYG1vWSGPwtcE 1Eog== X-Forwarded-Encrypted: i=1; AFNElJ8/0ok3kuv0DFw2wGnaN0jTk+t4eqW/rZdDe9uZ356EguTCYlUkgVZmGYX6m41bpXQ2WeTQd20mXQyZh6U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8qemUWFBnRRDBed1Ddfx4RfCu3efEBttBhZkFTNx+L4gxAvy1 prRjtw4E4WSz0WJuOuNpQVUsRyk1EQMXLEZs+h4MhS2YPhwNKBlXmiRJeVyvrqSC X-Gm-Gg: Acq92OECuL6d73E2HcYvAXlVaRBOIDthmnXI6p1hpLLipA0kS+y9n4ufzDuk7Fak7L4 +M+9sWku2OZ+tLFR++K7e5IZUvF6kLZo6rT1LThXOx4Uvcaj7dySKlIQWKiu1wCUAhhViqonmuK 1COX/eGGTeTX6KLYy8fk5xoG56CGzGW+mQhMnKrMbyB6njgw9X1/DbvyJIV1JMNtLiiBI7C2Jh3 Q/0XaF3fCtHjzNUrUNU3Id++WIFViPwSJ7yAo/nhZnPysnphZVvR6X1j5eJOM50943NoCIXqJ9g UcM9HfElZfK6130mvp4XnrejIpxeVS23MV4glkL6xa4ncYh7ZqzBM5En3+Kwl5LT+X3UDzgx57U Gekx+NGcCvemBnMRr1q5HCZaNR1zYPMS+zlypHweAiH0PrwtAgi/ehc6i+po05ZxOR1aDEtrlA/ eE13kp8e0emuoLKA+Avg2EvghVUeKLD2u2ycM6LIzP X-Received: by 2002:a05:600c:35ce:b0:490:b9c3:6c49 with SMTP id 5b1f17b1804b1-490b9c36d9dmr136062915e9.29.1780583664878; Thu, 04 Jun 2026 07:34:24 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4602cda3651sm3876814f8f.32.2026.06.04.07.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 07:34:24 -0700 (PDT) Date: Thu, 4 Jun 2026 17:34:21 +0300 From: Dan Carpenter To: Jad Keskes Cc: linux-staging@lists.linux.dev, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants Message-ID: References: <20260603143127.343103-1-inasj268@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 04, 2026 at 05:31:56PM +0300, Dan Carpenter wrote: > On Wed, Jun 03, 2026 at 03:31:27PM +0100, Jad Keskes wrote: > > Remove the magic numbers in rtl8723b_InitBeaconParameters() as requested > > by the outstanding TODO comment. Replace 0x6404 and 0x660F with named > > constants defined in rtl8723b_hal.h alongside the existing beacon timing > > constants. > > > > Signed-off-by: Jad Keskes > > Just having the same define but as a goto doesn't add any information > or value. Ugh... Sorry, I meant to say "just having the same value but as a define doesn't add any information." regards, dan carpenter