From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E79B32E888C for ; Thu, 4 Jun 2026 14:32:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583523; cv=none; b=ii3x+fDNXkXUdyWSsIJej4wfe5EPZyMtt2kPpJkh8cULaAihC7NLu+jgDYFVXVHxr9yle3R2B22V++cKYTDZ+ux8Op9twp+k+kDair0OTsgFxtK4CdJ6E4vjnWC3HK5qakdo9T0T6IsDMwibelKhUEwdKpof0sHA6a3Bzoci1dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780583523; c=relaxed/simple; bh=uzlrQCtnldSvuoWyKhh9/yf9r6GReJCJj7X5/87LRkU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SEhgc+2QYeFR7ZXb26++tNdr5ExGuc4xoNK0JMXcpb1Uie+F2shFLZynwOpTU4H0a2mUbsCIOAFJNzhNDbE1TR6MaX06Ep0b7+qORjgfYjmnWWplE0rbBOdeJ+mOsAj6RS61GnbsOzh771YpILrxYtyfx+VIpw9a469gouHpWIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rHX5upWy; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rHX5upWy" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490aaeabdb4so5194915e9.1 for ; Thu, 04 Jun 2026 07:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780583520; x=1781188320; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6+05Ym76/NdzLd3/eZUvTemls6uArOmjCWU+hee9x5E=; b=rHX5upWy7/J/45Y5MtzmB2NLegILgO/ZRRVJ1HB6eGkmOhDqeMWDAn6js7kHgdMyIS jKxR//8l8Ip8Ma8jTRI4pLqG+yRRHxUs3DvLfwzetPIcYA6BcTjqOCYe/+mTjWQd68pi VnOqXx7wqaX2Y1vsqgqQ4emSF3ez2ZDQjGfu8XKT2r1975Kg4BfdtcT+LZsvdqltRA/x DXIkyOWnNyPPi7bL3P4eyPZ0Dn/EYjER1iiCRPVurAdb+QI7Eb/I4SjcJaoOOM7TnYiU YYBYeT5Ur3QANajJg9UX+7XbuDn/dHAQCOxXZk5mC5oKgF6RKPKGXN7Mjxym17/Sh1fw 4Hvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780583520; x=1781188320; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6+05Ym76/NdzLd3/eZUvTemls6uArOmjCWU+hee9x5E=; b=dC1+aLpvXNKq/yqGKUOB02G5/lH/QUTDUoOR9OWYR0NnCFFZtO9twvLdcKDPxzsoEE ZCuqn7CPiSShaoVnFpqH3HlWyqJR0cTKSJAlpk6XG09h8QfBocnGa86oCWFjZ/JUp56D 6E+MBarTFYuq0TAVpt+W4DsA4vQU0JOZnZzfeAKiS1+pd7cKWC/od5QIEFMTh9LYca5d jr7fOGrscF/K61xYcJgC4cIuz5OUP6p66bvSCOcT4mwL2r/55nuLML2I9h7FI6MDVYXL zTz9zkO3TEpRGuSTlk8cC23WFQfJZn9AVEL3nqRpmE0KBsvXApI0iknpM05E/pGx3nVY 6Z8A== X-Forwarded-Encrypted: i=1; AFNElJ/Sd778/VRAQvD55kzd8xN87IcvjMKKp8nWawXNhV/cDJpkNz63m1ERc/TkSVCeOMEDP7jatwB1hSQUL/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyBft2UiFHnkEYvkYBsFB/UOK/xFcLa689w4n3Yl47Tn6aSaafS WnEo7IKYC5+s3koj+EMOt30Owfnp6t9xU5Plfpsp13W3l7p3fVyn5l1kDjlF2mkG X-Gm-Gg: Acq92OGkSrPuBt6PoGT0tZjWmWsbUulQQV/dqUIG+Jf+FGk5ocrcGC7PGUXCrwyECJf PlKxAe4ptfDWpfmcBePukMf/crSWx33/GncuYpAVFob9ZCSgqKRotbs7WVruEAg4rwfULb908Gl P48qeMobtuCJ9KaamNhlbycC5YPiMP4skJpXs9yphJc3wJPS/XWUXtz0oON67oTMvztOiyAJB8S FNQ1XI0Zd1PZmNJboG+1qpDHQKtiAWlJt9ImtBFjeeo0R+6oiaX+unp7B2PPB1m2siH06I0n8MP 71tyS69SuptwwtKZafo3MSdJnXtrkFScpI83a18d3rq17KxblM7Za5PLDFeSrRFxMfrC69iC5Eb a460B5VIFV69oZZoxjShF6qK+AB+pjeVm6gLXUOCxZDG6c6+/6ohFKtSEo6xI4lB3g+QB7F5SlN w+V3FfqpXPrXkKi/IWT+K8gML7na0Rng== X-Received: by 2002:a05:600c:4fc8:b0:490:5057:f5f7 with SMTP id 5b1f17b1804b1-490b5e8cd0cmr128141695e9.11.1780583520254; Thu, 04 Jun 2026 07:32:00 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc39eb04sm78015075e9.6.2026.06.04.07.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 07:31:59 -0700 (PDT) Date: Thu, 4 Jun 2026 17:31:56 +0300 From: Dan Carpenter To: Jad Keskes Cc: linux-staging@lists.linux.dev, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants Message-ID: References: <20260603143127.343103-1-inasj268@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603143127.343103-1-inasj268@gmail.com> On Wed, Jun 03, 2026 at 03:31:27PM +0100, Jad Keskes wrote: > Remove the magic numbers in rtl8723b_InitBeaconParameters() as requested > by the outstanding TODO comment. Replace 0x6404 and 0x660F with named > constants defined in rtl8723b_hal.h alongside the existing beacon timing > constants. > > Signed-off-by: Jad Keskes Just having the same define but as a goto doesn't add any information or value. This is actually the third attempt to do this. The first two were AI patches. On the first time, I asked how the author came up with the definition and the had the AI generate a halucinated fake spec. On the second patch, the AI found the first fake spec and assumed it was correct. :P Your patch at least doesn't try to pass off any wrong information so that's good. I was able to find this explanation from an out of tree driver. https://gitlab.elettra.eu/intel_socfpga/linux-socfpga/-/blob/socfpga-5.15.60-lts/drivers/net/wireless/realtek/rtw88/rtw8822b.c?ref_type=heads #define WLAN_TBTT_PROHIBIT 0x04 /* unit : 32us */ #define WLAN_TBTT_HOLD_TIME 0x064 /* unit : 32us */ But it's weird that the comment here says ms. I don't know what is correct. That driver doesn't have any explanation for the 0x660f value. regards, dan carpenter