From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 412422FF164 for ; Thu, 4 Jun 2026 14:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780585185; cv=none; b=FpCx6mHsYH4PLZd6TI57MbiRZJCjE9JOtW05yyBbq/Gb6W5f3a6u/MbIb9OLsMmNLPlXw1iv8Cr0vA5DmqZMkHb/ZT6cNaNZHNtki6qZQvsYJ9ujtZoGfp604mQXN/bv2sAsqqa6xdaiGmptNPG0LVS2emqYlmNwh+YFeNboN+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780585185; c=relaxed/simple; bh=Vxm5yb3Pf20zhBvQMAc2bdR79XUgJshRWfmMwbk9Pn4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ug+4EP7ujqOvn0xPDx1ctHMXUAkwXO8WAqtvjWYz0np9vMP6Je6MgUskh/zpp0/FEtG3UarF5VHwK3ZJJrPVSsKErzk3eWhF2OkJSLHXzZ6LtbUdt5Bup54Wbmb+dCpNi6zIHHHzupD7pbBzeUmkUxHwNK94azgUgzJ01RUbjc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mOTGQ04g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mOTGQ04g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1125F1F00893; Thu, 4 Jun 2026 14:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780585181; bh=XOqQyI3gZmKvelsdA1mwzglKHOSKd9JIfd039oOU6sA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mOTGQ04gfuV1tU91ShWH7puQNjDv5Y2mgiZZHX7RpupDx3xftNmdy8PXdS/7foNSe ye6JT5PnUoFW9CEFsrBfhKacEQ1I6iKHUaAWliWQIBPWjYQvZjZtejSWNHf3+Me4YT y6jr605lyPbCuJOMwrSj13hW0ZgKz0KX9ywPG+woChgEB99MMlVDgj6ucfm9RFcX9g rUlq85OIqjt6OOhTotQqIOi3At3YGRchWMf3IQtErsHS5954UTDpty6dia83by4UsM tmiHPw/P3hmS1C5eUiw0Jxgap7JCXOlEz9GjFtpjo1iPyIq5CNGI4FEoRO5gzuUuB0 Z7Zp99Gorhr7Q== Date: Thu, 4 Jun 2026 17:59:33 +0300 From: Mike Rapoport To: Vivian Wang Cc: Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/2] riscv: mm: Avoid spurious fault after hotplugging vmemmap Message-ID: References: <20260604-mark-after-vmemmap-populate-v2-0-ab6a7d03b434@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604-mark-after-vmemmap-populate-v2-0-ab6a7d03b434@iscas.ac.cn> On Thu, Jun 04, 2026 at 07:11:53PM +0800, Vivian Wang wrote: > Patch 1 adds a hook and should be no functional change on its own, > whereas patch 2 is the actual fix, which depends on my earlier kfence > fixes for mark_new_valid_map() [1]. > > Found while testing AMD_HSA/ZONE_DEVICE on SpacemiT K3. Using > ZONE_DEVICE requires another fix [2]. > > [1]: https://lore.kernel.org/linux-riscv/20260303-handle-kfence-protect-spurious-fault-v2-0-f80d8354d79d@iscas.ac.cn > [2]: https://lore.kernel.org/linux-riscv/20260309-riscv-sparsemem-vmemmap-limits-v1-2-f40efe18e3cd@iscas.ac.cn > > --- > Changes in v2: > - Split patch in two, hook point and riscv hook I don't think it should be split. You can add a hook and it's riscv implementation in one patch, anyway this should go upstream via the same tree. > - Explain hook necessity in patch 1 message (Mike) > - Make hook #define based (Mike) > - Call finalize hook only on populate success > - Link to v1: https://patch.msgid.link/20260525-mark-after-vmemmap-populate-v1-1-e698d859ba16@iscas.ac.cn > > --- > Vivian Wang (2): > mm/vmemmap: Add a post-population hook for architectures > riscv: mm: Avoid spurious fault after hotplugging vmemmap > > arch/riscv/include/asm/pgtable.h | 4 ++++ > arch/riscv/mm/init.c | 6 ++++++ > mm/sparse-vmemmap.c | 8 ++++++++ > 3 files changed, 18 insertions(+) > --- > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > change-id: 20260525-mark-after-vmemmap-populate-68bd790839c9 > prerequisite-message-id: <20260303-handle-kfence-protect-spurious-fault-v2-0-f80d8354d79d@iscas.ac.cn> > prerequisite-patch-id: fdc42f2647e21d111f44a6532887a6705cd470a9 > prerequisite-patch-id: 096fa339c84c36643ae4311fd8362dc63e23d950 > prerequisite-patch-id: 305c876a5f4a23a840a8142aea79b796ed297545 > prerequisite-patch-id: d78cb55d6a616b1170f06a401c8fd44acd11e5d5 > prerequisite-patch-id: b02b4a76e94f3e2821291d4c23b46f6e5ecf5203 > > Best regards, > -- > Vivian Wang > -- Sincerely yours, Mike.