From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1596031A567 for ; Sat, 6 Jun 2026 15:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780758371; cv=none; b=OSIETsbCIjG/rhDSwKjXIridAQy+kpEDMl9nw/k73ZVwqldcCGlu2Rbx3r04hJ3vY3SiJ72p/Rvq1RcLm48JIlqtqhKgRMVmrW/hs920ZImoyW5h3CpCi+3Z9Gu7s8Z6zLOIimfS1uACPgbVJNoE4BqT7LJdJWQcAT7Q+X8shQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780758371; c=relaxed/simple; bh=MqrR1qkfxVNLgLGDFhtcAsrh6I86vMgInnQiO3VemTw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ThBeEXUdgpfwmrgeuBtX3NUxkuHI8zFzMb0Xl0lTR1EGuhXn+fjAYSOhCxTeK2iYtTl89Zaxj+DXdUBwka2HGnh0osE6PVEuc4FWIYLR0fL/BKY0wgO1Wk/uZpl1P/e1shhwJ6ExN9sCjjNhAxyOuRz58zeDfKS2ob3KwK9f0I0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OFK+wQ7L; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OFK+wQ7L" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2bf2d865383so171745ad.1 for ; Sat, 06 Jun 2026 08:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780758369; x=1781363169; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LGfvdtWSGmeyeBZFaUpRxe1TesgPLTrHXjlHvnqJz1E=; b=OFK+wQ7Lb9OiQr8q2/Y2v7d40D9KS+d7wpJutHDHANMQhUcNRk6Per6D4NK+EvgPjX GsSAlTpkgtENZdu2HjxaNmN/AShsea7y3cA0Go9nAbp0g+X9S5XUTjjrZtwGmyBWQubZ LHcKpMdNmukPbPYHxtdlTH3BK5bTVY1yzHQWLORPLM3c8CVaGjJpsZtH2/RRGBNCRgyI Zy7A5bZHOeQ9qGnzRqo4U0iU3qrtaXMJCzwhj2zKpPD8JUnxunW6iEJ8Ta/j74qXrIuN IRDkSrEZU7t+N5CdvGT4a7kPzr+QBTQ1rkcUYZAL4IYpRPJAQHaxteC9wRtgcJVjH1qP TMew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780758369; x=1781363169; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LGfvdtWSGmeyeBZFaUpRxe1TesgPLTrHXjlHvnqJz1E=; b=We0mdn9xNy+cVf3L7SZ5aKuGCnmOX/mF6IQtqcf5acFBDruF2C/JJ3U2ZIZHFcb1pT SB+bBZGOR9V/BXToWytRCVz/cY2iJlzq/tvVU2C9Xg/lrdB4LFTjdQjcROvrR2JJku4K lTnd8i+tutVG11jgFIuI3O49MgcbrTkoMEc3D862xZwf1YTA0daQkcOUJea9DmmfWKu0 UrgiylZYPFFEazedi7UucJoRRoXuXIg3pCIpJcfdUPXmrUVgLz+duoNe0sL6nT4qvUBI y1Toi3arQRFlmKq5t5DuqJMJud3t0ivim2zeTaIr/Cs6jrotw7ECVyLUIyxgcPP5uuX8 1lGA== X-Forwarded-Encrypted: i=1; AFNElJ86yO/3+eeYKWbg/S7xaj5CbEFbtOzm+o0eG295Fcf86jNoGpluDJi/+fEygyKFQ7+J9JIPcG/6fG0rBl4=@vger.kernel.org X-Gm-Message-State: AOJu0YwMhyTc1siogNLWXETzzEahLHIa5AWCR3Xr/J1byqFYlkuzYbRX uiiryDW51L3zLTyGI2OTV21EI4DCMbj3hBrprkZP7EXuRB0KLB2Tjb7Q3DE0VV3llg== X-Gm-Gg: Acq92OEvmObzLGLAElDP7h/y5Giy2BKErM9gv18w0b08D9USlOmC0J9X7ympRb0ALDA PBayB3VnI7s1q75hYrBwXd6IysqZjZOZvTe+te6BxPWG4cz1zkBYIToBOzkAFOtRWRa3cbezu/k wb02bEu63yx9C1F/+5Q08OzAy5m8riyVZP20i8MWWtSIpDG777b9qjwazFuK35vNgFu2wub6rT5 IGh4nsa7hGhqC273yhGnI3DkFe/6/w1H5DtgBOUmZE5jQSIml6KihjwyQospVVj4g26h9p76ZDR BZdWZPlNl6GKuv0owJGtq/4YZ12zu7bgMojxU6d0RO/czdtCFezEoVoAyLmohsxijW4R/zNQvj5 Z1p/k8XPWHNY7dMSL98Z9sMxyXyR8czJuHoBhe2tsBhGpPqbTASLjuqL9szJNOjZJ5aA+B2k/d5 mlPDv1RY4lYniiqMGIUOyVjOjEEs0Jez6BCPinp+4mx0ENg5pcb0CRdd39nMyZxpsJQDDEV2dLB W4JmbPm8pHD0SkRmFi3+LmYKng8Bvxe257dOpgz+wVUwOqxgOLoBa6t X-Received: by 2002:a17:902:ef4e:b0:2c1:5756:1230 with SMTP id d9443c01a7336-2c1eaab121amr3570175ad.0.1780758368860; Sat, 06 Jun 2026 08:06:08 -0700 (PDT) Received: from google.com (112.174.16.34.bc.googleusercontent.com. [34.16.174.112]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282350f8csm13647791b3a.14.2026.06.06.08.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 08:06:08 -0700 (PDT) Date: Sat, 6 Jun 2026 15:06:03 +0000 From: Carlos Llamas To: Alice Ryhl Cc: Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] rust_binder: fix BINDER_GET_EXTENDED_ERROR Message-ID: References: <20260605-set-extended-error-v3-1-d60b69a75f97@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260605-set-extended-error-v3-1-d60b69a75f97@google.com> On Fri, Jun 05, 2026 at 11:13:50AM +0000, Alice Ryhl wrote: > This code currently copies the ExtendedError struct to the stack, > modifies the copy, and then doesn't modify the original. Thus, fix it. > > Furthermore, errors when replying must be delivered directly to the > remote thread, so update deliver_reply() to take an extended error > argument. > > Cc: stable@vger.kernel.org > Fixes: eafedbc7c050 ("rust_binder: add Rust Binder driver") > Signed-off-by: Alice Ryhl > --- > Clearly nobody actually uses this feature Not yet (only error logs for now), but it will soon. e.g. EAGAIN will translate to certain transactions/commands being retried. Acked-by: Carlos Llamas