From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81FA4071E3 for ; Sat, 6 Jun 2026 21:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780779667; cv=none; b=pDGLHShv2l3Rejgs22K0t21iEVchpZAVcdg5Kmna3v7mBx2i9Y7O9fM4wHcC9eXBtXgnSlQNjXNsWO9ihtOPvPH8my8I2pXof34rBWT2Bcb0efpsDS7aU5JSstbKyE37tgXWmFUQ1brCSGtnCmL4IPFAc2rSL450cIK6/vHV13g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780779667; c=relaxed/simple; bh=w+OASR4gUq80s1qt1EdBwvEN8I6E5gpIulaCj1uX/kQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o/ntSVpmbvYfZHRts6MOKsv/tfoVcxVtDQrYB0zoLPg5P6Ugj4fdZJCMO9XcIooC0BHheC6AqfSZ2GlbvWGuIMlJdt0dRWoKg91PTJeChugMXrIPTlE74k6Jw01BkqbJm8EPqDmdUk8PEcA+8nEX9cFHWzs8fyVLMPGegft7XdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lBaDIe04; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lBaDIe04" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-304ec41197bso2870693eec.1 for ; Sat, 06 Jun 2026 14:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780779666; x=1781384466; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VK2W13StNrhEGTuZWNfCX3Wh/LpjhB5vz/xbRiyV1rI=; b=lBaDIe04QXxpnCHSLQ176TUGlCQugRbe6ytHGgCxihtZtp1NbIS87YVpgT9uarA4zn ZbgiAbkSqVLp2+uQGDt0zkT8HyZm/GzIgcTBxeeD+ILuG9vYUHw3/IV7Vq3cwfI94PNm 3h1lMXs0actBhRXKiOxJmfRDxjIZ+8pFWFM/IjipWZKXU3Lge9ku7Y+9etNYN2NDtQQQ rsVSv0TEb8xp/c5/zy81LLpOQ4BPruJZVM/KJUueRWhRvlVNNHcJbFXKWJ04AidLLQvW DsxE8aekAFmBeAqagd/onj9XMRJ759rtAtuhEQHZle6bLDkA+PAVZoI/6DvIb56X5tKS pllA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780779666; x=1781384466; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VK2W13StNrhEGTuZWNfCX3Wh/LpjhB5vz/xbRiyV1rI=; b=B7/P3BeO1HQxAixjHAwqdqO1eP+ewKv/7wPgHd/x9VsoUMS9tPQchMtRd2crT7IjlD Nqd/Q8s1y28npQzNOlPXAvn+VkI/Th/PQYzlSSz6MGbynjiLuspf8zQNnCcezXT2oAy+ YaDNWY/wLICSqB5gm4TpBSWwzov6mvFTiFIBzJTmYP7EMQeSSBCtEI0ga28c5vgJUw9v UE+gI4obTBWIdqzLsB3LDrhqXl0ZNzLNjsvcyxwaTxhEKAkTiMS8WINMns29Sqj2GPGG KeTb6WTvRJvb4wC3Kh4i7Du6tmmfT6F6HukKzSJ9MYB7gkH7MCrJd0Uvomy2cAfVFn6l lBgQ== X-Forwarded-Encrypted: i=1; AFNElJ+CINeBhE6JhOiRlo/EHExR4kvgC5wfNsOTTjSk4YfSG7XPLWSUiYpqNoPhC33+K4I0EX2vWTF6wgLpSdU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7dFXkGpShAG7mtSlJYvKHcBFDiV6utDgjskYpmHVL3OBTBYN3 pG4FmykLu40Bz7bB10FOzkvX8cuY7fBUKLjQA+FqBoFFlRuJhMZRxVo032b6Rw== X-Gm-Gg: Acq92OH+z6LOE/1ZIxMcpyiNktbnM+Ly6vblixCHbeGCBqA7cz8a8imsmW8Z+aDVb17 6R0gBzUTvWAHrz/005ABl+f6kPDMRY+oe3/rsCBs7HGLOdv941uNTLxoyQ/DH+MYDTwODOe/eiI eokvHrMUgBswpqXkSSCsE281hUJgmqdSWMHeojKV2QGlA7kLyHdDMhZW4P4x7SrMGxEqcDyMS4v Z3EhpI+Xrc669xETJcR+xXssE1mOpxsQgbzk0Pe3IKYGm0DxgLvynPNE0tuFXO41UuYXM1Qc/5L bLBBIVFKrleQ+e4D1I1FGU4PJbpg4bP8MM2sPmF7Hlr1aEOp7hVsoVd46zc5UY8vxoRMCXgcSP0 LmNOxqZyTa+qSQMP46sPUA7p+3ab4aSImH2AgzHiOJXWFlxgqjXChX74FUBPBklxKrQpNKYXTsm azTWE+pLw6P69i789/kX3lU+QLjT4sCacj/s/BvLLgWy0qidhX9jsuOMY97jP57jWyRv3qRvYY5 3c= X-Received: by 2002:a05:7300:d4ce:b0:304:e2a5:689c with SMTP id 5a478bee46e88-3077b709e7emr4986494eec.21.1780779665666; Sat, 06 Jun 2026 14:01:05 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:bb2f:1c0b:386d:8909]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074db55f60sm15143534eec.6.2026.06.06.14.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 14:01:05 -0700 (PDT) Date: Sat, 6 Jun 2026 14:01:02 -0700 From: Dmitry Torokhov To: Rosen Penev Cc: linux-input@vger.kernel.org, open list Subject: Re: [PATCH] Input: apbps2: Simplify resource mapping and IRQ retrieval Message-ID: References: <20260603192415.6679-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603192415.6679-1-rosenp@gmail.com> On Wed, Jun 03, 2026 at 12:24:15PM -0700, Rosen Penev wrote: > Simplify resource mapping by using devm_platform_ioremap_resource() > instead of the longer devm_platform_get_and_ioremap_resource() helper > as the last argument is NULL. > > Additionally, use platform_get_irq() to retrieve the interrupt > instead of irq_of_parse_and_map() and propagate its error code on > failure. irq_of_parse_and_map() requires irq_dispose_mapping, which is > missing. > > Assisted-by: Antigravity:Gemini-3.5-Flash > Signed-off-by: Rosen Penev Applied, thank you. -- Dmitry