From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E272423EAB7 for ; Sun, 7 Jun 2026 03:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780804295; cv=none; b=gQ69/7xKKHhjA3AvyscfWghpXhhwo8ZEopjRHLI0EN+PB7jTuA2olUrMPAvKiDIJ9bvl0RObAdZRSmNgHxoFualkmxvzsMDptA1oWw8wSWdGn5S8xuVofYSqpRNaVWNnGtXnu0ZDreHUCgqqyKpk0O7Vyo1x571W8Q/6o5hzIms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780804295; c=relaxed/simple; bh=bZLe+6LzzFIVuKXA64lcJ3QreAqIAsCs5havUEqiero=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=UgKLWNWV0XIDvMpAUqxHXFiVkDv1na4eGPGuNe9mGWHTBDapsK5uCp37OXUDlsLwhv1W30esvH7etBSy4XAC1mExKxZIswwWDQvYew5fDGq13xrQr07LIiZ+ESADdL6XpsznMVIOqFH7Pt34/dAByqMqVduoi8IyJdKc0o5YbTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FfBTzTRT; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FfBTzTRT" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-138129a622dso3497329c88.0 for ; Sat, 06 Jun 2026 20:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780804293; x=1781409093; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8IYt6F2f6eV7Auqh5TfQyg7EFSRsU97hdklgbVAkw34=; b=FfBTzTRT2LRJjTqrXww49jRqPfuHEIp/swz9smkGmCy2HwKKmPGyvtqzjo5acocz4J WXblZXIenSmU2otwK1grSUnF8DcoR4WzW+vgEJ++ersN7OkjyJ9v5/8qFKE0OeNxC7/i KZQlvcLPd6ooAnNiVCpkJj4jmd07P/FHDuGVteQf6IRmlV1ip2tICHUBJr4U9CwsWf3U FBV5KWaBQ4y3P/Rc0nbdfuPJGSkuNayXPn9zJnbWETs1CloexQI4+DZiDCI1pLSaiiLu QYXShq/15YUjjzkQ0JAsD58XYGniN2x1/5JxWEp87UchwPy7M854IVDArPTSKiRwflQq 2zmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780804293; x=1781409093; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8IYt6F2f6eV7Auqh5TfQyg7EFSRsU97hdklgbVAkw34=; b=J16PuI6hvVlM3s/L4BM/w9ZgrprJ91ng1LAIyy9qJFE/cW+/awAqFI4PTa2oWJtE8N xURoa1cPzo7Onv5ecrELCPGR/KbDdzILjw3Gwd70sqCbNH51P7EBaNU8R1d15V7Tqp16 MCcYgcO10nsZ1Zm3Z/2DjdCZ77IctgJqXvzjIcMRQ1yzFEb3KJOjyySYRzMg1Mtpvf9t nlX/TWqTumDSzXNfzmQcJ805ObIbKKKoi6+kj2Op/cICGeLwvcA3md4KONeRpmzA7asS tqox8Q/V6lbUFgYO4+mkaLqMU2es68VbLcXTGhYCs7aMfft29HWOBfHtntO6D2TeOf+v d5dQ== X-Forwarded-Encrypted: i=1; AFNElJ+NUxTnW8NCKrn6srRcH3i0VTi43QDVBwaglTbuCw6SXQztNwjTuC8jBYA57XNki5IysVq5B5kkdxPHvCM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4PX5pxSAyWhyIJEuvbEtfECAyKGeeZJkTKKMPVkWO8lCD9tdh gWnx/iALhjljp5VqTgFyHjoep4LxEIMT79byd/OHdU+n6ohDRqe/fOci X-Gm-Gg: Acq92OHVy8DCgmoBo7asVRT3FiL/hhjodvy3DKX1Z+4C3b2N4ElRX+0JX+cBpchYbF9 o1Rt7HgXdTD2id1o6ZRjyQVTykW5/N+arP5RmycVWxKC0RqEqUBh1JPBckTJgntMYGsHjXEmZVr RF7IaABPQh/23BuX9PI87F3yZTDVW7YhPjrph6jYWsbomBPp5nL67kO7PZY5VsrjMdrIhEwUyo9 TtSrcZiR+rQ2Rc/vvjXNI2Nb6bcO5TZIx+4+jxO//bWWm0gGje4+dXsh7z33CsoPaqCRq1LmkK1 pZ1Y5yzcQOZ+acVZj0nr6mErtvGB5LVIGA6AR0Snk3DY7cqNFUSpLfIY76NuzJoZXKV19nLHzCW 4LzBjuWgmAbeCqMB0UJR3ZEdpxN4hOJ8tZijXB0kpCt5fomNbfnW0y8sK+Sx/2hCGYoJHWDl7rE c9SxchF+etcNQCJJg9OpVGKPzyvow9EZHPBHYyymspMC9GHO6WvCdIhxXGFxCEU5FwwQ1ViW00R +D4D2i+G1/36A== X-Received: by 2002:a05:7300:320c:b0:2ed:6f94:9d9f with SMTP id 5a478bee46e88-3077b2e0c15mr5908783eec.11.1780804292844; Sat, 06 Jun 2026 20:51:32 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:bb2f:1c0b:386d:8909]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074db528dcsm15228525eec.3.2026.06.06.20.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 20:51:32 -0700 (PDT) Date: Sat, 6 Jun 2026 20:51:29 -0700 From: Dmitry Torokhov To: Danilo Krummrich , Greg Kroah-Hartman Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] software node: allow passing reference args to PROPERTY_ENTRY_REF() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline When dynamically creating software nodes and properties for subsequent use with software_node_register() current implementation of PROPERTY_ENTRY_REF() is not suitable because it creates a temporary instance of struct software_node_ref_args on stack which will later disappear, and software_node_register() only does shallow copy of properties. Fix this by allowing to pass address of reference arguments structure directly into PROPERTY_ENTRY_REF(), so that caller can manage lifetime of the object properly. Signed-off-by: Dmitry Torokhov --- This is pulled from a larger series dealing with breakage on Geode: https://patch.msgid.link/20260329-property-gpio-fix-v2-0-3cca5ba136d8@gmail.com v3: addressed Andy's comments about formatting and commit description. include/linux/property.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/property.h b/include/linux/property.h index e30ef23a9af3..14c304db4664 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -471,12 +471,18 @@ struct property_entry { #define PROPERTY_ENTRY_STRING(_name_, _val_) \ __PROPERTY_ENTRY_ELEMENT(_name_, str, STRING, _val_) +#define __PROPERTY_ENTRY_REF_ARGS(_ref_, ...) \ + _Generic(_ref_, \ + const struct software_node_ref_args *: _ref_, \ + struct software_node_ref_args *: _ref_, \ + default: &SOFTWARE_NODE_REFERENCE(_ref_, ##__VA_ARGS__)) + #define PROPERTY_ENTRY_REF(_name_, _ref_, ...) \ (struct property_entry) { \ .name = _name_, \ .length = sizeof(struct software_node_ref_args), \ .type = DEV_PROP_REF, \ - { .pointer = &SOFTWARE_NODE_REFERENCE(_ref_, ##__VA_ARGS__), }, \ + { .pointer = __PROPERTY_ENTRY_REF_ARGS(_ref_, ##__VA_ARGS__) }, \ } #define PROPERTY_ENTRY_BOOL(_name_) \ -- 2.54.0.1032.g2f8565e1d1-goog -- Dmitry