From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4509134FF76 for ; Sun, 7 Jun 2026 11:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780830021; cv=none; b=YKornNFy3HtlereyIyJflHabD6Gzpf9+nzFWH5yUsXGpsMy6yWx1SApuH6bJyZ/R/cc+LFpaMA9yJ7Qqxn6qUbbZSbauA2GimVkRy4Z5B0MvMIJ54P5ajRohWLW0XN0o5I/mDsHgXt25m0x3V7ZpNpQdlSDSlTkKW1nL+R1UXt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780830021; c=relaxed/simple; bh=8/nHMOedf7I9M3RkF84w96H8uyliRHWJB7ZgrxBpDyk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n91KWDqgbSPgxWrXZImkWeyXI4p+c1+t97oTTUmCgN+gD2M9+YHFAK/733o1ixASatw1hzNbomUYlTe7PiqATlLvpZa84SahYJHSxQ/P+SQ1NhlGNtE/z5dfC/HLLi333+QCJf11K8pGOsEgO0/4F0Qu+Y5qbNp7fQ3xSa82kx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l5yQm/Gf; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l5yQm/Gf" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2c0c35980fdso34472415ad.2 for ; Sun, 07 Jun 2026 04:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780830017; x=1781434817; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1E/I/zN2uqhOEJWozYb2HyCQ4vBy69WdPknVxIge1Qg=; b=l5yQm/Gf6g0SaqvsIXlfkCSVCu230a6paHhWOSNV/kAxVQM/klSzLX9wowUCMDAx31 kv23hAk/7LUdxvLb8Vd0lLdoA4Uz+XIplm7HYpj0YFujUch0ZdLQol7RWMrIl3li+mWy Y0gWJ/jHIMow0lPDE7sYIASyo6bOiO2PoLEjbAbzp9PWbI8lQby9bLfG9ot6wP5WdkuM VzBKNC0Kn1ouVYIb2QSIwbB0LeMvzfnN0bDIRBHlDNYjPuJB4zkk2UfXvEuemlgW4OsG p7Br9kkIWFVL5iwNUOGBF6MQoBo6iAcmKYTsWdhjAbr57u0Nkx6GJvrMFv76kofTXruh lC8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780830017; x=1781434817; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1E/I/zN2uqhOEJWozYb2HyCQ4vBy69WdPknVxIge1Qg=; b=FHhUO1FNlVBi9iwJHvVmlbL1fooaGIzTSknM+pAGj1UDVZIQYv8HJcnIzjBasSWG0y 5rs4mG5R0lyRgHxfZCLQ0agyR8opfsFI7o0AcGv9KZ4dzobRFWfgXhsOIDgTvQfTXDGe FfxxOaTDEXJ5QiNFM0hs9zdyWYfFbgdSICkuKZkQBbSPJBWt4WDinl2iY35CWlg7eGsW HvViyOMIWQJ/EV1hdlIbz/hHS1sGvzcmKWfWqFFh/Ha5oM8RFHp1Q2S/I4x1I2KwIc8V iVhd+0reeIaspJnRDOf/KkjuEZ3NRSReFv1NzZHad+CyVSXgkFhPCUKgTJEyFU1gAUvZ zCmg== X-Forwarded-Encrypted: i=1; AFNElJ9w58yAiUDCIWX4DWUBjsRhbd0fc6av4zgFu1TlXraHmnP+GUiMeRA8QIVCH6OqBkpNhfRhOE6Tyw/8iaE=@vger.kernel.org X-Gm-Message-State: AOJu0Yws/P+qA1YhoFv8B83t04WU3bFbptSyAPPrJt2NdlZ8JXynuesj oy6/QyQYONxg4woAVC+yUsRnSCBfNQDFkaKNIhExJQAxEhc+hN9y5Jfy X-Gm-Gg: Acq92OENc2Nn4qceg3lKQhsbhPBUsEyUt+PdCoEc9nD8jBtU/HUAyVKOhV6TMMBp94m eBTUjMYWx41RqgtOlqQdqbpLaIY74ecFgPKWDsxG7aBjACVdGuio6RjXPROumLtIjFpF8Fvmy/b tlycDQDMNR5hRX/Nh31hxk3C3V0PnaYU/QI3NSzBmUIRNCyfl+qDUE6resBC/OG2lTSgE9e9iT2 xrDh8msK0StWZ67ySkph1206oWnTzGPcQoUUNeLmGvRvKy2LGFGsujc/lmms94J2EMcarWIWgoC 7FtylEN1Q0gvhytSbiOU17TcveRL6udBnB8EOw/x5taLQTYt+SGWVsjMFLhUgs6viA6D3RsVIMO o8zKkCe8hJWqRHITfUJNXj0d5N3xMU5GHESyEI9HrlYQ+c52rJ1tMrtAgToFqyzmpy8sTDd2zg9 vM05cYaam5/ykx/ahASDLLKjIwIJH+TE7b4S9s3wOod94lNvkLplTf2ugK X-Received: by 2002:a17:903:1206:b0:2c0:bb2d:a314 with SMTP id d9443c01a7336-2c1e85aad3cmr125353995ad.28.1780830017281; Sun, 07 Jun 2026 04:00:17 -0700 (PDT) Received: from page.local ([2401:4900:88b6:5847:b159:e15f:b4ca:e80d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f8bc5asm154398825ad.27.2026.06.07.04.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 04:00:16 -0700 (PDT) Date: Sun, 7 Jun 2026 16:30:10 +0530 From: Ajit Singh To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Add Vicharak Axon Mini Message-ID: References: <20260519125655.23796-1-blfizzyy@gmail.com> <20260519125655.23796-4-blfizzyy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Sun, Jun 07, 2026 at 01:17:43PM +0530, Dmitry Baryshkov wrote: > On Tue, May 19, 2026 at 06:26:55PM +0530, Ajit Singh wrote: Thanks for the review. > > Add DTS for the Vicharak Axon Mini board based on the Qualcomm > > QCS6490 SoC. > > > > This adds debug UART, eMMC, UFS, SDIO WLAN, USB 2.0 host, PCIe > > support along with regulators. > > > > Signed-off-by: Ajit Singh > > --- > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > .../dts/qcom/qcs6490-vicharak-axon-mini.dts | 1025 +++++++++++++++++ > > 2 files changed, 1026 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-vicharak-axon-mini.dts > > > > + > > +&pcie0_clkreq_n { > > + bias-pull-up; > > + drive-strength = <2>; > > +}; > > Could you please add a /* pinctrl */ comment at the end of the file and > group all pinctrl-related changes after it? > Ack > > + > > + > > +&uart5 { > > + status = "okay"; > > +}; > > + > > +&ufs_mem_hc { > > + /delete-property/ qcom,ice; > > This should be explained in the commit message. > Ack, I will explain this in the commit message. ICE is kept disabled because enabling it currently triggers an SError during qcom_ice_create() on this board. I am keeping ICE disabled for the initial board support. > > + > > + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; > > + vcc-supply = <&vreg_l7b_2p96>; > > + vcc-max-microamp = <800000>; > > + vccq-supply = <&vreg_l9b_1p2>; > > + vccq-max-microamp = <900000>; > > + vccq2-supply = <&vreg_l9b_1p2>; > > + vccq2-max-microamp = <900000>; > > + > > + status = "okay"; > > +}; > > + > > +&usb_2 { > > + dr_mode = "host"; > > Is it actually host-only? > Yes, this is routed to a USB hub which exposes two USB-A host ports. The board does not use this port for OTG or device mode. > > + > > + status = "okay"; > > +}; > > + > > -- > With best wishes > Dmitry