From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FE4638A73C for ; Mon, 8 Jun 2026 07:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905038; cv=none; b=qa5nh54Z7tm1fOKXgUfrKRu8E4/qBR8Jbv2Ox4mARgmVxLOAoeCO1dmGS70Iq4LSUWj0VWgei2RNv6PxB7q9te52+/nSZZNg7KVxYGduXRfL9RJwUx02sFoFmKGo9lwXcHxuzNPGJLqabwNV3Ajm1zR0JaLLQmLQeK7YyUfdDc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780905038; c=relaxed/simple; bh=zkhyzgO5tDO4myvdNulSTUD7XMAtqn3FBpCPEmSzk/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gfrG3+1VPNg9cCyaSHrEZH7FwfcEL4tPpoDvr1JfrdC6r1aI/C4jxrNZim8B5ll9YOgXs/apPFXqA6jtOoep4l4yj28XYxHFQQ1EU/i+IQzPvirOSpv9HFmOR03xfrOg1vhZDkZ9T5Gikqt4FQOLCaecae8oKUdV81xcp0tdm54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=kWlt5VoC; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="kWlt5VoC" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-45ee5cdbd28so2881909f8f.1 for ; Mon, 08 Jun 2026 00:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1780905033; x=1781509833; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tddTtw7jfmG7mtNYVt3FvpJwKAzzKQR2or6J9wFp804=; b=kWlt5VoCJG0YO8sLTEK2h92j0/89JYTQxbZw2H40AJ6kqResy3krm0ZAJ3eub7bEDG kuUuNEl+sx1ktBNTnUEvDXjmC3PGyjhNHsGUamv4jCh7qNEs0K6qGMCuyEYrASWEgUBs +Y2TZ0Z/9bL/9KrxmHlQdgA6n5+IzmZPx//SP4dIk39LCz+xe9ta9hRKu9jSKgr9LlPZ DWO04o3a9z5yEHGcmIIMNIMw+MTGRAR9vfjYKPIK4/y61iEtYjNHadFWnM+LLYv/c6w1 gfsGMYDBI7RJ9N9sMD/Exoylw1QLKd5adrlJ/tg5J7gwnxeHxr2uQQ3uC1OZyBZqALlO 4RHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780905033; x=1781509833; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tddTtw7jfmG7mtNYVt3FvpJwKAzzKQR2or6J9wFp804=; b=ojXW0bGc0aej3Rdb7mzfyU9tMtmCJlEKJHB44KWgMSJmdYfkiyCxEUV7BcHe/klaiU TjkpdI8lzMFHA50G2VqFgzVcRFTrn7h7OA38g3083E9LiZYTvvbrXncId9g2f8YrO0by hg0tqtkeUzWS+X0BLhlUJiklHdCwCrusXFiJ0GEM0fumr6dB2OLUQFu3W82puCq7Yok9 smUM5+/JuposcNRZOr6SOQAkD6DOcyppARYKT3IeWTgYYgSLotnkUeA9sQNmKssdPZkE 2bDEwAHToGjDNQUk9QwTKpD2RMLVukMZsMuMP11XZiwXSwh6ugTMcfR36AFGTB7amDf2 +DZw== X-Forwarded-Encrypted: i=1; AFNElJ9Q3gEHOt/IbDSNiAVOY7IkGGE1JO3LKyrkJcA7eY4bhGPdqWTtgKBAagMOhMrDKcIuQqckqbTgyS0rKHE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt8Uop9bV+E++ddgueuGD4hPqRnqwL8GHUm4JIusxGlQvpZMNi dphNaH83XyXMJ+k7QyOUqvVoklPJqMJSV79GBtjpt58dTPb98b4Zdq9oSkDM/ut8LUxLjHZbidT ys+tc X-Gm-Gg: Acq92OHJlOi+snr90L8Wz+cFR199JR7Ixacw2AvBgkkZUtAgoYH3+BJ3QiQP+fwszPm 9BbWs0zuSmVw11UkBbEEJzAJcGi7NFZ+mMaWBweoUKM5iNSumcp9Ixng2w8wYFr+oK+mVdrqn1m oG0ldbT4o1PgjhPR/yEOXEBgUWqHe2U8rpIzJKpwqkyJ34Iw8nfK0UYju80S2TSAA+RSZTz5RAE MzN7hRWKitzz7mvLFXv46WfSFmpm/cP5viyzZvc8N/f11EWaD2JefPdQ6xtvxxn9MigRDp9JnOE zzwjP9aSytY/ClLyRUm+ggQvXui4EoeaPJkgAP3+FRNaYqNBdCu0AcJHmaZRP6a6pwxFQKYntM0 FYf+VMwiOOnNYCUiph3kDzvMzeFQGQuu2NxeEyts1q5glSSUEb9WggPIfkS+ya7Se5dml0mIAfy khJNpz6AAxJQ5PuSph+ibWVKUoS5U6+DuvPG4MNT3+CZqdg0gxH4g9fccy3vV90+qfr5gN707Ro do6w5u+93A4ULGHYfxui7WPww== X-Received: by 2002:a5d:5f90:0:b0:460:1c93:6eb6 with SMTP id ffacd0b85a97d-46032daaee2mr18961681f8f.20.1780905033344; Mon, 08 Jun 2026 00:50:33 -0700 (PDT) Received: from localhost (p200300f65f47db044a0cafb8498f2f85.dip0.t-ipconnect.de. [2003:f6:5f47:db04:4a0c:afb8:498f:2f85]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f0a43e9sm50122898f8f.0.2026.06.08.00.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 00:50:32 -0700 (PDT) Date: Mon, 8 Jun 2026 09:50:30 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Nathan Chancellor , Mark Brown Cc: Rosen Penev , Jisheng Zhang , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: cadence-xspi: Revert COMPILE_TEST support Message-ID: References: <20260606-spi-cadence-xspi-revert-compile-testing-v1-1-76219ea378bd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lhabohevynta6do2" Content-Disposition: inline In-Reply-To: <20260606-spi-cadence-xspi-revert-compile-testing-v1-1-76219ea378bd@kernel.org> --lhabohevynta6do2 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] spi: cadence-xspi: Revert COMPILE_TEST support MIME-Version: 1.0 Hello, On Sat, Jun 06, 2026 at 03:26:04PM -0700, Nathan Chancellor wrote: > Commit 0c5b5c40dc31 ("spi: cadence-xspi: Add COMPILE_TEST support") > allows this driver to be built for 32-bit platforms, which causes a > semantic conflict with commit 4954d4eca469 ("spi: cadence-xspi: Support > 32bit and 64bit slave dma interface"), as readsq() and writesq() are > only available when targeting 64-bit platforms: >=20 > drivers/spi/spi-cadence-xspi.c: In function 'cdns_xspi_sdma_read': > drivers/spi/spi-cadence-xspi.c:601:25: error: implicit declaration of f= unction 'readsq'; did you mean 'readsl'? [-Wimplicit-function-declaration] > 601 | readsq(src, buf, len >> 3); > | ^~~~~~ > | readsl > drivers/spi/spi-cadence-xspi.c: In function 'cdns_xspi_sdma_write': > drivers/spi/spi-cadence-xspi.c:623:25: error: implicit declaration of f= unction 'writesq'; did you mean 'writesl'? [-Wimplicit-function-declaration] > 623 | writesq(dst, buf, len >> 3); > | ^~~~~~~ > | writesl >=20 > As there are no known 32-bit platforms that use this controller, revert > compile testing support to restrict the driver to 64-bit platforms to > avoid burdening the driver with workarounds. Given this fixes a build failure in next and we're at -rc7 already, it would be great to get this in. Fixes: 4954d4eca469 ("spi: cadence-xspi: Support 32bit and 64bit slave dma = interface") Acked-by: Uwe Kleine-K=F6nig Thanks for preparing the patch Uwe --lhabohevynta6do2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmomdDUACgkQj4D7WH0S /k4UHwf/W9Qvh79Nc8CG7LvGA/Jkb44VNYoKXcNGrsYfqWH0OUlr32yDIiIxk/CS H/YpqcC27pj7e3Re03XHPHZBTlcNcBZNAhGWaN0kFM1+UV+R0NNVO1bx6gGFgt8J QN/dshTsh8qM895Mp8YPuPm7XSIqeTCrT/ZiGw25vgpOrmm30eROIDnr9IvUgsVi 9MVU2o2VXc+3JZQjK97v7RsVOi1ue8IoHrP28jkcYgFcTeWTjSwt6xCo4jpK3P6n eKu+1V8WvEgL1eCRVvFhHgOo+bKry1WV3Ljm8wV5t7BQTFKBXs1LUFYtRDhWmr1V ccuedWPv4YApPm/As48MYE0FIrrHfg== =18VH -----END PGP SIGNATURE----- --lhabohevynta6do2--