From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB7A37DEBE for ; Mon, 15 Jun 2026 12:24:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526246; cv=none; b=T0vyZdZ+A8nCsrpTvUDfNjbDs1SJVj4wveKhpT6LpHky01G0NcyYyFF2GkIkwag0WOqBi4jPn4foVRYGQ5Hxk5cv9EH7pFO7A1nmTlVEvjeeJq2SPLHSNYcGZWSK99NuZxz4N0pE01b1MZfQjeZxzhsB+hLVNmCRcwSbB0h5juo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526246; c=relaxed/simple; bh=8R7K56Pmf4QlVeIaL8pY6E/P3sp0FamdeJyhngh6qf8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bgUJ8u/1tdMU6hMfWaYmgU8x0urH5zcdYoungtwMXylNzS37tz0W5j5/Tnxyp4H1ABY4mQ3o0EmYaqhjxZEQaw3nvDi3CFybFNavKHGu3mWG2QYoJxNpkjrojrW8vS29Wj+8EuwHhzNB3ZJ0WS+wAP/7/LtYVNCGfWrxfNxvGXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O72vkri7; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O72vkri7" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490afc47455so14084885e9.2 for ; Mon, 15 Jun 2026 05:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781526243; x=1782131043; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K3ueRdH34oY7RNPNueN61e8MZTeWRpWsScceLyDJzwI=; b=O72vkri7uguzNxnstby8E1RI4d8PFQyxKa8OH8Yq6ydm6/jeKr0oHT+YkMhNNAo9ZF Z6Sf+shNUyDrFD+lwkgVzIC0CL1FdlTps2kkN71v5ZR1V28ZYOfAUppOkw2sWbVbJuvZ CPetRjGD0lXbwTSEBnaWmUuMyDyNHRFMAd+g5duKcp6nC1/zLVY14QM/llCuXbd4UhrB DUXNOctCFH01gzSChwkMtUom149VXwnGeqEdv+LDkwptKlcIbxEYkXjOFEc+2lHro0W3 nTDgMdtYwGDDB6HNX4hxVC1rzYoBXpl4olrmRHhIS+EHZ4GNUcIak1xDm4SFr0QcUL7/ atHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781526243; x=1782131043; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K3ueRdH34oY7RNPNueN61e8MZTeWRpWsScceLyDJzwI=; b=DhK1p0bp36+5wcBuhXYydkaYm89YJEgsLUoaU5qAvttjRhhe3ye3cJbRpdHoUIIRPZ AEOfsZCO2aQEeYnRjGS103vGWl3/j6Hu8SdQt/+WvjcGA79IlyehFGD9BMHXZa+f2EGt gmDZTQvknUaDEEfuPD9h1UhYuDi+lPBVbXzxeNMAKwXjbip4rWJ10iYII7jUrQD2dhIT xmo8LzYdTTa6XdlW7as5kvNeosUjEURwii3upFU75onIuubMmS5XegjKYp/1Oiu9LVNz nh4iZBuf9DADymo1g+F+f4BxuA/gSbOwB61mFUzG1TTyPUR0qwM2KnKtNWJZu5Vesa+O i4pg== X-Forwarded-Encrypted: i=1; AFNElJ9Kkp6ePxbTnW2jfvMxGwAG3Fu/bA/UfLO1/AyNdmO2/GnvIwaFxwGOcX9KLfoBp3+dC9GJ9CI21DHKzX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx51Fh/JiJje4XBVzOHUCW95LM3pd/XanSa5Lt1TWVCe/RtzEGB 23f2CwutkL2SZ6xwwyrXDBaQYCn+RF0s2wndOgRYpPJ6oAfDNhKDwNp1MVPEfNgS X-Gm-Gg: Acq92OHZTCAh4j4WTfxLTHNSHFa4QR2bx2eaDYLoCY6LkN9+kCRKKU94kFEDtNaRzQg h6MYuLiK5AZ8jseqI6HaTn6z0RN9V8Cfqzjj4mmckmEGALL05aIFK27yaeGNwtkADiQq+HOsLn+ KhS2ghgis73UZ2kGR6NlPOhHbW6SMpyogSRqnlwVauRt1FZPPIjWGZTjuwH1oGPa2y76I088550 pfduKtJxMlbD6pnr57k/kaTUDjWa3JszLh0DVth1MFXai2RQC3bFjI2cAdHMrqKUBuOKJKhA0Oa XKgT3JV4QdSiTyVub8R1+ywXDxilUeX21fvWERbWayqQKqANgeaPC3t4HyM4LbIwz5a8qgcc1Dv HsmxufRn9OpNrlsosPzlkOnn6kTmj81NSUo53yfanJxovSQsKlXKeBGPl0mDm6iTyXBPq4ALArp uTyCQWIvc9gnWygpPykYSYYpDdjR/9ywo94VDjrB/GCy4jPi050lW3v+17Vp8g0Ly9DxYtTgILW gQ+jixThVeEr/Y4Zwvv/qDYgqH7thd5dPbge63u+v9j X-Received: by 2002:a05:600c:15c7:b0:492:1e36:8c71 with SMTP id 5b1f17b1804b1-4921e368cb8mr105895235e9.36.1781526242900; Mon, 15 Jun 2026 05:24:02 -0700 (PDT) Received: from fedora (cpc92878-cmbg18-2-0-cust539.5-4.cable.virginm.net. [86.16.54.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-492202e5d6csm270653965e9.3.2026.06.15.05.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 05:24:02 -0700 (PDT) Date: Mon, 15 Jun 2026 13:24:00 +0100 From: Vishal Moola To: Yichong Chen Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] tools/mm/page_owner_sort: free per-record allocations Message-ID: References: <610C3A89A09303F8+20260612055017.632263-1-chenyichong@uniontech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <610C3A89A09303F8+20260612055017.632263-1-chenyichong@uniontech.com> On Fri, Jun 12, 2026 at 01:50:17PM +0800, Yichong Chen wrote: > add_list() allocates comm and txt for each page owner record, but the > cleanup path only frees the outer list array. This leaks both buffers for > every retained record. > > Free partial allocations in add_list(), discarded records during > culling, and retained records on exit. Return explicit error, skip, and > match results from filter_record() to handle get_comm() failures. Nit: IMO its bad practice to rename function names without stating it in the commit log. Especially if you reference its behavior in that commit log. > > Signed-off-by: Yichong Chen > --- I like the enum approach. Splitting it out and having this as a 2-patch series would have made sense too (since doing it this way has 2 distinct logical changes). Whether combined or split, you can add my tag: Reviewed-by: Vishal Moola