From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15F5B1B4F09 for ; Mon, 15 Jun 2026 12:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527294; cv=none; b=t5Jc6WGoMePvs7qVgECJyZhWtPJZU360KOafDyEkQFkPZ9Fds4CdoDAKt0qZgXcZNQ8xzAg/MjYGHIMq5Q/rtJSosRAUjhTl6eA7v60M295FHF4CWIuL7+S4YT9BJorEVTjRQ3O5TpK4mgmEmsD+sNt/7TNslhIH41/IN1LxOes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781527294; c=relaxed/simple; bh=AR8rcICuJwSgBystC89jaxfmvkVzd2jGVSiL/N85iSU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GrliNBifOEjmaRS5GXoMJec++yBiWgBaUBwEfK1PC3gj6YCLy1eUvB4M4COscCH0dTpG/jnQzm3U24BjXdU+aqYiY6MbE96U1/k+1qCSqfhgO98MLe+qiWWVL1eutaDe3NZNLEXlnriB0KaIWxhfI7ADhm/di9rsZZ1nIuFPTnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lA9ykFMo; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lA9ykFMo" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4903d730b1fso43059325e9.2 for ; Mon, 15 Jun 2026 05:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781527291; x=1782132091; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E292MqvsqbcMEcmOXP7dh5Ygw4VCRCZYV1TwFqPA9G8=; b=lA9ykFMogfNL/RnW2SYVHVgVmRqKTqw5eKRMjK9njn4hxuLEQtwjbwMNZWPp9JEFrh ryWO955RKNMoT3Y8pQ8Nh5xgp4VzupRsIc6EANzkn8UfM03s7wF4cTGDvRuxj7hKb/mG KnCKvdhkDXKzXWbp4ziHtyFG0OS115cw9fKvwALEk8OSCiofJFB2w0TP3ob3KtDazme8 9ABfhh8lc/1itGh/LNScX6k2MrTgRRKu1PQODIYxtbWYzPzeBRQZZEQCdl6Gpjjtbdcj cDN1PZFOxRys+4vWPow/24mbk10FGTBFPDBEYf/Mmw5Pp3W1eNabd7O4cKtfQsaTquI2 Y0xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781527291; x=1782132091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E292MqvsqbcMEcmOXP7dh5Ygw4VCRCZYV1TwFqPA9G8=; b=HU+cEc9H2tRW4vKuqXB91AdlmkA6sKBNutQ/wojaq4qxhocjmHoxu8xtJJN+lskocN uDTU4OSnES7t+PUT7YMMnkQt6P5oS4OV+lbU7T9T5znykf2aQDQcuRBuZZlarvDh7Og2 rgspdcxXa4pBlIr9ES5VNIwmpEXc9+XlE90Zvu5BFEtvP/bNLsK+8weKkX4hK3wzJrSr Y3GIzk+vTw7CuZPi4yaIfbDDfVhScr+l86lSwgL6lo18vBB7ve2okQOSgvywL2YO/818 0YZXMDh/k8YFEdDimwZRFtBD+aeF5xmZqUHximyWm55GhVXNzfarXTNYwu5wuNiVqQiC HOGQ== X-Forwarded-Encrypted: i=1; AFNElJ+bhWJZY0WTKfWs6yq+Kb6YLoKuK6bXJOe38Q0DVl6xmDo4gF/jr5IqQjesILEESuwXT5W+xksz5+Rd23c=@vger.kernel.org X-Gm-Message-State: AOJu0YzZG3mim9tlcyuTryU5nRtvmFLo3HSC0jOKjvE9jiwiGxXDw26J RFWMiFyRI6FHAJMgyDqjw0PGDsWr6oqTzFG1GeLJajCdRfKfFI65cL0k X-Gm-Gg: Acq92OHIP6fXwfTVAj3naBcnVLA7lczXCoraoeZuEjz0jv4DzvJ5LglA2H6NuFbNR/A 3jAC2dWJ9jktlafgsQNCosT8W0tZxT8lvwQsG4QNW5UkAG2qS3MV6VpTa7zZerMEEQYYzNiy8cM 5vSpC4IQUXjNp1axVEt7H6mKhwVPhmlgnF8xNCgUQfOrUdj3QsxCJF55ie0ClV6lv2+xlnVuFST 99LoQbd3uGqI13WVpS5ccu/16W4pmcwf400Jny4ajIwoHj3Kg0VumajTOXuiT5/jbF3sP+SvPEd ZNcepTfss1DpfR2hSVe6jCuGXhWT/xcYMhvgI4kS1PWwSe8LTHtdq8EFyJDrv0pURzqrNNL9ZgM ViPUz1O2Zh/uUSzMExYXv5wdhF11FqrV77qUCGTRtfqS/h+3m0/Z/oq3VSMKZriiC7g9tgERA32 xRGiJ5kju312i/kyH+gbbHh1fKshR5sVXyUImSksLtkvr9mkotDYgnIhclYdz08UoiHaXCTEZ7G BYMNKRVoOrk7LGbWWDWXbDdyWhoEQWJUg== X-Received: by 2002:a05:600c:81c5:b0:490:52fb:12dd with SMTP id 5b1f17b1804b1-4922007483bmr119938285e9.10.1781527291187; Mon, 15 Jun 2026 05:41:31 -0700 (PDT) Received: from fedora (cpc92878-cmbg18-2-0-cust539.5-4.cable.virginm.net. [86.16.54.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922033dd59sm239164755e9.9.2026.06.15.05.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 05:41:30 -0700 (PDT) Date: Mon, 15 Jun 2026 13:41:28 +0100 From: Vishal Moola To: SeongJae Park Cc: Yichong Chen , akpm@linux-foundation.org, penberg@cs.helsinki.fi, clameter@sgi.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/mm/slabinfo: fix total_objects attribute name Message-ID: References: <96556748872BB47E+20260612071359.649946-1-chenyichong@uniontech.com> <20260613002913.1509-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260613002913.1509-1-sj@kernel.org> On Fri, Jun 12, 2026 at 05:29:12PM -0700, SeongJae Park wrote: > On Fri, 12 Jun 2026 15:13:59 +0800 Yichong Chen wrote: > > > SLUB exports the total_objects sysfs attribute, but slabinfo tries to read > > objects_total. As a result, the lookup fails and the field remains zero. > > > > Use the correct attribute name and rename the corresponding structure > > member to match. > > Good finding, thank you for fixing this! > > > > > Fixes: 205ab99dd103 ("slub: Update statistics handling for variable order slabs") > > Should we add Cc: stable@ ? This variable isn't even used... so we don't need a cc stable. That's probably why no one spotted it until now too ;) We should probably be printing it out in another column; I'm not sure why the initial patch didn't do so. > > Signed-off-by: Yichong Chen > > Reviewed-by: SeongJae Park > > > Thanks, > SJ > > [...]