The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: radu.sabau@analog.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad_sigma_delta: allow COMPILE_TEST in isolation
Date: Mon, 8 Jun 2026 11:04:23 +0100	[thread overview]
Message-ID: <aiaTVDWpKECtZPyz@nsa> (raw)
In-Reply-To: <20260608-ad_sigma_delta_spi-v1-1-61e37666d9b6@analog.com>

On Mon, Jun 08, 2026 at 12:02:54PM +0300, Radu Sabau via B4 Relay wrote:
> From: Radu Sabau <radu.sabau@analog.com>
> 
> AD_SIGMA_DELTA is a hidden tristate that can only be enabled by
> selecting drivers (AD7124, AD7192, etc.), all of which require SPI.
> This prevents compile-testing the library code directly with allmodconfig
> or by manually enabling it with COMPILE_TEST.
> 
> Add a prompt string guarded by "if COMPILE_TEST" so the symbol becomes
> directly selectable when COMPILE_TEST is set.
> 
> Also add an explicit "depends on SPI" since the ad_sigma_delta library
> directly calls SPI core symbols such as spi_bus_lock(), spi_bus_unlock(),
> and spi_sync_locked().
> 
> Signed-off-by: Radu Sabau <radu.sabau@analog.com>
> ---

LGTM,

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

>  drivers/iio/adc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index a9dedbb8eb46..329d1f6e5106 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -33,7 +33,8 @@ config AB8500_GPADC
>  	  and USB voltages integral to the U8500 platform.
>  
>  config AD_SIGMA_DELTA
> -	tristate
> +	tristate "Analog Devices Sigma-Delta Modulator support" if COMPILE_TEST
> +	depends on SPI
>  	select IIO_BUFFER
>  	select IIO_BUFFER_DMAENGINE
>  	select IIO_TRIGGERED_BUFFER
> 
> ---
> base-commit: 4549871118cf616eecdd2d939f78e3b9e1dddc48
> change-id: 20260608-ad_sigma_delta_spi-6063f200195b
> 
> Best regards,
> -- 
> Radu Sabau <radu.sabau@analog.com>
> 
> 

      reply	other threads:[~2026-06-08 10:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  9:02 [PATCH] iio: adc: ad_sigma_delta: allow COMPILE_TEST in isolation Radu Sabau via B4 Relay
2026-06-08 10:04 ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiaTVDWpKECtZPyz@nsa \
    --to=noname.nuno@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=radu.sabau@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox