From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DBD1495505 for ; Mon, 8 Jun 2026 14:56:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780930600; cv=none; b=aG/r1ybGuLFLkFR7y1EoRyz4M0HAd45E5YeqBx2BJkAKvN038fiFZARiEhkwgq3BzYl5vUU0PhwMFTOzvlJxRBkNf+BD2gCRj32IX0GxpbsxX7MytO4RsnKIsgx12v6QAM/Z0cBce088XYloeOu6kTXJyRpj1AeW6SZ61r/m9Sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780930600; c=relaxed/simple; bh=OLvBvUjkzfMn1Cidy+KbhXvOT4PjxRs8Fx8SkFfpgFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WxeJYJlycW1/rEnsOmk6NGT7FvIzwT/JaE0qLvRcjBMpagywpjpnv008fs/jm5KeNXiwO7DJOtvunQ9c4vZP1uh652f8peUv9hVs1PA6LUV86rc3BvBCa/Unh8Lf8fEGZZx1J7nIHKl2YJEsoVO0rX1z78mJ8yMZSueb0jjdJuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=Vz+OvLtn; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="Vz+OvLtn" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-516d0db9372so35578811cf.2 for ; Mon, 08 Jun 2026 07:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1780930591; x=1781535391; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5XaEoBFZ0wQN7RayZ7ZGkzrqQNmFAZboLFpyYk5DAFk=; b=Vz+OvLtnDLdBCYdORDQbcTs2rusiLhkpjeqFPNwcEwNYhHyk8d3HB1v6zbUMCJ5XRX OdLmxiemRs9Nq3Ze9ymf0puQVhplsbuC79pY9rYuwI+Z9phnw+j3hy/zJFBtxB13xRbv 1rTtisvq6/5U5/IICAE/yCjNhCrY8TyiBsEm05EZw1xHhkrCYMzYiI+za5pcgONY9njS KToSzx3NHOQPJT0JfAgkXtwsWAqttV4Uz+plFbKfMtxysrFHaBAld+Z+Bgk9ZeY6YUfA 8tZgX4ceZ8Mhhqm2h63FvUkzJDK7ePx9yr4qg73vB2smkNtwtJFiVO+UkFQUcTBqzJHI Y5bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780930591; x=1781535391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5XaEoBFZ0wQN7RayZ7ZGkzrqQNmFAZboLFpyYk5DAFk=; b=JHhlBaGMLVIc6ASpzM2KcTjWEcvV8915r5I2NEjyS6lrhHYA9slX9ntHICGMcwgQvX VmTfRHDKOaHkaUlXUdL4zj7PWOZolQk1HIoKKk6Hdr5W1TlSRPVNpZfdXu6EUsrsNFEv cI0aTzppn5bUdFLvMX6bTrbAwe7Gug7hTCxwZAwlkKTwz81uKpeO/kDTA2Zj/a8tw5Vu gJ/2HYvO9zPmYHWlXrbdWWXRQgUILnsEfLAcErcS0gmIatEr4YEqeEp4rBYDSk5jqOSa +06paoTmeqr1ePrSiT+ddMOEj9S8guViRUp1eiFp+7A5cC3zG+rvROfU6S8hbkt/3vyF bhiQ== X-Forwarded-Encrypted: i=1; AFNElJ/5Cqf6HY9hoqgyhZMGJUPA2trAQcBzZNslPyEz4jKu27FJ4n/veStNR1izEE+++FgZnfs163BFLM92EZY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7tgfwuYbTWPoe/D1TJKkHOGWjVhJGFoPf+LbZB6bx6NqNUE6H n2DkhLRQm3jJyqX8kwaEYAToRo7PQSqzvqeA5qLuKm+uxeGMQdfJGYY+GZA+MVhTrL4= X-Gm-Gg: Acq92OEmR/jI7BXvAsdCRvegHPv4EQp4gnv4dGOWeHHS4shm2b5RUZj+I3XUoR/7Xm2 EazM9T5W1WpF8QJXNQ0KcNeoeElC4uFwkg3xXyIKBI2HW9DrDFtDrmd/0/0MXsOD0HQ9TN8Qgmp T/6q8VHyaJJMHi4L26839G3JeO2QLTQyII/4mmHCd+WqKLfwbnPhVB7BTLJdqAwHt2//hMSkDOB 3qSEDvpAQF0RkU73j/H5qDzUsDjUPwEgQDnuYK8pAIeRrk9vLyoFf+YX4TQdY92ZKAyiwVtOpsq JJ4N3ukYsy5o3N2KwLi6ucgM02oYMi43zkDaUmffPMjdlYXGVJg6+MezcGnYFQjBFVVXmPAfr7p uT7p63pSdDqVcHqXe5NMlunPC16Ak2b+DMgNYusDh8YFAt97mKHcU6B3ZbE0a8oE0NiNr7NAHWc BS1ZGkBtLZM49+DfBQzRZpyV9HSkJifIwr284t25cvxpg5XuaoWFdpcNz/iOwBsw== X-Received: by 2002:a05:622a:1648:b0:517:6d75:a2cf with SMTP id d75a77b69052e-51795c5a18fmr245549391cf.43.1780930590664; Mon, 08 Jun 2026 07:56:30 -0700 (PDT) Received: from plex ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775dbd2c9sm158664971cf.23.2026.06.08.07.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 07:56:30 -0700 (PDT) Date: Mon, 8 Jun 2026 14:56:28 +0000 From: Pasha Tatashin To: Mike Rapoport Cc: Pasha Tatashin , linux-kselftest@vger.kernel.org, shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, linux-doc@vger.kernel.org, jasonmiu@google.com, linux-kernel@vger.kernel.org, corbet@lwn.net, ran.xiaokai@zte.com.cn, kexec@lists.infradead.org, pratyush@kernel.org, graf@amazon.com Subject: Re: [RFC v1 1/9] kho: split out radix tree tracker into kho_radix.c Message-ID: References: <20260605033235.717351-1-pasha.tatashin@soleen.com> <20260605033235.717351-2-pasha.tatashin@soleen.com> <178083348873.1648214.11020626647820932506.b4-review@b4> <178085518028.1648214.13339471022594901667.b4-reply@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178085518028.1648214.13339471022594901667.b4-reply@b4> On 06-07 20:59, Mike Rapoport wrote: > On 2026-06-07 16:20:50+00:00, Pasha Tatashin wrote: > > On 06-07 14:58, Mike Rapoport wrote: > > > > > On Fri, 05 Jun 2026 03:32:27 +0000, Pasha Tatashin wrote: > > > > > > It's radix tree data structure implementation, kho memory tracker is it's > > > user. Please rephrase to keep the semantics clear. > > > > Yeap, I will update it. > > > > > I don't see much value in moving kexec_handover.o to a separate line, > > > btw, the same is true for luo_core.o, but it's not important enough to > > > change. > > > > This is purely for consistency. I wanted to use the exact same style in > > the Makefile instead of having two different ways of declaring the > > object lists. > > > > This: > > luo-y := \ > > luo_core.o \ > > luo_file.o \ > > luo_flb.o \ > > luo_session.o > > > > kho-y := \ > > kexec_handover.o \ > > kho_radix.o \ > > kho_block.o \ > > kho_vmalloc.o > > I mean this: > > luo-y := luo_core.o \ > luo_file.o \ > luo_flb.o \ > luo_session.o > > kho-y := kexec_handover.o \ > kho_radix.o \ > kho_block.o \ > kho_vmalloc.o Got it, I thought you were against making the consistent :-) > >