From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59D112D8393 for ; Tue, 9 Jun 2026 01:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780967697; cv=none; b=XmrIlcn6DkXqsW80jyYTYPT7657aO4N7j7NBha9qHripC7kct67elPCXOPOGj5Fk18d1Ey2CJ3f+OY8WZS0WIoY3YHIlSprZAdN2gFE3d56t5AYxy0F3lMOTKVnd/05bjoFT/EdC/iX6bDcVw9Kd8/M9u3TfW1ZjWUstsi/b/RA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780967697; c=relaxed/simple; bh=hj1Fq6LHV1ic5dn6Rszt6KztxqEuzXCQBnDMl++8g+w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XU+DaKHY3ENjZ7E+z3kU5WH/FYNCj5BX1Zcnhywlgq3b/NM6D1LwJrcXorWGGEWepPfPCKngJQVdBMXbW23pQ9izuei8VQ+SepmJOcYB9yhlfrnWZ5A0aWbySp+IHR9SREVnSXqeJYWhDetw9qClJ0auMTLY53VPAVRHdCqZvFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=ESmYwpTY; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="ESmYwpTY" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-9158fbaa4bbso554023285a.1 for ; Mon, 08 Jun 2026 18:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1780967695; x=1781572495; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sgWc+GbcdT1TE4KoGHerpUiSmy6CQo1tAeSFDOuPHPo=; b=ESmYwpTYtqKI9A0/icDX590wO9mqHvjUfxx9LZ8obhtZ/CpgHgTbN2HnIS/rnvISiz cAGLpdVzMNYS4/rOTBQLZg0pDE4oixYrmZ40yLwo7vNDH7/WbYQwlow1wzAjrBdvhc7C eFukaAcjLkpqQGegnPOFQ45j5jnD4EzWi70LrsHEnwMH1CjXTha5ef86neurgPSl2l7K 2vGetYC8q/mv87Gf4QxWtJ/kzLnoMdYvH28tTFvVdEL8D3xcSGWrORKVUrekuRQbNiGK WEFgtru2a8+oKzh9kO6svJT6SZOfItjCoIHaHuXry8V9Qc425BlR2SoPjiQSxqSj8Fmt zLSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780967695; x=1781572495; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sgWc+GbcdT1TE4KoGHerpUiSmy6CQo1tAeSFDOuPHPo=; b=esKa3+Jw/dCaZpUcdy13E1Wzi7QAcm/KaU9ZX9T5Ed6M3uk3uXeMPRpTHX9iqG/Jbu tSVpEupMFHOwhI8IF9GtrmszztQA1O63byZilU49lxeeDD9Fa2FLiUrffelSWTiyTkaC WSwB034PRyLXo544jRzvlZ3OW3t3E2++0dIEYi8s0dXHC8OH0VuYzlca9afrL25JkRiT CiGntdYLMBoN3ZmbFBczPNs/PSm7VyVdfpDut0ds4uepHHuZWx5prEIusieHRlvs/ZFD AzrRMBnL7IYM5EoMBg9wVSkbtBqSHm/+8I8gBpcxe6ihmZeJ7rdgMXwqK7zlmLH0hw/O NuqA== X-Forwarded-Encrypted: i=1; AFNElJ/9dl5o+S7KqH0DAJj8r+csiZMVy1SxvacOwZhnOaSHxeMCY9PuO46UVQCU6GA6gt6ITK5fJy3vkFwUsjU=@vger.kernel.org X-Gm-Message-State: AOJu0YxQMAWFwGsH/JFMTBliMWw87cF3vXMd/tgQzl9ePPSJ8fCIH3rb WaTaHxR9wjtWKJBSJU4rj68VJej7cBv75djoigAGQGd8pyURscd0M/42eTRXMLh0IV8= X-Gm-Gg: Acq92OFkVUh3p0vS9aD/c/h0kZ1G9Mbq1fLx+GDQVJrUteKGO1wHCo45LDq97m3tMe1 4tAh09pPMcfwCgIxr1WIn8hZG5Baw/LHX/CLU7GK3lReVFa23wqUUiDdd+MdoUriObuUw5maiZD EYotTPW76TASI0nfElfcgTrYg1RBF6ftrZRKmEJBUSokyD9BmPJLmvp3ayIV6VqWv+wvfzZslPs V0RdCrVtvd4ChfomR5UeIOhAJx3XdMYcYPbBwYJWBQMkecH4ToTpQFB2Z9GPC4LgIfx59htXmaw VZO5FljGYDMhGXSR78c1ztCcuJEZFsFQTANe4Xm6kiz50cD+kTdrqPTw88KRGTgEDqxY4V724C4 IFWGsbpuVrXvaBP7OMc0/wZDlI32qvYrnEoy2xpU/KwpatB43eLoQk5xkPFWRnDaQMOKiVx/dcM MXVtNiefXgWjxru5PLkrTBG6mfAsX9exFuKHV8h+Adsyb75GY1nhc4+MwIYRXkaQ== X-Received: by 2002:a05:620a:1b8d:b0:914:c0ab:f1ee with SMTP id af79cd13be357-915a9d93f2fmr2862027885a.44.1780967695361; Mon, 08 Jun 2026 18:14:55 -0700 (PDT) Received: from plex ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a009fe7sm1902384885a.8.2026.06.08.18.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 18:14:54 -0700 (PDT) Date: Tue, 9 Jun 2026 01:14:53 +0000 From: Pasha Tatashin To: Mike Rapoport Cc: Pasha Tatashin , linux-kselftest@vger.kernel.org, shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, linux-doc@vger.kernel.org, jasonmiu@google.com, linux-kernel@vger.kernel.org, corbet@lwn.net, ran.xiaokai@zte.com.cn, kexec@lists.infradead.org, pratyush@kernel.org, graf@amazon.com Subject: Re: [RFC v1 0/9] kho: granular compatibility and header decoupling Message-ID: References: <20260605033235.717351-1-pasha.tatashin@soleen.com> <178083348872.1648214.17778188633648887952.b4-review@b4> <178091437240.1648214.10761111570005003901.b4-reply@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 06-08 21:11, Mike Rapoport wrote: > On Mon, Jun 08, 2026 at 04:12:56PM +0000, Pasha Tatashin wrote: > > On 06-08 13:26, Mike Rapoport wrote: > > > On 2026-06-07 13:43:09+00:00, Pasha Tatashin wrote: > > > > Keeping all of that in a single KHO file is the wrong approach and goes > > against how other logically separated subsystems in Linux are organized > > (e.g., mm/vmap.c, mm/vmalloc.c, etc.). Yes, there are some messier > > places in the kernel as well, but keeping this in its own dedicated > > kho_vmalloc.c file makes complete sense to me. > > Either I hallucinated or b4 ate a paragraph from my reply ;) > > Regarding the code movement > - splitting radix tree makes perfect sense to me, just the documentation > part needs more care than mechanical move Agreed. I'll also pay closer attention to the documentation. > - I'm fine with abi/vmalloc.h, presuming KHOSER_PTR() is not part of it Yes, I will move KHOSER_PTR() to the shared compat.h in v2 so it's not tied to vmalloc. > - I can live with kho_vmalloc.c although I still consider it unnecessary > churn Appreciate it. > - I'm against moving vmalloc APIs from kexec_handover.h because they are > very close in nature to folio and pages. I don't see core KHO as > responsible for preserving physically contiguous ranges but rather as > preserving allocations. Not sure we'll ever support kmalloc(), but still. That is a very reasonable compromise. I am fine with keeping the consumer-facing function declarations in kexec_handover.h so they remain grouped with folios and pages. > > However, overall enforcing the use of KHOSER is unrelated to this work. > > I have my own thoughts on this, and perhaps with proper versioning, > > using KHOSER_PTR everywhere would be appropriate, but let's keep that as > > a separate work. > > This is a separate work, indeed. But regardless of the versioning it's > already better than plain u64 because it provides type safety. Agreed. Thanks! Pasha