From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 960A82BEFE8 for ; Tue, 9 Jun 2026 05:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780982780; cv=none; b=UdeRC0guVQnlnskU6T2a1nIFIUx6zHBpeYXAjckaE08zEbT7vRs/cVKOR8CD1iMs/AsgtGXkI9Sd/42wqauBZmz+TfHB3+cL07sHcQ3mVZfvAGJ0rIvvt+7AZ4xCgLXBvjgvDY8uZp8Rq/7FnuJ+GgRxVaSCC7x5ZLJ1bD5lJWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780982780; c=relaxed/simple; bh=EFHHBUqZkulkW283cRClEdU8zex39fRkCXIVj4vCFfw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RLal8xMa5JqG1OQWvvzOMK2s+D5tvAeO2O/2AHKFhdx1A9OaHDQiEx3RgOcmnW0QtZMLMJItltsWxwPU7skmxJ6dCGpxrfB6uP4+4FzG3VXoRgJDIQagxxtV50A8AGvbLViKpJaulC4o/Sv1e4kI67ddlGoUPDdhplKYUvNwuVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PiTc0b+C; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PiTc0b+C" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-135e7f4a295so2948467c88.0 for ; Mon, 08 Jun 2026 22:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780982779; x=1781587579; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DVQFitMULzV0jlKXU2oLkFHPkf/TQ1MszSxTz/FIHNM=; b=PiTc0b+CZyRB8Yltm7+BJgpMaIj4dNlOAWxYCrRZIxIG3R6sVew4THnLw7/iyXHlfC O1Puf2qROlJkidkHeSUnmSJxT83oLYuAqWUBj/CCfTgJSsKKNZy5GAKyvarO9n+t8mXH yz2H0bcpTxmdhxXZkp8sCV/0CW4sQtcIS14plCoF04m0ltdSy7ZslKVjgKEc+YINy6PA BrnmjuhOx6uxvkL8dcMRDB2TfpZmT6/CECIut5Gfi/wZXsadhdsbtjGPjc95SMEe0EoQ ACW30jwMHigyeTQGsgtdPsj8gPQHFrfzVnLiMLRG9jAdf7nrU6KnDt1LQ2DEnXh6B7A9 hpEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780982779; x=1781587579; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DVQFitMULzV0jlKXU2oLkFHPkf/TQ1MszSxTz/FIHNM=; b=tYh+3hBZrhgtqwpaN28hXdFfBj76HO1B/zpZQVko5KrbIJXTEMC2XS5+8CdGng/YVA ggcaRGD8F6KKcyz3I16ubSLVW6nqKTdWGG5MmHMke6/prgRXo6yUy2vkWJeg2hlBOWER S+yasdXd1ZPR5v6+RpKN78TJzvpYjo31OMQ4SafDYwLfTPTMbi1aqGe2rXTw2Zn7RWsr /JoXgyt1SSyg1KjnBbVu2v9BH0laLfcYgnA606u62Rl6MaG4Gi6UxFhvQ0TRgL25/CVD 8kOg6OUL5WUjQt2YJ/e6S8PIaLvD841MTImQ4HeoAWQHQW0HZV1LT6kWfP5VoiR/dvAP X6EA== X-Forwarded-Encrypted: i=1; AFNElJ/7agsU3I50xOOBLIHFKK00Bzewu45ErCARIBiwlloDG7/hfj+nQyIBxMgDo8Z6XoQotkgWOEtogXSbbow=@vger.kernel.org X-Gm-Message-State: AOJu0YwtOyBw2mkvgeifPoV9CwNeU/YJ7wG0bqeAOtt5+mHP19c4luiZ T+rK3Fwd3M+zfptXa8zxA+nlNue5hAUoGgxdrlReh4kxPmtgiPRCIrrY X-Gm-Gg: Acq92OHdF67y2q1uaIwrpsub60P4+0Niy8TMYP2Xe0L8Xbc5W7bRRBaMcMVGH8zzNVm vayMwGzfgX7kX3nCssEaMep27qZNtTYA+NOy+n7FWeqxPzifRENUUmVqweRtNIQr3dsovZn2ol4 FfPei/xOCutVlnttqIBEHYy2jyAnMyhbuiG6MRjnTAvLyrQIEuL88i7tBVRU1N/+BZfSdElfeYv L3RPYuG+FzaZt9eI69GClA2L1Eq/wPFQyvOdvC5vNkNy94CIXHSYhqWUsgu0lrCc1z5iLgjyI1A FyxWIwDoIme0vQOXD1NY9F3fBUgJQYchruoSzwk+KA0rPYMDCFURhfoP7EMxPMJPepnQ1ecdkwJ oUOq2r9AidJ3F+MdMVR0/D0zVknjmvKpJfJy8FrH5ZeGpFv0XdWP0QCrS5SNdW9ApggdQWAvbnM DrArC3TdNJvHWUcEXr30AacyQFHIA9yY3mGfCHCj4252MIYlkqtnPSDLPFEamNrd6Y6qmkWSPGV 1E= X-Received: by 2002:a05:7022:6ba6:b0:136:aebc:24f5 with SMTP id a92af1059eb24-13807d7e4f0mr9024789c88.15.1780982778582; Mon, 08 Jun 2026 22:26:18 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:355d:c69b:fe36:8969]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-137f553ab33sm13728402c88.10.2026.06.08.22.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 22:26:17 -0700 (PDT) Date: Mon, 8 Jun 2026 22:26:14 -0700 From: Dmitry Torokhov To: Rosen Penev Cc: linux-input@vger.kernel.org, open list Subject: Re: [PATCH] input: ipaq-micro-keys: simplify allocation Message-ID: References: <20260608045041.4664-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 08, 2026 at 01:20:36PM -0700, Rosen Penev wrote: > On Mon, Jun 8, 2026 at 9:49 AM Dmitry Torokhov > wrote: > > > > Hi Rosen, > > > > On Sun, Jun 07, 2026 at 09:50:41PM -0700, Rosen Penev wrote: > > > Use a flexible array member to have a single allocation. > > > > Why does it have to be flexible? The size is known. > From a quick glance, that would be a compilation error. micro_keycodes > gets declared after ipaq_micro_keys We could swap them around, no big deal. > > From looking at a bunch of struct definitions, [ARRAY_SIZE(foo)] seems > to be atypical. There are a lot of "#define BLAH_SIZE ARRAY_SIZE(blah)" that later used in array definitions. Thanks. -- Dmitry