From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 387DC47F2C7 for ; Tue, 9 Jun 2026 15:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017952; cv=none; b=IPOoBLF+Hl45rmRUTuCIJG6dWqgnfLJoCn03OnKDZQyTzid0LitYmKMUQpjjdduZ0RLiJAAJ9j6zCVYN3qE+KB+HX0gi3MeBT7FLVcIYs+zhW5Ff546vP1ASAey+efwK8fbRic9CXqkgDomNpi8/SSWaEilhgfeNWHGld1V7DYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781017952; c=relaxed/simple; bh=MOv3SenVOIJ+2PjxGXILrvwas4FLe9X40rnIUrUcvII=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sifAsXcEAvVRgEuL09+cwaxhy66Jx1qyqCoWju6ogXgV4mvdJ4sk5IDBjl7dYQYq5HO4vUyyLWYOIjf9OaZ2LfxxKq2aNlAtop/sLNXABrETENeJLUpfei+CBSAVd3bYukEclJOsx0ls5ivD7pncOdQ4k/EMMLFW6cWpQ3qkO7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nSOyieyy; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nSOyieyy" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf2d865383so465385ad.1 for ; Tue, 09 Jun 2026 08:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781017941; x=1781622741; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w6VKUC1VUaetCGs5JJDLFKtb8dO63YSohjJ7JwyYLsY=; b=nSOyieyy7gRAiOb1Sr15URcEnYbX/IJlRn+9J6IdwjEGuJP8lpNB/VuYuYpCv8jNYE N7V0GDbvG3BQu5WqqAi44/yguvsMXGySTY6Ay9Ff7bsJicG6r9a+ssI6n7m0HxdDtalG zDyGzV0WFa0yG+mhG8cOEjXntHkRwAGnvJL8FX44XjFxV3QwzT9ug+xcKf6OF621teBq ic8HjbVO2fdTKi2Gg5KgJ3MDZD4dG2SnOl1m/fdGQ3Ag3FcD/G7Gd9+k5jwQ2lGMe1Y1 ZUXLWbMoWl6ZpwMYASbEjkV2KwapmuOv9QsmQ29xhQDagMfYj74OIEGi1v7znETpSOxJ 347Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781017941; x=1781622741; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w6VKUC1VUaetCGs5JJDLFKtb8dO63YSohjJ7JwyYLsY=; b=JRN8p0nC723ZDw/9t1cIBCcvTqdZCIOheLJWlYlF5WK+mk5rPx2pR7KE4Jr7XySrY8 Ytvy3X/5YwoAUbtWsRvQ42QfgRF2b02npW7fptbvI5d2hTD+Qanwx2shIUkHW8p/zY+u 4/JhoTT+wbKXEh68CHVoLL+OMBCCNGO32OuDw7im+AYHRu1yeMx1y8hI4WOo0ZIXJkFg R6YSK5v7ANcdXxQnMBlPe8b88xbIdMJQXBqlQCLN7ezqphLotshQlhe5jXjdEmEAjIpT KBLZJlrWKzU/iHAFKPEARjaNHv9+0D4g0xccqsPcAi4krpIeav/2v5HYBM/f1sQsIAJP UcAw== X-Forwarded-Encrypted: i=1; AFNElJ+l5nZWySnX4bE+4ZQoRELK+E1WbF6IpPrJlu8JPRJxfBwMdiaWdpumvnTI2UThQXyALO7wNOD23JI+eeM=@vger.kernel.org X-Gm-Message-State: AOJu0YxpJC0eEw1dcCpAfrUfq7xaWcRclJP7GcNHtiLRVPNtqJN3Tna/ YaODmfOkmt/SjtHqnRAspVSMDMYFqTyOJrudQxTVGQ2N2Qhqn7iokQUigZy4Hj8iWw== X-Gm-Gg: Acq92OErnWNRpJg6JsEsUggnkUqoMmsCMji2xn9uqSF/7ZUsROR16dKNVpl0ymzYYo5 kuDYbFCoxkn0JtQw0tdZv5PnNrkFwbMHJ2DorUN1rYaSILWUUKPutT2RSXvtyc1QxlBjJmyxKTS N3KobIeR0xAxtF1FfKgyPZssoHJ+WBxEEALNBqtULOljUv3XHvwim/JyLRhXSc6rrMMFclAJO7m aWfEDCuVFCOZX2HhKKEZqtXK9FyslNpNTYZ5x1fxt5DU/Fo61fa09okQ+b2Wq+4f1+r63EjE2o/ PyjF5o5YPvZzS/Ta/wTYUCc8KEzDeoBgqt1qaGBWjKqgZnfsszMuojoYoRcdVSRASWo0wixpnKJ j7/cQdeB5zw4qTGtPaLEaOeaCcMyGhKAUnJqla4Ia+9Rn3kqsDzm7ocGrdFXmVyj3e+KoPfmVHa MghOZntsXk6EHjTRCu914XCRWakmxr/eSgh4wC2pR9TNji1UhkiJ+4js/kBTKScSJ6JnwgepE= X-Received: by 2002:a17:903:19ed:b0:2bf:3579:cdaa with SMTP id d9443c01a7336-2c1eb942782mr7408845ad.10.1781017940616; Tue, 09 Jun 2026 08:12:20 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d40asm208599735ad.64.2026.06.09.08.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 08:12:20 -0700 (PDT) Date: Tue, 9 Jun 2026 15:12:11 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: David Matlack , kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , William Tu , Yi Liu Subject: Re: [PATCH v6 08/12] PCI: liveupdate: Inherit ACS flags in incoming preserved devices Message-ID: References: <20260522202410.3104264-1-dmatlack@google.com> <20260522202410.3104264-9-dmatlack@google.com> <20260608181640.GO1962447@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608181640.GO1962447@nvidia.com> On Mon, Jun 08, 2026 at 03:16:40PM -0300, Jason Gunthorpe wrote: > On Mon, Jun 08, 2026 at 10:49:29AM +0000, Pranjal Shrivastava wrote: > > > My point was that a FW exploit can meddle with the bitfields of the > > ACS_CTRL to spoof and mis-report the ACS flags. > > Devices can also ignore the ACS flags. I don't think this is an area > where we should be worrying about devices being actively hostile. I'm wondering what happens if we preserve IOMMU groups across a kexec, but a switch's ACS capability is dropped or the ACS_RR bit gets cleared? The incoming kernel assumes that it's the same ACS cap from the old one Now, the incoming kernel restores the groups assuming they're still isolated, but the hardware no longer enforces it, silently allowing DMAs & breaking isolation? Thanks, Praan