From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 774604921B1 for ; Tue, 9 Jun 2026 15:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781019179; cv=none; b=C0Xx5ddpGF4sQb5PrD3jUOMpr6uSOSOyjWL/RiXv9hpYh/edvzYMqTuNzzy72OumydmMVz4RDzYkHvCD+2f0CPjw9W64VAw2iiRbPV1ytrk4ip3qWjYToBhZrzcvYHj3Gbumlcoy6I0zqyBQjjhps/I23HW6zHffO5lZ+6Q0/pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781019179; c=relaxed/simple; bh=vVdHb6+hpKLTe+enppNEziiwGydT2kR1O+SM0K7lsWE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mbGzw/m50mqC3R7Vq9JCCz84+krTyobb77OizaTqYBk152ewWSPlHU8qA7BsY79y+0EneDQnLR9/M4EvIkm7EGVvKkT/O4lSzSKUMk3VMy4ZLm0fvHBfRx7csH1rUC15BIw2nulDxEtpZcSq3zsoiT477PG7ocD24XURfmNkoj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XV0R+AFS; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XV0R+AFS" Date: Tue, 9 Jun 2026 17:32:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1781019175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TaTj+lL1/sLB9vh2N3Yje4A4D+jsn0JUHh7xHT9g1ow=; b=XV0R+AFSxl+bUVwvK4/9gQnKjsYqjbr5iQuzOfcV//s7JWi/iKDswW7T4OKfj2EZbDQx+P UEvN7XqIBHUCvdg6yeSLor9msU1argMztB5T9aj4bNzYm+O4y1RVFvqqnzJD3/boZOAV9t 4GkAHFhuSx4/39Z3cZB/Rs/3/UL3ALo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Dave Hansen Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/mm: Consolidate SME comments and use break Message-ID: References: <20260609113016.296259-2-thorsten.blum@linux.dev> <26e29657-1e41-4f88-b2f6-8111a3b6e6ff@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26e29657-1e41-4f88-b2f6-8111a3b6e6ff@intel.com> X-Migadu-Flow: FLOW_OUT On Tue, Jun 09, 2026 at 07:23:14AM -0700, Dave Hansen wrote: > On 6/9/26 04:30, Thorsten Blum wrote: > > Combine the two SME comments and use break instead of return to exit the > > switch consistently with the other cases. > > Hey Thorsten, > > While this arguably makes the code a wee bit more consistent, it does it > at the cost of churn. Churn can introduce bugs. It creates conflicts > with other work and it muddies the git history. I don't think the > risk/return on this kind of thing is worth it. > > Also, for pure cleanups, I'd personally appreciate seeing them > concentrated really close after -rc1. I initially just wanted to fix the broken indentation/formatting here: if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) { /* * SME is mutually exclusive with any of the SEV * features below. */ pr_cont(" SME\n"); return; } And then decided to combine both comments and replace return with break while at it. Happy to resend it early next cycle unless you prefer that I drop it. Thanks, Thorsten