From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDD6A213E9C for ; Wed, 10 Jun 2026 08:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781081524; cv=none; b=nwEUL6DSuW4kfx8dX+mMlkovqkEncY24UvMhBauZ3+a+UHsx8wxcXKgT5fD1e0afrNmJzs+jnwrbw+ys2vZj6GOfOVAtIZdQ55fk4nQpyQpQTMZh9Yf2BQiQkLHt5e+useHClJ7c5ysuE6B56YXo9DN3RQTBkKd8EpVuO6dRIxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781081524; c=relaxed/simple; bh=xacY7bSKC3x0+lJqPd5MYeCu8HWXilL7GjU7vsfpDS8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tlZmb2iZTDPrVHcpgNiL1kHQbnGjDXl0dSvROujxG7QUBa3bDpEIOWHzDAlHmvEpRtxwoq10bBdWMlnPbRxDLYbcObyNXN8IOBkfF599cYg3VgwE6cKQv6vddLbDHIXOV+RqGht6zELEohGcBdl98emjhq3jnkTDHWkvItKDaxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lFaqXxn8; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lFaqXxn8" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-bec450b950dso950033666b.2 for ; Wed, 10 Jun 2026 01:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781081520; x=1781686320; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lcrtc5H86cWPh0Did9l6A+KNce8iS/2PQzso7zvGK7g=; b=lFaqXxn8i0OIx5u8R4SKRcwO6CVNQNTgavFwxJZ5AC2+nhQY6MJO0CvXkIsrs6dpOu IGte2l4b3H//aPFkiVqpnduwO9UBs95mM/Hob63yhSdT0pn5uxxFinJWbqKyh1SUjDN7 f+sjCIFVEtGEx+10kldletFTaLcY1+fArab2C1mwVY2S4ZxojHmK/UJ0EXidE8/r5oJZ 1JAglIDAlPYuHXABbHpT+dYiQdkW7ZL7V4gLKDCoMFQIKudK0v1KoVjFV7xMqzXGCi9B 0kWWmUZAHzLFMboYatSMeGMMPa4DuXyGuPr9sNC3CWqUyCq1qTho2Dkujp6df3Akz8XD xsZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781081520; x=1781686320; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lcrtc5H86cWPh0Did9l6A+KNce8iS/2PQzso7zvGK7g=; b=Ai2Vb2rlpn7KeKER3cXN1aUXEht+RMmy1AKIPCepmkLj2dM/FZ143QJPyEAOLbk+Pa LEQhmBeN7zp8hRnrG6Ae0NdmY0MdMYM50zISlEajW1/lj7jbL+ux9VqU0ChZkjSefikh 4wFI3RnJ3qyWJ4qZPks6q31g7lb51B9eDwfRbo/cVUeFAnE2dx8NN8XxHaW9P20XpTMs 4xJzGS7LBKZBEigR6pdQrJQFdN9lcM8cPDNgBpcrDiPI5L5NlGIny2uabDuR7+tnAx8p xYLOm26ZmUY44v3V29GfQ8ZOeIVtjhjEHMcxAqnncV7mo7kSWH5o/NvZ20jniYlqQg3+ snnA== X-Forwarded-Encrypted: i=1; AFNElJ+4sdmS2piF7h2L1PC1ttzedF7Ghxk/1cHcIFBjHatp1+19gj9swixkYQ4CgbCu96JP9DNvAhapVg21LD0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0ccUM8egok95RnxUQ8OHFBnAG3hm4P+nsikCSby6399+WHGip hARdgIXmra5M2eFQvGvQmTjUODOatlMjM0t0S6AY35aTUBeIsJ91dc6Y2ogXMWLukg== X-Gm-Gg: Acq92OHmN9J78qIxr0RFTCn3Rwrxa9Mk0YqKEOB+KYIaeqFTB/DsIMNVLUmi5sPSxxv gCEfy6EieZ7TgePpyUmcFViFJPkRy56KjaF3sZn14BiqZT7f1KrWEpCfD/LfZkpoiKZMkZlKSGL pXit3yxJGazulqDFIQbT810XVl4mscBMsQCF2VgaFrZh54MuGuMsrtFab5Jogi+pAKRlspMh2A0 96Uip3FaUgn16Yw2UO2Xo/v9syRI1ZKslDrKqI3cgS/B1usm+fWkUUBt8MP6jVlJxs9GAnj5to2 vXJT020FtF47O3hhuJEO0jw96jCjxMKC8VaucmfTOyf7JIrzRIDvbeLB5CC7pZ335V9i1untkR/ MS07E7NtfdoPx9bs9lcOZXqOXD4Y1ue10/jW/edtxapx0cxt8j79DSJ+/xwNUWZtQ9Pav2TetFV XbWUeSkk6dZscE5JbDS/UzHwuOJCBsahRchi76NsoJ9D1rtTu/SaQHTpmQnj9A5uvEIjR3+5R1p SyPiA== X-Received: by 2002:a17:907:6e94:b0:bf0:550:d9f with SMTP id a640c23a62f3a-bf372159fe1mr1255552166b.31.1781081519868; Wed, 10 Jun 2026 01:51:59 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e6585154dsm9549446a12.15.2026.06.10.01.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 01:51:59 -0700 (PDT) Date: Wed, 10 Jun 2026 09:51:55 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v2 1/7] KVM: arm64: Support FFA_NOTIFICATION_BITMAP_CREATE in host handler Message-ID: References: <20260608165549.1479409-1-sebastianene@google.com> <20260608165549.1479409-2-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608165549.1479409-2-sebastianene@google.com> Hi Seb, On Mon, Jun 08, 2026 at 04:55:43PM +0000, Sebastian Ene wrote: > Allow FF-A notification bitmap creation messages to be forwarded to > Trustzone from the host and introduce a helper to check for SBZ > register fields. > > Signed-off-by: Sebastian Ene > --- > arch/arm64/kvm/hyp/nvhe/ffa.c | 36 ++++++++++++++++++++++++++++++++++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > index 1af722771178..c20d45191085 100644 > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > @@ -71,6 +71,18 @@ static u32 hyp_ffa_version; > static bool has_version_negotiated; > static hyp_spinlock_t version_lock; > > +static bool ffa_check_unused_args_sbz(struct kvm_cpu_context *ctxt, int first_reg) > +{ > + int reg; > + > + for (reg = first_reg; reg < 17; reg++) { The upper limit should probably be something like ARRAY_SIZE(ctx->regs.regs) - first_reg? > + if (cpu_reg(ctxt, reg)) > + return true; > + } > + > + return false; > +} > + > static void ffa_to_smccc_error(struct arm_smccc_1_2_regs *res, u64 ffa_errno) > { > *res = (struct arm_smccc_1_2_regs) { > @@ -676,7 +688,6 @@ static bool ffa_call_supported(u64 func_id) > case FFA_MEM_DONATE: > case FFA_MEM_RETRIEVE_REQ: > /* Optional notification interfaces added in FF-A 1.1 */ > - case FFA_NOTIFICATION_BITMAP_CREATE: > case FFA_NOTIFICATION_BITMAP_DESTROY: > case FFA_NOTIFICATION_BIND: > case FFA_NOTIFICATION_UNBIND: > @@ -862,6 +873,26 @@ static void do_ffa_part_get(struct arm_smccc_1_2_regs *res, > hyp_spin_unlock(&host_buffers.lock); > } > > +static void do_ffa_notif_bitmap_create(struct arm_smccc_1_2_regs *res, > + struct kvm_cpu_context *ctxt) > +{ > + DECLARE_REG(u32, vmid, ctxt, 1); > + struct arm_smccc_1_2_regs *args; > + > + if (ffa_check_unused_args_sbz(ctxt, 3)) { Is that expected we start at 3 but only read 0 and 1? > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + if (vmid != HOST_FFA_ID) { > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + args = (void *)&ctxt->regs.regs[0]; > + arm_smccc_1_2_smc(args, res); Should be hyp_smccc_1_2_smc() > +} > + > bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > { > struct arm_smccc_1_2_regs res; > @@ -920,6 +951,9 @@ bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > case FFA_PARTITION_INFO_GET: > do_ffa_part_get(&res, host_ctxt); > goto out_handled; > + case FFA_NOTIFICATION_BITMAP_CREATE: > + do_ffa_notif_bitmap_create(&res, host_ctxt); > + goto out_handled; > } > > if (ffa_call_supported(func_id)) > -- > 2.54.0.1064.gd145956f57-goog >