From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EDBF2FE05C
	for <linux-kernel@vger.kernel.org>; Wed, 10 Jun 2026 16:47:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781110023; cv=none; b=u0B6G33xTjY37V+v0OyI8SAL0CLgnITTYR1o5SV9XUD7ItLrL4cDk66WivLVamHirtkYuiZnEuzmOUO0b4k7a6fVCNdLUi121AI0dcGpJUgQvJadePa2vX5mgemqcHcnzuZBTVTF2w55iYh/jt0JdUG+zDSDmGboWN7JQf91r3U=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781110023; c=relaxed/simple;
	bh=EHlNNbgX7y+jL41srViD5jpaZzL6Mq1vHt1s60R4Hwc=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=efVKvclJJuxRWwklRGnrfQiBvU5v9GPb+UU41X6UwmmJ8brFawvftvm4PBzGHn5vh2l8M9mEam1yTFlUVhff/vrJgdM+sxpvFBa3eruDJpYCmSpQE/NN51cMQM0iK1rIbIcJeymb1dqD3wE77piy0Kk1Kr4Ww38CfjsB640Q8H0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I8wUz5dj; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I8wUz5dj"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 946831F00898;
	Wed, 10 Jun 2026 16:47:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1781110022;
	bh=EHlNNbgX7y+jL41srViD5jpaZzL6Mq1vHt1s60R4Hwc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=I8wUz5djguyNY0E6IVKk3DcQL4eywHHqUgVsQWKjR3i7XDMGcDYvsTpjkTud/ysU/
	 Nb7rrRjGd0f0zY6ExhsDQ9dU+2UcTDKnPqmtAvkn2G3FzWDJgFW0DhbqslrMk81C6c
	 FuMjReoZvf39Eia3RoeoTI8j6D5CGrcezML3B4zlK8dtwoNg1BjmVPb/Cyc7OzpT4x
	 bquyfx9anTgckbtz0G6iY4CD4+bh0rZTttTuzdm+QCiyDjX1FNHyqLf1fIaloLgMFc
	 q6Wnjd3n2hPytZa63NNl05RQPAn/dXA11G7kfMYK2IZ1rKL7fe58/ompkH1PNXNX96
	 WzzRGFm+fAfbg==
Date: Wed, 10 Jun 2026 10:46:59 -0600
From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	hch@lst.de, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org,
	elver@google.com, gjoyce@linux.ibm.com
Subject: Re: [PATCH 12/15] nvme: add Clang context annotations for
 nvme_queue::cq_poll_lock
Message-ID: <aimVA51B7z4dsMja@kbusch-mbp>
References: <20260610142743.115898-1-nilay@linux.ibm.com>
 <20260610142743.115898-13-nilay@linux.ibm.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260610142743.115898-13-nilay@linux.ibm.com>

On Wed, Jun 10, 2026 at 07:57:32PM +0530, Nilay Shroff wrote:
> Fix the warning by acquiring nvme_queue::cq_poll_lock before invoking
> nvme_cqe_pending() in nvme_poll().

The check outside the lock was done on purpose, though.