From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6797334402B for ; Wed, 10 Jun 2026 16:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110514; cv=none; b=VHrqMB4zJa9NbB419k1l0cGSXNQ2FMHOFWYHSfVvvxBkxvqk1HA77G6iP1nua2x4h1XOdZ+5IZmTeJd6LRcNHtnzPzXlbrUeUdix9cVpZ+rCdMsjsJU2KDrSZL4lze5F/wGYePozaJXnGgvBBHa6NqgPrrCqzFKUMajohml9kaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110514; c=relaxed/simple; bh=Hk3r5GhcXgLdVr2P38hzuKv670yr4eRz8wtw8OMK83s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t09+VTAbYpqWbwCuadghokuj0t4AMYyhT1Jo7XTuP64Q90tC25VfjTLzdFBiVtwkm1pLRfJ1XJ+4yMDkH2hLgHD708+asH9H0E2IIIhVmPxISinQ15xOKUWVRvkAiYtVxfoIKi9K1ZSIf/TLrR0ws5KJjrhSMtzLi44e2AFRr/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=kEbHURpq; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="kEbHURpq" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso58868295e9.1 for ; Wed, 10 Jun 2026 09:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781110510; x=1781715310; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hk3r5GhcXgLdVr2P38hzuKv670yr4eRz8wtw8OMK83s=; b=kEbHURpqJnFdEkOuhULmJowzGihJzkJbT6NSiK2uMMpuhIW7jEhpp41pZfNnY9vyrh OQDQ6WonD4Lz20Su0zsqwO0GxKNXq8ly2ccj18baE1obZLuJg0p0mGr6RPeaoZojMu5L rZIGMb8jefzfMd5NCCQ/MFlkDFP1XIwHfl1wP78gwfI+92KMvRVmc7UOEqbMWkvn3TvB jqzuQvrSb5/4l8hwGnjoqBefyg2x79qZiEukrWIsgddV4BuGpC5QEgxzLtC2Thv/2rTi voU3dIxBNkMqbThT5Xicyl9loKdfrPzvhZygOjjpKIi9++uLFGhcBu3T4lB7s4DP4Wgh Be+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781110510; x=1781715310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hk3r5GhcXgLdVr2P38hzuKv670yr4eRz8wtw8OMK83s=; b=qHuQ3/vBmH9RNCbSN8bS8cy+waJEZ8ZykRuGAOz7vXihnYjzIXy8u8L8ylkko5iAR0 yZ6h+f5iliIawjcupxeu/R51fU4jLc4oIWmpnCCZX0SdMIT3TBehHWjrNTE4jsLgSqBe TneRLxlN0lnX8nzstXd34E8nf9jX9+BianeSwgrYq+8lVxz4hDMgL2i1K/FU846PgrzD sC9sk/0To+LYoZ9yMTWCgyMooWngDRNwFACGNHkin72pyLAgae/4YD2wvkO1UMcqst0g 3lN8y+qVBaKRFz5pHtLMlffoVDnXgP3f4C165iZVY7kgu2UbIH6Dal/ScpMDD+dHxwEx WkJw== X-Forwarded-Encrypted: i=1; AFNElJ+kWUERqKdzGB9hlecZ13LDbqe04omShzXeB1pb02pxO4BKwKjg50GNsAf/vRujooVYHAJkYCtSgv1kJdo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1cMDbGjIV4I32HXBPl4UUEEZyOpGiCE6Ni+sEEOhULM+zLz9v T4vjby5WpDy6EZNlhVewHrbap9tOxVvyMIjbY8fxOtPufBtRtg2NZ+VuDK4PrtkEniwq84ctSp8 dLA8f X-Gm-Gg: Acq92OHomd5zkbXSmL4I5lKBKjOcu319PXhdK2xOzKbl3SS00bazQqVW+QF70PxfCp4 zYmu22QahBzgLj08B8ZHVWaXcKnxwYURIWlIPgaDb1LaPmFiuT4NtoxYvOxskkm9sBQDN+PE6SB d7cHIoRpyafoxzCykjBY02hEoD9BQpIrqrI6E0cvDxn0iG0KcuA8tNghp5H6nAEjIx6uMwX4j+n vrSUipVTrtlkGplHCnZiStsUptmB8bmUv2S/TT0WnSLGuhWfbYWqozU2hsITcE6AXDlOlZPH8VF y6DHCpVjwd6DsGP/ZYh53ppBtn18wMc7k9ZPlpd3u+lsaA+ju19f+XPImu5g35fJR57fMr3Eo4q b07UnCXHS1o81L+ZiBMqS7X0sMx4RoULFkPkPlS3+58WZ89AW9mi/mqA61UcoFV1G3RtZoNi5DG 73ryTO80ShP7Vl5jncFoMWQQDXTxfJ7IdNJFJt/91VgoIhlyQ7YSzBdTVO0tTD1+5VM792RQBmk 0dGM6yB5fmEOCcNHkSCZIhND5pLcTNeUw4g X-Received: by 2002:a05:600c:4e0b:b0:490:9bc2:bf8b with SMTP id 5b1f17b1804b1-490d71ed39fmr101101355e9.5.1781110509773; Wed, 10 Jun 2026 09:55:09 -0700 (PDT) Received: from localhost (p200300f65f47db046aec8c3a4b621e71.dip0.t-ipconnect.de. [2003:f6:5f47:db04:6aec:8c3a:4b62:1e71]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-490e284bae4sm2171525e9.5.2026.06.10.09.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 09:55:08 -0700 (PDT) Date: Wed, 10 Jun 2026 18:55:07 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= Cc: Markus Schneider-Pargmann , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/amdgpu: Consistently define pci_device_ids using named initializers Message-ID: References: <20260429171644.8406-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r2bfywcea7kmegy3" Content-Disposition: inline In-Reply-To: <20260429171644.8406-2-u.kleine-koenig@baylibre.com> --r2bfywcea7kmegy3 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm/amdgpu: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello, On Wed, Apr 29, 2026 at 07:16:44PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > ... and PCI device helpers. >=20 > The struct pci_device_id array of supported device was initialized > by list expressions. This isn't easily readable if you're not into PCI. >=20 > Use PCI_DEVICE* helper macros and named initializers which is more > explicit and thus easier to parse. Also skip explicit assignments of 0 > (which the compiler then takes care of). >=20 > The secret plan is to make struct pci_device_id::driver_data an > anonymous union (similar to > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre= =2Ecom/) > and that requires named initializers. But it's also a nice cleanup on > its own. >=20 > This change doesn't introduce changes to the compiled pci_device_id > array. Tested on x86 and arm64. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) Gentil ping! I'd like to work on changing pci_device_id, but that requires that this patch hits mainline first ... Thanks for considering it Uwe --r2bfywcea7kmegy3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoplucACgkQj4D7WH0S /k5G4gf+K+Bth6+S4Oo8ga07nkWVOMnNU7IxWEU6lQBaBaSjdUxnVgxDI0k6c6Ts sS/tzHaBkdPt7ob/NfWvaHFQ0MlMaJ7BmAOXj+dXkAwY8UOBE4ezbPZT8F79tMw/ ptRDfKanfdEGc46Ky4+KXZmmbncZMtetsrY7yk9qhNdNySXchxEJhkW7kzLMSC5A f0vYuIBYnrNWo3gyUFQqU/hdSy9tyujE+dceY06cFfbo6qagWgi87hBQOLWlwY1D vpk6x9qdvXGus6l4x0TrJ9UBafO/KSnEdqH8SQRmFWntE8V/spEmtsGH/E9JXIZq EX6CXFepKvu5BNJAHETHktgKqmxeCA== =VWoE -----END PGP SIGNATURE----- --r2bfywcea7kmegy3--