From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC1C175A9C for ; Wed, 10 Jun 2026 16:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110598; cv=none; b=WyR6PY/2x5Suul6Qnp6MjJ7SnF2RloKpSLPOw9CLG3gmz44HXvAIBVGpf9njIKMLeviec3V03V+fErDg/PDoGAX85vWRgDNMUxTPSobheEioHBkZu03gnodrjLrfZ2anG82eUkOUtqE5s2FgoSdbtq0klWrPWimwT4+zghiGvKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110598; c=relaxed/simple; bh=wDGhghAvzNX5ObVecH4+CcJJHr84yhCjxW5gZJDsxQE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dkXD4ddySCffh0bKDv6Ec8L51t1FzrzNL9IGxjSP0FSxt5E/u83xaQp8Zp1Mc2da9SZ+CFfN/oEMlTcWRGNnbbXmtE0thpHI0uQZN4ZmQNniz4Bsh6dnM2tYx55nPCDq08KVVfouIO4hzmf5EIYtEgHM+ekYr8iI/ohj+PU94UA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=ZNQINjES; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="ZNQINjES" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4905529b933so75223605e9.0 for ; Wed, 10 Jun 2026 09:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781110595; x=1781715395; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wDGhghAvzNX5ObVecH4+CcJJHr84yhCjxW5gZJDsxQE=; b=ZNQINjESxKfmTTRgVOqP+yziT1J139u2YtpVboPmGW7vJqjVck+ehDV3zNRTUzk2rI iqUXRnVQ6FnsmsCDKbxhCPK3LmprcXJk37IoSs2GRyf8rV/Zgzm2p0E8r8oDqxnnhRRh BxphRvuWPkPe5cybas3WLpng/zqi4nw0QREOjQUdZ9hfZql0m2gtDc1kGIME7e/PSrs5 FU+3/FhLJgxzk5YVQL5yN2SkDZ5uru5/RRzbsmnGO9bc8A0k/cAydQjhK7Zpm/H17WnO 9KeF6OrchgPaduMDNtnSvNRaUc00SzyYh5OkYGMPRNqnn1W3yJYPfLN18OosjUMa+ahQ d5nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781110595; x=1781715395; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wDGhghAvzNX5ObVecH4+CcJJHr84yhCjxW5gZJDsxQE=; b=ZOtw+7t9NNCNLwEeeGdsHSX4JEs2rWbnCOCrQW863yx1Z5u/mSymUJAL5hmTqq/FBH N+4RClx5JztRGsInISZ+Dfo8goVyrIT5M2u56GTSgptaxMbWU0qgcfu6vy7fDF8RhaEb SVjy/nSsOBfWUYXMMrb2tojyGws+UakkpbeF8fBCogP50PR7lniQEfK56ATDSTHc/VY2 e2p1MqHEFDPck3pZvxW+C8MS4Bmbec2nMt9ccpXFkYOMbXZWR5UX2odrEN2S3D3jUFms nUzONLuSu5j5cln81sJv81Kjz6RewgAui4DEiM4rl3redbUgf2nPaV5JUIpB012jYeUA ILwg== X-Forwarded-Encrypted: i=1; AFNElJ8gq0UBFN6tdu9QYIHu5XfTS3Lmqr7oEgTHfh1zzTByhOCz4VWnlEwv4TfRS9+sCHyg5KTLAdvnjz5Sf2c=@vger.kernel.org X-Gm-Message-State: AOJu0YwFFasCs1jj0IGJNyEpqy+zEZ51wGFj+1IF9++YsPyeLsgM+Hbe R5b0tOL5RcIzYf6a8PQDG8dCAhmVPbP961NPpC3PxXGLoa4MGuBPpXbRUpu0bAICcYU= X-Gm-Gg: Acq92OHMsPUT9yDaOfWK+AzpGlynkKkCFdE/erQu+tikZi2cpsVO3kEXvo+lQ5BhLvI AkmyCZzJWWl588tj07pW+Afm5EZk2JGUBuqns+dWBVBb7Li9xTbIqtIpMQ1KEhKVCMhWKmzqxC8 vVF8InjtRKg2byb17v1jzFWV3LK3NM9zNPl1OrAJudiQ+TfEKZSuXoJ9BMA5KsJ69+bXKMkYpih Obqn3HzkaadCJ/vzIhYAbvM1i2Dl204WHH4AvEx0dGDNsWH+U/CoEggjH8cDf9AG2/VKkzDJmS4 a9ftH3S/FUqYuKbcrJNVH+LHJfPkjTttVZwKqiguwk6S5hk0gvnJbIWGsFQUo6y7Vo+C1nc4mSE 0bhpYQlnrLIltv49NTgpa9wlzmb33b4oF9lLS9koSVx1sktaVxJiQReyy730Cr6QdDK0ZqlyKEH 0cN3QnItq3FozB5dV4eY/yEPw8BqSQNTI3YkQIguu71Qx3LQ5xJW70fbNt8LnELzId4uaZkA0Uf lND7gduMottgetap3D8S+fGiA== X-Received: by 2002:a05:600c:a00b:b0:490:b58b:a8cc with SMTP id 5b1f17b1804b1-490c25d208bmr392108225e9.29.1781110595179; Wed, 10 Jun 2026 09:56:35 -0700 (PDT) Received: from localhost (p200300f65f47db046aec8c3a4b621e71.dip0.t-ipconnect.de. [2003:f6:5f47:db04:6aec:8c3a:4b62:1e71]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-490e2ac08d4sm1254095e9.1.2026.06.10.09.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 09:56:34 -0700 (PDT) Date: Wed, 10 Jun 2026 18:56:32 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: Re: [PATCH] drm/radeon: Consistently define pci_device_ids using named initializers Message-ID: References: <20260430102958.136859-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j7i4oay3bo3iievo" Content-Disposition: inline In-Reply-To: <20260430102958.136859-2-u.kleine-koenig@baylibre.com> --j7i4oay3bo3iievo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm/radeon: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello, On Thu, Apr 30, 2026 at 12:29:57PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > ... and PCI device helpers. >=20 > The struct pci_device_id array of supported device was initialized > by list expressions. This isn't easily readable if you're not into PCI. >=20 > Use PCI_DEVICE* helper macros and named initializers which is more > explicit and thus easier to parse. Also skip explicit assignments of 0 > (which the compiler then takes care of). >=20 > The secret plan is to make struct pci_device_id::driver_data an > anonymous union (similar to > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre= =2Ecom/) > and that requires named initializers. But it's also a nice cleanup on > its own. >=20 > This change doesn't introduce changes to the compiled pci_device_id > array. Tested on x86 and arm64. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) Similar to the amdgpu driver patch I just pinged, this patch would also be great if it made it in for 7.2-rc1. Please? Best regards Uwe --j7i4oay3bo3iievo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoplzwACgkQj4D7WH0S /k6nhwf/ZR7t94IMy/YBqi6Y8FtHqpdDkwZQQv11BcXWULYNcavX4/q4cA1Jtdd8 C4r3zAf5g//QeQP++hduZ4/5b0aQTz57FVJYbQNwN7Q1pYDIieIRdqk5iSL60/fa LKFWkXWES4SULEBeCHUJf1o51p9se8eI8a7hCUJ7JeoHpJlb406H8ei21SNzauEy 7ttwNW25irCTEZSEDm8vpoQ5pxLLFC1S6eRdo0v4WpbDMYyjFhN0RJlg5MqQpEK/ VoWGUzqTrggL7AyozMqLAbg7PkPDJJMbNoLF97PPf8NRWrdBsGH/2nAUjxHJgZ9K ol05cbNMBcNSQNGYdo82mJzhQKt6Dw== =1EG2 -----END PGP SIGNATURE----- --j7i4oay3bo3iievo--