From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E81661EFFB7 for ; Wed, 10 Jun 2026 16:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110659; cv=none; b=r3IpE6vm38SUxGKsBGcVhS6BoM9KR2H/wFwZDzCirmJ76M6UAtOx4Kf0e0yASZdFRWZW7lo6FNfnnV5wp7jCND3RUTxTg39R4x+oRNcC9ywnaz+UkUWzZucuDunlnk//7YgBe74ACHi7la6/V5tMGIjYNas84i89W0ojJAOoxXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110659; c=relaxed/simple; bh=mPEW3CnNtHzPk8zBkPy/ywdNcQQvY53+6mol56GVK44=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ml0tcOO8Y2X1+BXYY9eKmgp79vHaZCGHIU+6ClCkRdujA+7nICKYBgSua98njslhYjFX8pqdaOJxHher5iR/GQXu2DigGlWYRPSNQ2O+2evl7eQ+ViLXHBJDec3FDmj6cDxQV4eiExsWMm50E1ixpNN5qwxbwZ+XOFyeSkWLXDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HTiz0Mhi; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HTiz0Mhi" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-13721dfd471so9039414c88.1 for ; Wed, 10 Jun 2026 09:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781110657; x=1781715457; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1sXr/vhMEr0lILXdap+oJzs/4So97bK7XSSiLeEKlJo=; b=HTiz0Mhi/zOsX8nj/vuEq2BUDuAQxFEoeIX/8AFx3LbtvkcPwc+FP8uC6tZbJm29Gu zyqNIUPnUCVmXOIVR7GTvYOP79fKZGU4l7mbOossolip0+DFRGod8PU+K/2xUvvvjBGQ G/8bAfmUtlO1RJRs4OGBQt0pFsb4e7MVDQShVJ7yj2HqZ2pGIFp6YYpFnMpAq14aH1Q5 3jcH87KyqKH4fpn1enVkaffjoGtqs7wx22kqurKHSKXJB//Qaaty4z/m/8ekkc6H9ODm 9azu8pPhKI8g3u5La7HNr0BA1bpPj9agM+EcurEqGf08cxmRj6GYrVM/zrnWYhBRwFQ4 NXAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781110657; x=1781715457; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1sXr/vhMEr0lILXdap+oJzs/4So97bK7XSSiLeEKlJo=; b=p00anjl2Gow/HciB2GMnb/14UKJQ+iEbMDcb7YnBYYVkpFAFcdMLZ/vo8aRvYRiLj7 UHEGYs2IVieYZr8qb0fGxwUxBS83JetRfnSXqFVCqxuSMLO5A3CcZpRdKNbrglxnkBwv uBWH4KUBuju4bHRlIloFB5m4r+I9UmNo3IFCY2MlsuITLPQcmbMP0ZI3IJoZmkJwEuwK 68wLPS8FHSbF5UpGUkycV01HKQZGDatv67S8djNzKBXWbZyzpUQR+QDU1vgO+WpUfrjF XfijbGwrMmLtXzuistLbD1Ka50w/c0VF1mLIDjbphuSysGNzKKzovzllxdbI0chEBj9O lGag== X-Forwarded-Encrypted: i=1; AFNElJ8w553WQ5iJS4ysj9Rt23spJg+9Gut478of4Jxm31j5DCNYEBYZY7sqT7+5Pu/pIXaOsg+Gwahygy97ZH4=@vger.kernel.org X-Gm-Message-State: AOJu0YwlC7FOPfi5nLtcpFEwN8uvgTs6a/W9RMAQbSp8T0D5nWZPfyVX JvNSEz1S88xtcgHHXl4+wj0BrUX2SLUkGBPVUEl0RXXLWV2qFjzNdpfcoAl1XQ== X-Gm-Gg: Acq92OHxKbG1et9biyhh+58Rn7INKa7Da9+9pdECgngEHkv3B2kR9pa2qzNV3bU0vuF ooAuiNcRxyvBf6L6Jhj5CiNeBLs3+Irqk2CiCyy45G9AX1otuGVIDDLyh/4fptVAZukOuhaOx0o tp3RdosXveBxrXNYrJAkT0MWDQ+FFTCaTz9l+K9ahMv1bPmy3cEhVi8eCXNinjdr7jqW5ehlLtA JLeo60QKKxR+eY7yMBygBYNf5+nftShP0JErjlr1mVarBr8wUETOukzrhb9JIRAEaWmbkJvu3Y8 E8KsEl9SYzGrcOi1a9kiQanwT2D6P2dUN98KYGIAPYDGdvbA0mDyaGl8n8Sh/xDxZN746n2F2Tp fqz1TX+4JNZqKB16dVnaX6YA9gTeFCgrbh821KhtgH6dSdNd5BCiijFP2lfAU3E1Q7U+xOJiVSO Np5fmNLm/ChqA7gGQNdD5YdG3lqXkaVFQqFcfXZcg/43NAeHywXSAIhDCSFT50mRDiycDncHdOA mo= X-Received: by 2002:a05:7022:62a9:b0:136:6883:c4bf with SMTP id a92af1059eb24-138066a56d1mr14354458c88.15.1781110656974; Wed, 10 Jun 2026 09:57:36 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:ae0e:e075:91c8:6570]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-138063de4a5sm15151201c88.13.2026.06.10.09.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 09:57:36 -0700 (PDT) Date: Wed, 10 Jun 2026 09:57:33 -0700 From: Dmitry Torokhov To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Cc: Kees Cook , Werner Sembach , Christoffer Sandberg , feng , gongqi <550230171hxy@gmail.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] Input: Drop unused assignments from pnp_device_id arrays Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jun 10, 2026 at 01:58:17PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > Hello Dmitry, > > On Tue, Jun 09, 2026 at 11:12:49PM -0700, Dmitry Torokhov wrote: > > On Tue, Jun 09, 2026 at 04:53:25PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > > > Explicitly assigning .driver_data in drivers that don't use this member > > > is silly and a bit irritating. Drop these. Also simplify the list > > > terminator entry to be just empty to match what most other device_id > > > tables do. > > > > > > There is no changed semantic, not even a change in the compiled result. > > > > > > Signed-off-by: Uwe Kleine-König (The Capable Hub) > > > --- > > > drivers/input/gameport/ns558.c | 46 +++++++++++----------- > > > drivers/input/serio/i8042-acpipnpio.h | 56 +++++++++++++-------------- > > > 2 files changed, 51 insertions(+), 51 deletions(-) > > > > > > diff --git a/drivers/input/gameport/ns558.c b/drivers/input/gameport/ns558.c > > > index fdece6ec1df3..f70a96c4f1fd 100644 > > > --- a/drivers/input/gameport/ns558.c > > > +++ b/drivers/input/gameport/ns558.c > > > @@ -148,29 +148,29 @@ static int ns558_isa_probe(int io) > > > #ifdef CONFIG_PNP > > > > > > static const struct pnp_device_id pnp_devids[] = { > > > - [...] > > > - { .id = "", }, > > > + [...] > > > + { } > > > > This goes BOOOM! You have to keep empty .id string as terminator. > > How so? Given that my patch doesn't modify the resulting ns558.o I doubt > that. If .id was a char *, I'd agree, but it's a char[], so there should > be no difference (and the compiler agrees). Sorry, brain fart on my part. Applied, thank you. -- Dmitry