From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3647E349CCB for ; Wed, 10 Jun 2026 17:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781111731; cv=none; b=ND09AzNKjTkD1Cc5Va9D0TpJhvBNxUp3381+6JENm9KxzaqFiXh0zBzf4w4EhSCqpjeqQ5lOu6SK3TkFuxveQxq54VLS1sXqBxXRQdg1T5AIvZxcevSjiUfb35ETUB+8aQf2Xg88Sa23z/1P5hq8CTS5Vy+oamOe0t3Cck7RSNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781111731; c=relaxed/simple; bh=Iy2QNS57UCD2GYWcmkCdghK/35X06/sNE/jHUTsf+Qw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o8ueT/ZU079cPnSdEnZckZ3MwTHXegPA2IkcFpRlSNRAaXQ4F5q8zOfsdnVA/kBT3dZDnSYGchFySGv10uDxgLmsE6kg3rT3bTcJQV96uD3YOYyhj12qvqUakt4wpUDpdUyJ+0kUXUJ5SJwjE5QCQr+TrvFxwcMXHVVcv4U3CV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=eiFQLgHd; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="eiFQLgHd" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-45ef56d9b67so5513958f8f.2 for ; Wed, 10 Jun 2026 10:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781111727; x=1781716527; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Iy2QNS57UCD2GYWcmkCdghK/35X06/sNE/jHUTsf+Qw=; b=eiFQLgHdqDrZ8Ox2Qlcczl0MSW6EID5JdiBXyhkTx9YOzVn61YboZehbuwnmwNq9iG uVzfabMSizXf+/9ufhvpDp46jMrdkGXDufNzzj0itZYVJyOEo9nfJj8kITy5TvGvISUz +atJ+4zD1YRmw/zdrxbU9kOUhK6zUtMVYpCbRpVALVZKf/e6L+H+x/+j+KCTDgHNzjfV wc8FrNS1tDiNj9QEMKClMLuGWEX9A3su50kOeKZIO8jdFW+OKUX8SJK3AUtkNNaPyy31 OJALRgF/Ee9ExrppTXqAKy4cU/NFpRmFAKTzU9y5QMWXOPFNr4AMrOm+JikfL2E6qbp4 I4Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781111727; x=1781716527; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iy2QNS57UCD2GYWcmkCdghK/35X06/sNE/jHUTsf+Qw=; b=FErXeGETqYJr7B+WEyFphfxn+meP0NiHrp7zUgmoWcbrSVRZYb+TNnPfru3Ox9FbqH jV1OUVCtTY4xy2sOIvKxc1xiiG7XOseU7sF03kzYBJqN4sroHPTz/MAE6+uFFTU6hVk6 juL/ETksC3Qre+n9Cg591EUBvM048CHDVOAbleZkQUyxP66F0/RL2l0ElRUXjHNtPhXZ 5JrCbmrrEDBQhISSdaGd5GAAERQUk43BPnfLnoTMRHVKjb9IuEsmuP26cDasQiK7o3kt JqW5u0E5wYkuowFTUbntoESn8F8Cofah/ZsV1NnEUUB9fr2h4YzlT4s6fw1w3F+wb3oS LGZQ== X-Forwarded-Encrypted: i=1; AFNElJ9UY4yL1V+r3iSPPMjjkWYb6MBYyz62zHdSdA8bVHukoA1vdLg1HzkPAaxu6Fk+nj+SLbjA+/x+PBiabEM=@vger.kernel.org X-Gm-Message-State: AOJu0YwpD7Q5lobA62v1eOKNyXZXdv6wisN4V4PKvuFv0wSMnS7XLGpL 8NE7ugpf8VYOlg6Va+NGzuwDLDDCDCZ0Mybun8bnao28LthMWmjaZBAuS/Jusg/Cfos= X-Gm-Gg: Acq92OHj5AqqhePxC5+0xnTfA0UAE1KmbIV83SD8XItAAY/9SgOJgQFGQvpkx/VdXrh yoQ2u5YSfz2Lm93k74NVnK/lRQBmk49MTmmDXFMXLXXlSIsjDmwJbrba77t+TPPTSIzVOwzKS+0 ZswOBccMEvwtrFuXkKddfkpdQg/w/IQf0sZ0h8vamsEyLTusDIX3KH8Z8UUFzBBuMZJONKqWnAh nhQjgvHIi6jwwBZd1KkgA3EOodMExIKtj4ZkZ+OLfc8xz8f2dCE2OYpXECccZrkM7of31DhFZWT wHMWslysUO3RgWuqzwjC4WciYKupl6UedZxZnkZVLH91/sJ1EJK4aqIq5k8RXQKEiaNQbY2rFb3 O7paVMbelI8hsNlj8iVzvguvpJ/3q1KN/TqDZfAoHAermJLIDQ0YchOjkDbvFdPMOy9P3vM6Wjx vadVNnVKrk7BbsljWanJIQ6u+sfErk9JYXjRgZzaz/3Su4Lv9APCGnoXmtqdVoTxFZSLneNMpo9 KvyXLmOSR9YcTOXJaDrOKHT0g== X-Received: by 2002:a5d:4252:0:b0:45e:f684:7347 with SMTP id ffacd0b85a97d-460302e711fmr29192231f8f.12.1781111727249; Wed, 10 Jun 2026 10:15:27 -0700 (PDT) Received: from localhost (p200300f65f47db046aec8c3a4b621e71.dip0.t-ipconnect.de. [2003:f6:5f47:db04:6aec:8c3a:4b62:1e71]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f351d69sm129389556f8f.29.2026.06.10.10.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 10:15:25 -0700 (PDT) Date: Wed, 10 Jun 2026 19:15:24 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lyude Paul , Danilo Krummrich , Marcus Folkesson Cc: Laurent Pinchart , Jernej Skrabec , David Airlie , Simona Vetter , Jagan Teki , Liu Ying , Adrien Grassein , Peter Senna Tschudin , Martyn Welch , Russell King , Douglas Anderson , Dmitry Baryshkov , Biju Das , Tommaso Merciai , Manikandan Muralidharan , Luca Ceresoli , Andy Yan , Xin Ji , Loic Poulain , Fei Shao , Arnd Bergmann , Kees Cook , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org Subject: Re: [PATCH] drm: Use named initializers for arrays of i2c_device_data Message-ID: References: <20260518100401.631351-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="syrxtefw3w6ze7qy" Content-Disposition: inline In-Reply-To: <20260518100401.631351-2-u.kleine-koenig@baylibre.com> --syrxtefw3w6ze7qy Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm: Use named initializers for arrays of i2c_device_data MIME-Version: 1.0 Hello, On Mon, May 18, 2026 at 12:04:01PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. >=20 > The mentioned robustness is relevant for a planned change to struct > i2c_device_id that replaces .driver_data by an anonymous union. >=20 > While touching all these arrays, unify usage of whitespace in the list > terminator and drop trailing commas there. >=20 > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) who feels responsible to pick up this patch? > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > prerequisite-patch-id: 7779c63f16ef6f7247cdb71c89e66b27e299eb74 > prerequisite-patch-id: 6f920b6f8c31dc0ad1689200c37680755c20ce8b > prerequisite-patch-id: 1fd68e883664147052540eea19769ea9e92d0138 > prerequisite-patch-id: fff07090df18a39a361bbb091a3f17223b4606b4 > prerequisite-patch-id: a935aab66aa9896437ab9d757ef9fdc859d22495 > prerequisite-patch-id: d0d54f7acecd560cdeb6ea0c0e5ae77a50695d68 > prerequisite-patch-id: d7876560b3bb9b05ac462d0a9b09b50efeb9b5e1 > prerequisite-patch-id: 65531f0504ac1885c6c4ed6be0e6a206a9795d5b > prerequisite-patch-id: ec83e7e18d66da9ca677b5c8180a22bf3717c8fb > prerequisite-patch-id: e33193d1a91f5819128db924c080caf1c5198667 > prerequisite-patch-id: c8862be402a445f30b9f5c91b07afdc840e7e21f > prerequisite-patch-id: 33c001d1b8ecaf57ebe53c321d82d671bc82b647 > prerequisite-patch-id: a59a578f49eb5147623aab9fdcacba405b9c8353 > prerequisite-patch-id: 5eef512b8a5a1ec1848a939928168dbb719ca72e > prerequisite-patch-id: 04746bfdfe146af71d0c41e225978fb42ce977f5 > prerequisite-patch-id: f8aeb0b768ae718aa0dab188fbad671aa4c76501 > prerequisite-patch-id: 8e0b48a5d5f8bb91933d440eda8f065590e5ca97 > prerequisite-patch-id: 5ca261e980415013434edc099b6f741b7a96c7a8 > prerequisite-patch-id: 912c3a7f7fa847c59d499e004965b805a63c8836 > prerequisite-patch-id: acf784c7c03d3cd14a8a19610a6d8995e2b5da6d > prerequisite-patch-id: 09a95efff7875781ceed199c60204a2603960f4f > prerequisite-patch-id: 8051fbf0a60e5e9d34f5e7623a5159d32fbc511d > prerequisite-patch-id: c4897ca0762d01cd5e8cb6e761e5ad95eb9de918 > prerequisite-patch-id: eb0120090b9fd1e1f668919cf1d81cdf1b684b20 > prerequisite-patch-id: 239c0e25dae78755bb553eb9049190f6ed6c056a > prerequisite-patch-id: d988f27ca0fac3a2b06cc8e465aef5e0a4f09bd3 > prerequisite-patch-id: 8fceffb98fa11bf1e709a51022afa05eb12236bc > prerequisite-patch-id: 3575869dc475ff7191d314632d496cc67aabed53 > prerequisite-patch-id: 8916058071bcbde1a4d06c6a8981c443132168f7 > prerequisite-patch-id: 7f29acd91e1c8b8d4f21152cbcb8a8b0bdb6f963 > prerequisite-patch-id: 65cf39c97cc086b6a89965079cccb896f089a0cb > prerequisite-patch-id: 915b7a2276c5a38944107c84bb282271d0bf28f4 > prerequisite-patch-id: 76d499a624150588f7ef07dc087e70eca6f33419 FTR: These are bogous, there are no dependencies, I just wasn't attentive enough to drop these lines. Best regards Uwe --syrxtefw3w6ze7qy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmopm6kACgkQj4D7WH0S /k64IAf/bZ4o+TIFIOWyuTVAdkHqAJkFGW6kNqTKAFMqC3TZbmVRyyZwNTDTpsk0 UdAe5MrsNhDs+DykrkP9EwzgLbmwcm2kCjfT5NruyBaQv3EDbtzj6iUeT2G6QJTK uwp8RjuEHX4YbrisgPnOvJCGXCGHNlV88/vl/+xdD8zuMGUy30vQRjUTWgkpmaWD gvHWpF3hZH8tjCyxln877iFtgO3Zv5iVBHnfcQiILsApXG3zNtzjn3hI5vz8xDKX sJ2mkRhDuyQWE1wmFNXahNn8fjsCUnrIBpJZHNbAZ3pZwpRvYfYvj9hnMPu0Phd2 wc5r8vL9Unrms0KBeU9RKF1lbK6OXA== =5xFh -----END PGP SIGNATURE----- --syrxtefw3w6ze7qy--