From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A76E343D86 for ; Wed, 10 Jun 2026 17:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781112454; cv=none; b=esMKtNzNs9g6QPgd+H9vtdBA3Hqm+Om7eoCGo5Kdv9XACsSUKKm+5JKDLaU11wIRUsBhFf/7bbFrrk9AtuwbIC2MHMu07K5nr34ZzPv7jNIMEtAfvfLV8SgPv6/hcKxiBq5Ga5Hxvy9qyJcp3Yfx/F0Ye11xlPrSJd1Hj4HwTQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781112454; c=relaxed/simple; bh=kzErf+z7JSp8P7msfJBxTyBqs3Tz4zofU5rff5W0bhY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hclYuhUN0jCva1lg6V2+RYpB8xH41eOFUDfWpOnreOPI+XJMLuKstf+zVS4mkLSQWcJ77+eSFscUIGPN5jIcdkWegWjKnZMmzDpFHkeN+G9EwbAiaBAzXPD+UYxBOFy1Hd0uxp3/mVxJbWP4hhJjNiQj5neb9PjCa/rCkMS44aY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=EHo4M2qj; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="EHo4M2qj" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-45ef616daf6so6556424f8f.3 for ; Wed, 10 Jun 2026 10:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1781112451; x=1781717251; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kzErf+z7JSp8P7msfJBxTyBqs3Tz4zofU5rff5W0bhY=; b=EHo4M2qjxGrZ2NUVrsanfw4tDu+UR3Df+TuPdqWA/AZap5BweSbOe9mDvtzcH3Gt52 4/UU3iYp/Ilc+W/MOvCqyMxBHZ1kbq0osPLXTtNpMZCH9wcKdrTfBXzS8q1cVcZJCMWo fwKgQTHRk40XO/Lj0LRHdAofQiqXNNKiBOqZkw3ye4Fq7+sFhnqJLvpHW+ONOm/u3B7h i1Zlp/cRkjOQIqLGINoB4ZiOJk5GtpOieMIg2zKtT4iHN2X+AG2edbhpDGGhZC4ufJxe CtNO97uAMEmCWoObwIlY86vyzeD1hgHBCQDSju3JGk5A/sp64Xrkmk6wde6T9mLkYDDz xfYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781112451; x=1781717251; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kzErf+z7JSp8P7msfJBxTyBqs3Tz4zofU5rff5W0bhY=; b=A4S4pS4WZND4NI5pdp46jr0X61Vk8SyrDUUEFmHCcXFXHqUXj0CM0XPlBXL+t6ux+5 iF3ePZrn8WvjHy5UJ83os93kjucwYv1PEd9iG3XmbrKKsO+uUuqRTJ1MMik3pGPNMYT0 xEeMPxp+d7L840Z+9aPOsZPOwGx8CxZ+1LpwEVQw15larFZCB4nFZM8i5xaemRh5YqWd b0UEkpwSiO8WlnUDE0rzlQzxQWF99dzISf3dh6R0ERYx4umBiPap6cqP5DXok2hUyLDd brOb9uwNO26YMhmM2kg7yZqp9fBaVX+Byw2MEk+kBwr7DjjvFI6Zo3P/0eWu2LdsTkC7 vGXw== X-Forwarded-Encrypted: i=1; AFNElJ+it+ghgscWM9aDNvjB84TsYOpEl6lDa74b8A3LtqDD0Vsw/gGsilljuYvQgZOfMT8BQ5P8WGpm6oCx8fY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1FtzRGEjApnQltJg+nh/m+7Iv0YdUTeNyJmsE6mGsodLlSpsA YdC9OMgrNOd/A4m/5YQMV4ovUqP67IO56EG5J9lNLJgYVmI2CknpthGPA2VfesNkeac= X-Gm-Gg: Acq92OFB5ioyJTPR4Bk+3v6O5mjLx89ZjUcpWZmi+FS4sUtzYBLxUHd8kRnwAlCYcuc OeTGa/sqw5quStW+PgbZYzCUggz2435OisVVkZ9NO/lNKg/sM+g5YkY6P6Z7h3DA9OJdled8Ovs zQS1aaecIZiMY6khc5MIHXQkQl+D+XQ+afFGEwqGTuBUmTXOTcj0BA9Rr086p6mpMdmOg72aM++ wXRnv6OI23ILuLBqo6J5av9fZ4gv5UOhGRF7icfPe1TNyrfb8/zlkdjXZim67NL63A9RMf0rblE eVM6+T/t2vb10rguCqg7VBB13tUeqKjymwoBBpqFR8CCQE6XGFZ2ZH4koIoSsN0iGOh2N//KWLG ghaY2pECKOUL941EUY7iDuO1SdSCPstoF5tRXGsRFyfgF5Yw1uI8PbK+DhKA2+1HpS1drlDJQzY GIukUJXMalp5Z2jNiOJR0OqBdqJst+3gYAlCsYvo0h3WQZ8HLgCvhO7IMo8CDQxbXwRGwJdSIbd 8ZjL6p0FkRr22nGq/NruYVNGg== X-Received: by 2002:a05:6000:29d6:b0:45e:e509:d2fa with SMTP id ffacd0b85a97d-460302dc8cemr29014867f8f.3.1781112451467; Wed, 10 Jun 2026 10:27:31 -0700 (PDT) Received: from localhost (p200300f65f47db046aec8c3a4b621e71.dip0.t-ipconnect.de. [2003:f6:5f47:db04:6aec:8c3a:4b62:1e71]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4601f34413csm72375859f8f.21.2026.06.10.10.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 10:27:30 -0700 (PDT) Date: Wed, 10 Jun 2026 19:27:28 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Marc Kleine-Budde Cc: Vincent Mailhol , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org Subject: Re: [PATCH v1] can: flexcan: Drop unused platform driver data Message-ID: References: <20260528094540.1867783-2-u.kleine-koenig@baylibre.com> <20260528-fluorescent-sage-ladybug-43261b-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="va5ro6u5yud5cge3" Content-Disposition: inline In-Reply-To: --va5ro6u5yud5cge3 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1] can: flexcan: Drop unused platform driver data MIME-Version: 1.0 Hey Marc, On Thu, May 28, 2026 at 03:26:29PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > On Thu, May 28, 2026 at 01:00:15PM +0200, Marc Kleine-Budde wrote: > > On 28.05.2026 11:45:39, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > > No function in the flexcan driver ever accesses the .driver_data memb= er > > > of its .id_table array as device_get_match_data() returns NULL for > > > non-of platform devices. So drop that unused assignment. > > > > > > While touching that array, drop the trailing comma after the terminat= or > > > entry. > >=20 > > Does this mean that commit 5e6c3454b405 ("net: can: Use > > device_get_match_data()") introduced a regression? >=20 > Yes, I'd claim that this commit introduces a null pointer exception when > mcf_flexcan0 (defined in arch/m68k/coldfire/device.c) probes. I wonder what your plan is here. Should I send a v2 that also drops the unused variable that I missed in my v1, or do you want this NPE addressed first? Best regards Uwe --va5ro6u5yud5cge3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmopnn0ACgkQj4D7WH0S /k6vGAf+P07h8wiZcTaqCGFDv3/2aYJax+UlwADLeBRQ17i1kGZEG57kJGO/DtG3 AJ3UwGF1EmwGKsZe0o1RY2aslrGi/H+9/YoB6DmZVyG+tox+0yvi4bM18XZOyllV mklJFAB1Zm7Lbavlmq7U0WsaQ5JcNIOn5VvRTBuJsyGluJfMHr+F0n8qrzqEtMYY XR/+Iaexegpe75VAXdLqPnlKPC6FzStBYkOWr1jLgIKJj5BrvXmlkAoL90+4yiJy zv4gtclllsXd5q8/Btjclk5kPNVk1HYYVVVZDPRZ1VXeWg4zK5E8a8Gktu8SHbri co1ZFXcx/TxF9w1oYwXWBdkD4jWZ3A== =yx/5 -----END PGP SIGNATURE----- --va5ro6u5yud5cge3--