From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BED83BA244 for ; Thu, 11 Jun 2026 08:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781167639; cv=none; b=VIXzZvmvqQ2II0r85L7v0q+Tu9k6ShVyBOoxTlf+QMPXrhi/CWmVqpKyWcSOFBXXwpXlPx0qQBJDBgQ1S9xeXJyZFdkGK2Arox2UpR9OSyTvGhy8Hf75aCXLC1B+BwJCpxbf0q7ukjMA+6orgfHW6wkP68pqdgfF9Fg/l7pPcrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781167639; c=relaxed/simple; bh=6GRgpmQ11YqUvsN8GpHounNBRSMDuddaI7rINzjCMvY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RyQRY8dJTvb86WBwGFmKNl5VBQaPFbTCYK2dfF7weC9g1iNKpSdWnkBpx1YB5W6ISftenQGAZY9bJ/hZS7130/wd3ZwIv+A7jOHNjxi3GUfcKs/9/BIPe9KD6ZEWG6RXWMCx6cyybNvKSfvupfD4doWq0IclEzKYjZgB1/Bhh/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=l4xgm7CK; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="l4xgm7CK" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4891b4934ffso58095e9.0 for ; Thu, 11 Jun 2026 01:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781167636; x=1781772436; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tGU8nVvV78ihw3NmTIZ6FVq1Rp8AH5EC4+xF0UY8JZg=; b=l4xgm7CK+rUzf5d+Fe9lBXQoKHtUOU5FgDH/0JiBKVqymtW852n7XbEKPCWsg5RisN LX5z6vnvegSMmuL6l+b8PE21hGy3E8LIPIafQsPT0UUU8h1FsOGGZP3RiHIzWqIq+nKD w5d+5JU2Is0qnnc3tBzkUlikRi4cuGF+TXfEszzq181Q0uWaG8EpZIhy9d/A7P3XrT5T 2a/PY3STwgVIrhm0V9oGewHwp0QHihFyLNgyAnxCKPkGI6B3ibMq7XJ1ZWb8IqAyj4bG uaKWWOWzp4fhup2mtE4nYB9CMSJgyL8D/3o/fIN6X12Lor/NF5W/g0UC/+Nzg3P2j2Md NICw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781167636; x=1781772436; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tGU8nVvV78ihw3NmTIZ6FVq1Rp8AH5EC4+xF0UY8JZg=; b=hU/thF5MddHRMJoex/7Nu3YZtmHheON/DQC5eQBUf076g3q6BPkmjvHzPdrM0ZVttd QfTIBhvFHHrls67atlR0t4A3dznSXYbKzIzMHVovlLuRUzjdfA4VDSx/UtdR9O80YgqV GebX72zRxEOQOQ69hAXUHl+lZ9QMB6aTWq3tnE4gr4+bsYM47X7LHq8AnfcFPu9N8zZh RiZ0qsCD0fz69CxziN4J6fEE2rtLWszvmUVsiR2TcGK3VztEUDwKtypudHNrFLwCEvgK SBENQ0Hi/xryMkqayJrvVbN7rw1LyNQdvtn4cC3SfAW0UrEaYBoQKMMO2rw50Uu169FN goaw== X-Forwarded-Encrypted: i=1; AFNElJ+DNB41UdA9NlGT2bDOKO7y+KfAWQJBV+5cfhBYJu89s6kl4dG1KG7D+YIAkVl2y2GoGb1Xja4zW0oIS/c=@vger.kernel.org X-Gm-Message-State: AOJu0Yycw4ZNUZfo5d7Kg4MU7wCvXLdU5T0kLj5CMHCZ9Bp+kS7Pq6hG kDCyM3wRDvfA5X3n20YJrgzK3zc4KNQ/f4+TU5WY0W4X8YEWV/lmF9vl4JyWJsCiXA== X-Gm-Gg: Acq92OF1Y7BI4hNEbXFjSo3cccgFbmAv/rBtC3ou72wmHF2hNV8zGWOl0RYdRYQmrhV vGsmoiteuFQzV0RCtduAmpTpLh/qmB9pu2tqmf6KUFl4xLqMOmZQ97gl9+UMjBehzZWakdzeI8/ yX56XEIs0GG1mOOjJiwEuYdcG5tRCpXZLVS1+2RZRce+Nb2B24Pm08jkfXAB1zti5Ib8M7xlzKM N/Z57XTE9fRyn/+tWPhBelVEZHWD+nxAoP6ZMgVY0PMKkGPdla2m0KaDZYrJ82mWnaNlmw2XpFv qvpuxDfdtpk/pGo2AEYViuMeAi31S9yNs5zSt9KgPv3emy8LZjw8HWgbpjv04xwNhkV2tX/PXhL 7Ni8Rv6Tunb9uElu3XZXL/YNoSMH/g97eXvMf2Z0NjczHkwPbK2nlxW0QLcewu7b9jCQaH0h74F 2k/MiWLT1fYjXKInqsKKBtc+XdtdwNc0eNeBSVr8//CX9ILQT/EfmaBaUaFwRtbVp7pAZIW7YBc FKsgpvc X-Received: by 2002:a05:600c:1d08:b0:490:b0f1:3422 with SMTP id 5b1f17b1804b1-490e47a5322mr838045e9.10.1781167635397; Thu, 11 Jun 2026 01:47:15 -0700 (PDT) Received: from google.com (143.11.148.146.bc.googleusercontent.com. [146.148.11.143]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46028a6dcbdsm66597719f8f.7.2026.06.11.01.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 01:47:14 -0700 (PDT) Date: Thu, 11 Jun 2026 08:47:10 +0000 From: Sebastian Ene To: Vincent Donnefort Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v2 2/7] KVM: arm64: Support FFA_NOTIFICATION_BITMAP_DESTROY in host handler Message-ID: References: <20260608165549.1479409-1-sebastianene@google.com> <20260608165549.1479409-3-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 10, 2026 at 09:53:24AM +0100, Vincent Donnefort wrote: > On Mon, Jun 08, 2026 at 04:55:44PM +0000, Sebastian Ene wrote: > > Allow FF-A notification bitmap destruction messages to be forwarded to > > Trustzone from the host. > > > > Signed-off-by: Sebastian Ene > > --- > > arch/arm64/kvm/hyp/nvhe/ffa.c | 24 +++++++++++++++++++++++- > > 1 file changed, 23 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > > index c20d45191085..91e89d889c44 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > > @@ -688,7 +688,6 @@ static bool ffa_call_supported(u64 func_id) > > case FFA_MEM_DONATE: > > case FFA_MEM_RETRIEVE_REQ: > > /* Optional notification interfaces added in FF-A 1.1 */ > > - case FFA_NOTIFICATION_BITMAP_DESTROY: > > case FFA_NOTIFICATION_BIND: > > case FFA_NOTIFICATION_UNBIND: > > case FFA_NOTIFICATION_SET: > > @@ -893,6 +892,26 @@ static void do_ffa_notif_bitmap_create(struct arm_smccc_1_2_regs *res, > > arm_smccc_1_2_smc(args, res); > > } > > > > +static void do_ffa_notif_bitmap_destroy(struct arm_smccc_1_2_regs *res, > > + struct kvm_cpu_context *ctxt) > > +{ > > + DECLARE_REG(u32, vmid, ctxt, 1); > > + struct arm_smccc_1_2_regs *args; > > + > > + if (ffa_check_unused_args_sbz(ctxt, 2)) { > > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > > + return; > > + } > > + > > + if (vmid != HOST_FFA_ID) { > > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > > + return; > > + } > > + > > + args = (void *)&ctxt->regs.regs[0]; > > + arm_smccc_1_2_smc(args, res); > > +} Hello Vincent, > > Sounds exactly like do_ffa_notif_bitmap_create. Could we use a single one > "do_ffa_notif_bitmap" ? > Yes, I guess we can have only one method since the only difference between them is in the number of unused args. > > + > > bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > > { > > struct arm_smccc_1_2_regs res; > > @@ -954,6 +973,9 @@ bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > > case FFA_NOTIFICATION_BITMAP_CREATE: > > do_ffa_notif_bitmap_create(&res, host_ctxt); > > goto out_handled; > > + case FFA_NOTIFICATION_BITMAP_DESTROY: > > + do_ffa_notif_bitmap_destroy(&res, host_ctxt); > > + goto out_handled; > > } > > > > if (ffa_call_supported(func_id)) > > -- > > 2.54.0.1064.gd145956f57-goog > > Thanks, Sebastian