From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F1C3BB131 for ; Thu, 11 Jun 2026 08:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781168396; cv=none; b=hfho0wnG5NwV9AuuVWB1yaKrKNTONjk/oNvLObNGNBoXZEpO10bchIBfPi9KPgz68cRjhBautQSTdehRq/NmiCC/ehfd+DL1hoRH+Gp35FeKYnp88vYFaHmgugAyF0YK3TpsvJvuMsTJFOBOPtWlgqpWe6xAaQ6PC4LEZQO7IEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781168396; c=relaxed/simple; bh=QgmccsK5dccfuLVpxKECy02Cyq4fJw4GPvf8VwxeAUE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=LQb3M1hMOjz3XkfGDbBRBjYc077EClVQsyce0cXTDerdsBrkKebrYdslF8rI1GlgmvUiuFjaHfa23HuP+tNdzcul0LjV0YLvKpFt8ChtkWEi9BpwCo7w8NjBFIN6ovaxCiP3Efya92P60NIVuAMzDNaH1fwTKWnzNui2itHC4Y4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kQB2UwI/; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kQB2UwI/" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8ccedaf0b54so51139656d6.0 for ; Thu, 11 Jun 2026 01:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781168393; x=1781773193; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=SDvuiII1LGFXTJ1G7CEro7BK7MfvK9SQkUAqzNSYDJU=; b=kQB2UwI/TU51v2bvMzTGySkGg8hGMVg/4zYf+LVdTIWnK5ntIFSjDxFVvMpYt4OLUI Jvcmq2kNGkDYFavHIK68p86IZMQyveDi9nmbig4OLnvo7ZJgud4k2lRxd+JaWcbJ1PV5 +IelYTNu93jUT3KsUjSSccSG6UaKGKWnTjQaw90CO3ZUAuKskbUWe+HrNOmKRkl5RHhF 00Q7+IgzQYAATmssnJLE9WW3SZqsvY5NlUj5J1u41O/8uMG8vxUmOV9QQl1DFHLFSMLs r11n08qlrcFDHIO6f+P+Kj7sYdXVEmtXHcBVS+b3h/O71emqHJBleX5fm+Hc64mEtEOj 9JvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781168393; x=1781773193; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SDvuiII1LGFXTJ1G7CEro7BK7MfvK9SQkUAqzNSYDJU=; b=O9JbGtzEaPDna7bzHslOQSXu57H4RSn07yWlXP3yAsC1yya9Xvf8ykgLe0uuIA7G3Y yx1awJgx3piA9EaeJ+J6SGSHGtfyK+oFKbOsm/eCjtP1pwv4AXJg6rWGQwUrcr6oIfvH JzZziELeY2x/GC2JIr3nqmHNqy/z5Ig04zMhsOpvBo/j19klfNqkvaliJ+wNNOfD5J+B IBzuy78ObdKMslbkBmFTbO6otIFDKv8YpndUQzrMjk4skJdCmMJxVVWs/A5NxpsgzA0p etgaueihE30Wqng45HzZN7V4gdTp33Wn0AovLlnZAXECc8phNhN/TcYZjLWMPYuHDkB9 Mq5Q== X-Forwarded-Encrypted: i=1; AFNElJ8gcpz2j+IdGIF0qh9ifEhJynzwKdd0az9XM0osSu4khaEFR7yy1pwbefoiMOqeliFataHt7jpUXL9lA9U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm/S3sIq4PBHrv78z0DbCVF6Jdk0xQr/HA3taylGe3WVs/c7vM +cCve11k0utKZlDlqmtBbjUjI7SBcgNrKl0UeLvzwWji0p/NJj2VlwXL X-Gm-Gg: Acq92OFIOmC8GD4JvTo6BMZZUcmkg8TLkX1r58dthX5v+e5YWTtDnnIo3Ow5OiHWcsN 4PP7tT78KxnSlhsU8AMV2ppueO6gFKEWSN/6kXn3P74vK/KW0hQWww7wzBpwkSqNIgkYUUcEGG7 d+R+5TA2/i7COLq1yv6BdIpNcgLKy/76WDhh0l8Q8UzG8NqVXnqbs0sgqUhe0ktPIWVDzQKNzMs G1zzkHctUd3WSzxNK7a61vp3RuQMuKW5a3k1ObIxYpO2rUmmTc8Bjorpiei4if4QOplhjsDVX41 dQrsk00i8OFujCA3k9zsaYF2XzRNmtYNaU00xFC2R2He3HM/yVvspUwQqxFjtW74vvxWKcGIBFu 8Q6aIqj0qcgPjnArcGnfVnOMHI0a8BVl1/w8N1VA9/8xOVTj5aO9HUFUI091CBNuXqRJOY15QPz /KvMqgQfkp8Ef1Ff+w2spRYLcpMA0= X-Received: by 2002:a05:6214:434a:b0:8ce:d77e:e5f with SMTP id 6a1803df08f44-8d1dac289e1mr31795746d6.36.1781168392876; Thu, 11 Jun 2026 01:59:52 -0700 (PDT) Received: from localhost ([149.40.50.215]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d1e819f58fsm12553176d6.11.2026.06.11.01.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 01:59:51 -0700 (PDT) Date: Thu, 11 Jun 2026 10:35:28 +0300 From: Dan Carpenter To: David Howells Cc: Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] smb/client: Fix error code in smb2_aead_req_alloc() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The "*num_sgs" variable is a u32 so "ERR_PTR(*num_sgs)" doesn't work. We would have to do something similar to the previous line where it's cast to int and then long. However, it's simpler to store the return in an int ret variable. This bug would eventually result in a crash when dereference the invalid error pointer. Fixes: d08089f649a0 ("cifs: Change the I/O paths to use an iterator rather than a page list") Cc: stable@kernel.org Signed-off-by: Dan Carpenter --- fs/smb/client/smb2ops.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index a3257815e661..a8f8feeeccb5 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -4359,11 +4359,13 @@ static void *smb2_aead_req_alloc(struct crypto_aead *tfm, const struct smb_rqst unsigned int req_size = sizeof(**req) + crypto_aead_reqsize(tfm); unsigned int iv_size = crypto_aead_ivsize(tfm); unsigned int len; + int ret; u8 *p; - *num_sgs = cifs_get_num_sgs(rqst, num_rqst, sig); - if (IS_ERR_VALUE((long)(int)*num_sgs)) - return ERR_PTR(*num_sgs); + ret = cifs_get_num_sgs(rqst, num_rqst, sig); + if (ret < 0) + return ERR_PTR(ret); + *num_sgs = ret; len = iv_size; len += crypto_aead_alignmask(tfm) & ~(crypto_tfm_ctx_alignment() - 1); -- 2.53.0