Re: [PATCH v2] liveupdate: Document that retrieve failure is permanent

[Pasha Tatashin <pasha.tatashin@soleen.com>]

On 06-11 09:30, Tarun Sahu wrote:

Please include at least a sentence in the commit log.

Otherwise,
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com> 

> Signed-off-by: Tarun Sahu <tarunsahu@google.com>
> ---
>  include/uapi/linux/liveupdate.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdate.h
> index 30bc66ee9436..d06aa24350b5 100644
> --- a/include/uapi/linux/liveupdate.h
> +++ b/include/uapi/linux/liveupdate.h
> @@ -168,7 +168,9 @@ struct liveupdate_session_preserve_fd {
>   * associated with the token and populates the @fd field with a new file
>   * descriptor referencing the restored resource in the current (new) kernel.
>   * This operation must be performed *before* signaling completion via
> - * %LIVEUPDATE_IOCTL_FINISH.
> + * %LIVEUPDATE_IOCTL_FINISH. If a retrieve of a token fails, subsequent
> + * attempts to retrieve the token fail with the same error code. Failed
> + * retrieves are not retried.


>   *
>   * Return: 0 on success, negative error code on failure (e.g., invalid token).
>   */
> 
> base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce
> -- 
> 2.54.0.1099.g489fc7bff1-goog
>