From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88F333346A8 for ; Thu, 11 Jun 2026 16:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781196000; cv=none; b=fBYYL5/GOoWddrGS19WwXP5ufG/Rnqc0+r5H2w6mLybnKubLCGBvf1nqNfP31IMjGuRrpHACXcjuZttkIVB7DMan57RXfJyItlalyCm8xNotmHsYGHOczFZ1dsT2oftou0N25t1xRYdIse4mUzCaTvXWdkMDVeTOcrkYOwu8eZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781196000; c=relaxed/simple; bh=2a9cuN712vVqrsGbJylXLw3RxwasxEHAXA5P2t2Zs2I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s5qyd9EJm75RR7ScJBoODsdTmc3HLdO797Vdz0VkLaXgMKVB5ydhDnoiG2hIwDx/hEeP+BGmZO2rXhZQ+2kdU7lO+Y+Ka+Qtfbjo5u94ntMiv1tR+vW6Ct+SUHrc/Ty9HsOKe5XFU+jJDAGwuS0v7oDsA+fDW/GqusgazgOaR3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D7M2rIvJ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D7M2rIvJ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-490b9318997so60710595e9.2 for ; Thu, 11 Jun 2026 09:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781195998; x=1781800798; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=siXDPwMtJVGXiYb4vYM49WpVCt548BrdN6XowbmkPpY=; b=D7M2rIvJs2/rDqfgU9gYhfnJ3uWHThsn+nWqnyrBZxuPCeSyhLsF/AFk97I5nwDial rYxtHhLgShrUxGYqMlm43YOpF45jGUCgG//C07rzsSpuTVjSKyd5roNsq1LUG59pylHQ KZlC41plM4B9GaHTxNsmTwL4/mTyzX4iSSyNnsh0YtK4ANshplyHOQVNq+jLSFcjydL/ 2Pt0j816rKfUc5UKc8sOPup/o9yXVacm0dD6R0ubGSx9SgWqMXO4g6kTxS0zHyfW/hQi wTYqGvEHTL8QPZHMQ74MzRuhTTBwd1RPLjJuOWqzhrARtXXEbzHo0cyPdgvsI4z6yNmB XKJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781195998; x=1781800798; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=siXDPwMtJVGXiYb4vYM49WpVCt548BrdN6XowbmkPpY=; b=YvGHheVeG8CMjXb4EDW62oIqMw4aJUuJ1+MkZv7fCco2I1FSskbNhh/UsuIhUShU9i UHLLqRMBfzDv7hsD18tNO21Izds49Bie8kECM++j1+r3JxSYTs7EwceV3BEYEUZ84pCj JK6Gp3DvNtAkinB613pspeibhZ5gpg58Qlx5yunNwiBixP8MmO7LyogZd/9yLfJ/irNh vMABFyeIYaRYq0TLecqDeWDUkuVazv5hAum8hEK/zBQenOyE8OP2jYMzH9EAY9gYRAWi h19S13cUvfSUgJ0OWv5c0SLAH9iNUTiAJ+ni3T71m0tERuYQb8/kv8pORCJBPFDTwBj6 e0Tg== X-Forwarded-Encrypted: i=1; AFNElJ+U0TzyXwjwNu+m+TNTeYd6J5D2Gmr7zBvPzg+U4ePBvmQ59UNeIfOjnW7y6TDnCGo5eUdnfXOUuKidg2A=@vger.kernel.org X-Gm-Message-State: AOJu0YwdAYI5SJf6l3CFNPEXP/jeLBrAmkv9LSdYpDH+gV3nynM8xNs1 XFq3K8Ks3PMchUrg1AjYW3MH6hNpITSaiHBZPL1ljSDkdn08/meYuccs X-Gm-Gg: Acq92OEbqERzYVqSic02c5bmy0362YNY4RwUcE/yQ0aU+2WT4qnDHMJ+zeqDBQTUgZ4 0DE3wfvPTQxHWkNdoat1EDean5fUc9GOWjgPXDZBfrBXj+AQaz0wGOqiyYuwXh9Ip0upb+3Rn9o UBBDCMhF1xw2UMb2Ee8owmKMcFO6ZzUSbnZ6LGs035QlUvZ7yAGFUlQ5yfHWJquc6YOQ8kTqn9M BNPusKicq68WGazmY+R5Sdl80ejRFwwNwjuh9rX0Gxr9fmqf3hlljs/SwD2+hMD3mlnlYGt06rQ 3s8RwCD1veS+4+qB+pFIsYWnJzeOELw4J2nrQZ/mSMnNNPuVWkupDJwFZxDqQcBYh4n+hoXl2J9 ZVeuzPXyQ8Dge6o/+lLLiiuE/wZgwkjTW8zc/Gjb7ImBC2qelKHal0UF2oFbmVq0VZgIjuWnrKW Sf9kDTdgk= X-Received: by 2002:a05:600c:6994:b0:490:b724:5085 with SMTP id 5b1f17b1804b1-490e5619ae2mr49924405e9.33.1781195997918; Thu, 11 Jun 2026 09:39:57 -0700 (PDT) Received: from localhost ([2603:c027:c000:3cde::f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2c907ddsm76572415e9.6.2026.06.11.09.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 09:39:57 -0700 (PDT) Date: Thu, 11 Jun 2026 18:39:56 +0200 From: Louis Sautier To: Damien Le Moal Cc: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Ranjan Kumar , "James E.J. Bottomley" , "Martin K. Petersen" , Guenter Roeck , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 RESEND 2/2] scsi: mpt3sas: add hwmon support Message-ID: References: <20260609164423.2829699-1-sautier.louis@gmail.com> <20260609164423.2829699-3-sautier.louis@gmail.com> <93542109-2101-4d62-aae4-bbf058029663@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93542109-2101-4d62-aae4-bbf058029663@kernel.org> On Wed, 10 Jun 2026 08:22:22 +0800, Damien Le Moal wrote: > > +config SCSI_MPT3SAS_HWMON > > + bool "LSI MPT Fusion SAS hwmon support" > > + depends on SCSI_MPT3SAS && HWMON > > + depends on !(SCSI_MPT3SAS=y && HWMON=m) > > + help > > + Say Y here to expose the IOC and board temperature sensors of > > + LSI / Broadcom SAS HBAs (such as the 9300, 9400, and 9500 series) > > + through hwmon. > > Why do you need this ? I was following the logic used by NVME_HWMON to prevent issues with SCSI_MPT3SAS=y and HWMON=m. > > + struct mpt3sas_hwmon *hwmon; > > This should be conditionally defined with "#ifdef CONFIG_HWMON". Then you can > simply drop the config entry you added. If I dropped SCSI_MPT3SAS_HWMON, I would use "#if IS_REACHABLE(CONFIG_HWMON)" to match what i915_hwmon.h and xe_hwmon.h do and properly handle the SCSI_MPT3SAS=y and HWMON=m case. What do you think? > > +static int > > Again... Not going to comment on the others. Noted, I will fix all of them in v4.