From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D63D133122D for ; Thu, 11 Jun 2026 16:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781195892; cv=none; b=aXzP9i/Y1WsaSNhb2CMmGj83O8vriw/X34juySY7d00niHYed1MdvcZTlBrM9hGtA56UHVSJ3S2bCtQ+TkNHehWmE3dlP8J12IldseGGbMNxuzaydm0cm3lInQnVja4IFqKPdaWiPk3qMWRGWjgBFPHtData+nlpiYM8kSoIweU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781195892; c=relaxed/simple; bh=eijCJIWCzE7dOaaMhC6ytwZ56c0ngQs/vO7TF7uckw4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ue3uaEHhk73mEH1Xd+hpLTOs7FvZKmxpC1RqrLnioRniKgBrFRkP8kTkJm6ZhihHg3BLXUZA1znamzH40gdP0p2adR8CAeSdn8tAtojMhYiHM3/oiIRXO2AaSWyw+7E5xMQWxiEJC6M32Iz2jdMic3XpxRyhDaU2E3o4m7v+Ow0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b4WJaeE6; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4WJaeE6" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso3765e9.1 for ; Thu, 11 Jun 2026 09:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781195889; x=1781800689; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/slxkBaga7WdFYUIk+bpf71i1yduik1uqRPXNyL7qIk=; b=b4WJaeE6pdENyvdjptJtoSyd6Lmr08PZTlPH8VYoRNetEVFqxAUuviMFCJHXdNjUJF 4JbtiVnkdAumsYLd5RjqE0ekopAvlYvzaJARHjuJB1TNk9NMFO0AzJP0e4syIvYE35Pv yCarcKe9bqDLhJQ7wnbCYBg2anRxJcxg0UxCfBEFrgKIKMVnYiESguzniNEykK1MprOB VVtHoqqD+A5KRlt71ynUCQFPqUWWXKHKvHJ04F+NAqa/BOJhLyKuRuLjFdIu7gtzWOjH DSqGcoV+VyPUKyoR/1asmxBW68Fm69chXCNDdovENvF27//1R0BqW4+l4x/a0xIIIUDd Td6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781195889; x=1781800689; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/slxkBaga7WdFYUIk+bpf71i1yduik1uqRPXNyL7qIk=; b=VfbfrGkK73DE3KJV0xadN5ykyXFinonjLDd64FLI8cQ8HxevkLiGHwXlWBGpbZuFHp +/cSb6KeSt7urDuJbtAMFUrXGHTA7+5NNP8OPS9lvb98InTjkSQX2ngt42sY640/k8cn BnOmmm6yiiIywTya7M2MnocfqaReBfm1tAE0X/aTlKf7nBLWkFBAxBPx4s7JzpeO2Y44 duTcDKCxvW2KM2dmVP97VawV8+H1NVzhDw79nZg7wOAU7GTHkezPWoJEb7hNncmxw1lB /Qh33OkPN3MBWg/6VrH9YIuuLH1D2DvIG7jXSfuzcQXECcBzVjK+sGgeXYltlLT3lEY0 Qjcw== X-Forwarded-Encrypted: i=1; AFNElJ8uRrH2hUAvwsJx4J4XKRPVyoknLCd+OBNdbMK9y1LfcRahPhYCGCgBGLyygkasPBJ2842J5BrEd6+cFfc=@vger.kernel.org X-Gm-Message-State: AOJu0YwbrI0agY+xRFiFA+uGskH1SHqg8Gl3aT0+CMHTri3pvI18HYXb RQJNH61DS6aOOY0pS5cKayH2xAqjdhieMNx6lOTzDwBbSKnvhwsVZH5s X-Gm-Gg: Acq92OFXLqM3yieWHMQjsGN/AnIEgfmC0dTYA43BEgY2ldYqK6Ngr7NpA0lb/8tHY8V WWlwhEsiLHeTlSKCFplOpfu48m6PEo5igznnWMYANTEQ+KeXSY07/d0xqJ2D/8dKR7g2pCRmcU9 A8rgZCA0vCXMjFtGRHXUDM3cHqzw8JvxuSctBudGcPBNFLiUrQIxsHobyzcu8Oeb+h39A+vXYQw R7tvSDcK/4N/+o2f3jmhFHj++VI8GzfZHvWmSn9irHRW0Ncm5wg+SzHpvW1//FYVUbPv3J+xMIP 7oPQpDNTejUD4szFEaVuwt4Dw935cRJp/wZ6ssEltJkGocuAFUzkGHgFmnQ8PH1/A95xuG1GKR8 OYfyWBcYjLH9oYOynR356+VPSTtP4GG21DFeIHm7X7/c8Cb2V96zkB1kwPJssKTVn1P9lTTwok/ m0YulYsg== X-Received: by 2002:a05:600c:8b51:b0:490:e5c1:b8b9 with SMTP id 5b1f17b1804b1-490e5d0ff6dmr48188685e9.0.1781195889065; Thu, 11 Jun 2026 09:38:09 -0700 (PDT) Received: from localhost ([2603:c027:c000:3cde::f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea4a4db2sm266015e9.1.2026.06.11.09.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 09:38:08 -0700 (PDT) Date: Thu, 11 Jun 2026 18:38:06 +0200 From: Louis Sautier To: Damien Le Moal Cc: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Ranjan Kumar , "James E.J. Bottomley" , "Martin K. Petersen" , Guenter Roeck , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 RESEND 1/2] scsi: mpt3sas: add IO Unit Page 7 config accessor Message-ID: References: <20260609164423.2829699-1-sautier.louis@gmail.com> <20260609164423.2829699-2-sautier.louis@gmail.com> <5effba66-0d42-4d42-9833-f2c0be6874ad@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5effba66-0d42-4d42-9833-f2c0be6874ad@kernel.org> On Wed, 10 Jun 2026 08:12:05 +0800, Damien Le Moal wrote: > > +int > > +mpt3sas_config_get_iounit_pg7(struct MPT3SAS_ADAPTER *ioc, > > Please do not break the line after "int" Hi and thanks for the review. Sure, I can change this. Can you confirm we want to diverge from the convention used by neighbouring functions such as mpt3sas_config_get_iounit_pg8? > > + Mpi2ConfigReply_t *mpi_reply, Mpi2IOUnitPage7_t *config_page) > > +{ > > + Mpi2ConfigRequest_t mpi_request; > > + int r; > > + > > + memset(&mpi_request, 0, sizeof(Mpi2ConfigRequest_t)); > > + mpi_request.Function = MPI2_FUNCTION_CONFIG; > > + mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_HEADER; > > + mpi_request.Header.PageType = MPI2_CONFIG_PAGETYPE_IO_UNIT; > > + mpi_request.Header.PageNumber = 7; > > + mpi_request.Header.PageVersion = MPI2_IOUNITPAGE7_PAGEVERSION; > > + ioc->build_zero_len_sge_mpi(ioc, &mpi_request.PageBufferSGE); > > + r = _config_request(ioc, &mpi_request, mpi_reply, > > + MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0); > > r = _config_request(ioc, &mpi_request, mpi_reply, > MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0); > > is a lot nicer to read. Do I also align the signature like so in both the source file and the header? int mpt3sas_config_get_iounit_pg7(struct MPT3SAS_ADAPTER *ioc, Mpi2ConfigReply_t *mpi_reply, Mpi2IOUnitPage7_t *config_page)