From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B34539936B for ; Fri, 12 Jun 2026 06:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781247455; cv=none; b=a8FKkgHOhZY62fBmFC8iEIkh8dksSespxX7bJpfnVhSlNGbHjucYmV1mKqeg7PixP49boVW6qwxQySNgqPTYtbBVCDyqZw1h969beJBxfFQFuc3i0qRPwy0We9LCLXNW6UXEkUcBjdnh5cNUbuv14N4Ss9xLkwagA5Qa4hzOG/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781247455; c=relaxed/simple; bh=byMJhabNYwGEhJL6SvhjgMUaIO3MbjP5YtoK6lcxZs0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nq8+sSU4KrfYestwuafS/auaUI73r1eg/Z/kiqcViBR785aDhdATwNzAyFgXvQMeOvGC1t9JDtsbYiYfPLhJttxhw5stXp++SzFysts3MIIoHXC9aAPKvCARZ2bDyXWH1FLy4nCqFvJvsPOoz4LyDteuroQ7MX6/VfZWPE8xqxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=g5Hua4rc; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="g5Hua4rc" Date: Fri, 12 Jun 2026 14:57:01 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1781247452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GIitjL39dxJf9LxQN4sCrPpxW0XRSn3ANFFsR4nqH3g=; b=g5Hua4rcbgAG7214++AzORxnpvMhEQ0G2b1SP0zXnUOnGyvN/XqHHnlWXJmWGy9UrSlxIw +9Q5Gvd+7qjyrs1+4v3jTGO6mX3S85hhLxxP8HHIB7bg1BDEdhqLzIE+4zLElU5yHLyQL4 QaCoOlEkK9ttpdv/2KUeQfocH/rkALQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Hao Li To: "Vlastimil Babka (SUSE)" Cc: Harry Yoo , Christoph Lameter , David Rientjes , Roman Gushchin , Suren Baghdasaryan , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v2 13/16] mm/slab: allow __GFP_NOMEMALLOC and __GFP_NOWARN for kmalloc_nolock() Message-ID: References: <20260610-slab_alloc_flags-v2-0-7190909db118@kernel.org> <20260610-slab_alloc_flags-v2-13-7190909db118@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260610-slab_alloc_flags-v2-13-7190909db118@kernel.org> X-Migadu-Flow: FLOW_OUT On Wed, Jun 10, 2026 at 05:40:15PM +0200, Vlastimil Babka (SUSE) wrote: > The two flags are added internally so there's no point for warning if > they are passed by the caller as well, so allow them. This will allow > simplifying obj_ext allocation under kmalloc_nolock(). > > Also it's not necessary to have the extra alloc_gfp variable for adding > the two flags. The original gfp_flags parameter is not used anywhere > except for the warning. So remove alloc_gfp and directly modify and use > gfp_flags everywhere. > > Signed-off-by: Vlastimil Babka (SUSE) > --- LGTM Reviewed-by: Hao Li -- Thanks, Hao