From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B7F35A933 for ; Fri, 12 Jun 2026 10:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781259413; cv=none; b=HKUzkWiFSrlsa0XK9VbswCHn6Turpllst2tCtCBmc0Yo6z8glttttl8ssJ6WN0d0P59sbOQzG8/0O95S0glSeSHHP+t61mF6M6hSJeCSONKroWVKbUVbf3/k+uJPbKDoabuLT5Hbz2prxs+QM1tZPKhyicI/9FwgCpS+4v89qew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781259413; c=relaxed/simple; bh=uRGqAUbLGPx9nyepRTrjHIkg9zcE4+/sWRP7D2Y4Ffw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LjZd5h8eCep0vB3ZuUE8OYL67in7aZ9FE5KajElKDKtZZVG+wFL15ymrm6N0ePaXyb8J5M4qNPqisB6rz3l7+ufDVIvK5yxxqZ7XiQPo1R10tDiQC8COoYco6zx+/YYXPx2RgDuGnZglzCtBw90aAWQgdY3tsAx27+tphi3hxAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KxJidsNf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KxJidsNf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F4571F000E9; Fri, 12 Jun 2026 10:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781259412; bh=tp979dOtptTzRkrt7cWz3mNJUs8l3Jn3MYNI++Yv9oI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KxJidsNf69oQW0KQKUAZaie1bUEXByiLwh5nLRR1MlAI4Oyemcm8x9Zpd2/TelgXs 4HmTGCj+jqKokm9Ufp+9BPgjA+auWrJOcZU136457TaCap4KJVqhMZJRlPqJI97vm6 TPDe18mlypGNJeiTaobCwIGVqWUJS4j4kaOiSkd4w2c0DJcdj1Cymp7GoUVVKR9VxJ /deDrCi4i8HKL/oVv5VMViOYuFnyoVli1rfPXoIdgU1kxv4mC2mnsRGWgDipMoxXrL AfbOY70Jh3r8F6hP065+ubCzu4T27FZgFrGygE2uFHr5I8mzP6HZMRyqNocu85UzR4 jAjKKLqREdqXw== Date: Fri, 12 Jun 2026 12:16:45 +0200 From: "Oscar Salvador (SUSE)" To: Huang Shijie Cc: muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, akpm@linux-foundation.org, zhongyuan@hygon.cn, fangbaoshun@hygon.cn, yingzhiwei@hygon.cn, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pedro Falcato Subject: Re: [PATCH] mm: use mapping_mapped to simplify the code Message-ID: References: <20260612073032.33228-1-huangsj@hygon.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260612073032.33228-1-huangsj@hygon.cn> On Fri, Jun 12, 2026 at 03:30:32PM +0800, Huang Shijie wrote: > Use mapping_mapped() to simplify the code, make > the code tidy and clean. > > Reviewed-by: Pedro Falcato > Reviewed-by: Lorenzo Stoakes > Signed-off-by: Huang Shijie Reviewed-by: Oscar Salvador (SUSE) > --- > fs/hugetlbfs/inode.c | 4 ++-- > mm/memory.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 78d61bf2bd9b..216e1a0dd0b2 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -614,7 +614,7 @@ static void hugetlb_vmtruncate(struct inode *inode, loff_t offset) > > i_size_write(inode, offset); > i_mmap_lock_write(mapping); > - if (!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root)) > + if (mapping_mapped(mapping)) > hugetlb_vmdelete_list(&mapping->i_mmap, pgoff, 0, > ZAP_FLAG_DROP_MARKER); > i_mmap_unlock_write(mapping); > @@ -675,7 +675,7 @@ static long hugetlbfs_punch_hole(struct inode *inode, loff_t offset, loff_t len) > > /* Unmap users of full pages in the hole. */ > if (hole_end > hole_start) { > - if (!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root)) > + if (mapping_mapped(mapping)) > hugetlb_vmdelete_list(&mapping->i_mmap, > hole_start >> PAGE_SHIFT, > hole_end >> PAGE_SHIFT, 0); > diff --git a/mm/memory.c b/mm/memory.c > index 86a973119bd4..5335077765e2 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4386,7 +4386,7 @@ void unmap_mapping_folio(struct folio *folio) > details.zap_flags = ZAP_FLAG_DROP_MARKER; > > i_mmap_lock_read(mapping); > - if (unlikely(!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root))) > + if (unlikely(mapping_mapped(mapping))) > unmap_mapping_range_tree(&mapping->i_mmap, first_index, > last_index, &details); > i_mmap_unlock_read(mapping); > @@ -4416,7 +4416,7 @@ void unmap_mapping_pages(struct address_space *mapping, pgoff_t start, > last_index = ULONG_MAX; > > i_mmap_lock_read(mapping); > - if (unlikely(!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root))) > + if (unlikely(mapping_mapped(mapping))) > unmap_mapping_range_tree(&mapping->i_mmap, first_index, > last_index, &details); > i_mmap_unlock_read(mapping); > -- > 2.53.0 > > -- Oscar Salvador SUSE Labs