From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D87A93D47BB for ; Fri, 12 Jun 2026 11:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781263665; cv=none; b=uEU9u9x+M01e87hvdxCqxUbNPI1F1B9ZEZWuP92ocic5prwrwtoKb0BwuOBrwQ/TGT/3S5LWzUvtB+10kSHikA+ROhZqTsD35BDTps/JqBlu/qb6aMkcnbolbuS5bV5ekr8mFefbpxaaWkwPb3AezJI1Ylhn4TPbKLx9sispBsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781263665; c=relaxed/simple; bh=d+w2KM5PL5C2KimehS5Esc0JceN1aTb6ivn6DXuosrQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Up/jA2bEMthAcGpIhUTXqntbQanNCHUAUv83ONezRSotJN0lfaOjl+PvKdOe5WkO98XqzZMDNyaNd0MibsfSLy2bE/6e0fH9uMlPoXBcgwFMCOe7mUTEao7H7rNRuctrUntHdrF8IWTBJe3dQQ6ZYJDoe6GCafQFJ0N3NET2vDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LVmXynyZ; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LVmXynyZ" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-51780bbc560so16160521cf.0 for ; Fri, 12 Jun 2026 04:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781263658; x=1781868458; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X2S6USlGZ8AevZY+EuoNTTF7i0a23QNfsyQXA8t1ZiA=; b=LVmXynyZWchz8IhSL9dudd79LeuKXMVr9DY1NjGx6jZY9jT/ImwgYMclJFprtIjN6h ET21Z3rd+naPhCn2ur3J5Pf6t0jsBozDeiTUC2JtiCjRpJJX/ZftNNQiqxRIOj3CQQXC xoaTFQ2Z8tp9/n165lzwBsvTB6ULBS5TdPV4EOrN5H48hsi9I/vswBHSwjBTozxoNfAU x25+s0jeRZwUfb1zIutbvoZvCQ2u1Rb7eyLrT8gHhAR4QvzRFOR7aDjeQEBRURRXDLEO rZeoQdjWCd4bFHgibeVyi6CeJ5NXT/TPcIn668KhooJKQfgO36Wzi4yazXM/9Q6QuuWd UjYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781263658; x=1781868458; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X2S6USlGZ8AevZY+EuoNTTF7i0a23QNfsyQXA8t1ZiA=; b=Ln4a3hkiJhxY29SCh/847kTVWJ+YpYjIHR8U3X62Ju+swqxMIziWmquaN3u+lGNNH1 xgHFg+tyI+WTC5Y91ja0EmEdykF/judPtmAB577uFfmyjhBlMmuicHeAR9F39HWa3hRe iMp4ukE21zDgAqhJjY08LUEi2Fe21pGoP16sqq6Hl20+KhqIG4A2lc+L7z6Od1UXYESk E6/5WO0yFiDxEYsyaZMP9xx/ROAloNxzHGAjoQd3WdKrqjeot74sCJ1pzdxRU/tpUqU7 Vk782ZpVid5e7QLg19zZ37RidhHwUJDMgDTbHzFpS/vziRla2ym8ev6NuAjLNkN84HAM XHOw== X-Forwarded-Encrypted: i=1; AFNElJ96GnJSHupxmRe0WyLSIqQ0b5dBZ7+ZX47GVY0ag+7sFH42VB6Bz+kYLQyOI8+cn4uQIClXl+8H73Z7Vak=@vger.kernel.org X-Gm-Message-State: AOJu0Yydr+YCNqqgS9pruXUsTrfhivQlJg3QmDzxPK5l+fhpr6b+oBeF cM4fAWP7wZtLBH9mqxL8GgEwVPqDpzRoJbKSVLCgYNTA1TWcLt8eNzxY X-Gm-Gg: Acq92OEOCRPe8qKfDkqCIpdQPc3zR/oIIPUk6mnkt58+NCBNUatNNvSKjU26NfGAxct FAW626DgtjM+owO2bFYlTIq51iPFZiE4byejwpu5uE48LtX1w+04T1oQIB07h+i/3GqCO/fffh/ eMReg1YVVkr5s+dBYyZvrC+3HciqG5143DBfTsiJiPk8NoACtbtTa+bDBD3asmq9GFsc+XZ9rR9 ZqXBGNYPeZZFg+gnII58sR2jiJdQoOU2CYBofnolKvT9aKWH2EZ67LWtDQ3fYww3VLmGd73pwJt PNZboniTrK9EqGr/GbvmTQTioDTPml0YqgV55E/tQsDqV+pRbj45ROSRQBHjKyLp969wLTFUXjx /fcf5XoIRRui2v492cPAaBFvJzLNgv1b/+Iz8Z3g46Pi43E/mwIO0BFe4TIUZdTPrM9Vk7YaZNp rmmnZF1qQPUHEssDa6gg== X-Received: by 2002:a05:622a:244f:b0:517:64b2:2388 with SMTP id d75a77b69052e-517fbcc58bcmr31767711cf.15.1781263658445; Fri, 12 Jun 2026 04:27:38 -0700 (PDT) Received: from localhost ([43.225.189.109]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-517fb79e2f2sm18254261cf.17.2026.06.12.04.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 04:27:37 -0700 (PDT) Date: Fri, 12 Jun 2026 14:27:30 +0300 From: Dan Carpenter To: Steve French Cc: Steve French , linux-cifs@vger.kernel.org, Shyam Prasad N , Paulo Alcantara , kernel-janitors@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Tom Talpey , Bharath SM Subject: Re: [PATCH] smb/client: clean up a type issue in cifs_xattr_get() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 11, 2026 at 03:33:50PM -0500, Steve French wrote: > Doesn't your patch need a cast in the following code in xattr.c since > it returns a ssize_t and you changed rc to int with your patch? > > 315 if (pTcon->ses->server->ops->query_all_EAs) > 316 rc = > pTcon->ses->server->ops->query_all_EAs(xid, pTcon, > 317 full_path, name, value, size, cifs_sb); > It's not required. The ->query_all_EAs() pointer returns ssize_t but the two functions which implement ->query_all_EAs(), CIFSSMBQAllEAs() and smb2_query_eas() return an rc variable which is an int. I would tend to leave it out, but if you want I can add it if you would prefer. My real motivation for making this change is that we have an "acllen = -ERANGE;" assignment where acllen is a u32. Then we store the -ERANGE in a signed long and Smatch triggers a warning at that point. But then we truncate away the upper 32 bits so it ends being fine. regards, dan carpenter